From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7880B4A13A4 for ; Thu, 23 Jul 2026 13:15:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784812527; cv=none; b=RJraCaHjO4/7+wTk6ZNcbQykw/uu7FpjGI5TIZcMFBrdlgpeN+d9cJGfHwTkCbwv4boRy6rl1FW4OJQuhHQ7NJYeyyJb1wRSUDMI/Igs0cRYlpEjnNqo7Dny9pSK84FgrOH5MawuSFEKkbayxdX+PNh9JfounyLja8lsi2THIjY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784812527; c=relaxed/simple; bh=aME50YQWurrWPMxFmSklDBm9jntBrHtiwEEG+vN4Pyk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mqhC/NnGZ/JBFfxXD9RhggNSMnybZDhUWZrkkqCzGp8PjOVqo1RQtDiDem6D4iZ6qCXXZsFIHGxZVTqiVkgYCrl5FDbpnQa3JSuFDHZ3leq3IFFDMFCqe2hxcMYryBzpUp8pzb4C2rV8s6oi5mtDXvffBdenSji3i30EbDeb3tM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=YvnfJFYl; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=j+O1sPD8; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="YvnfJFYl"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="j+O1sPD8" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66NCvh6U020926 for ; Thu, 23 Jul 2026 13:15:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= O2Yu9Mq1SFTFe8Mrc+cdWZt3E4WobO9rD3AAbFfTYOQ=; b=YvnfJFYlc6uMK5J6 USf20nI4P9ev31sIlk3UWubOmQvdg4ONcUSaWbPX/M3TX8HH/AD4tZGHQmkKmDnM /PJLc6E5vREwL6ZeBCZFEYoZ79EDzNMwIBboa6UToePWcKHMGv4gjgmqZOvsnisJ z6pD6BvX1Cdx5IKX0s5TRnWO+W/pWqo9J4JDKZJaAw05lekqmQf+U/iTcN5AF8lZ cJPzNFlUURdUpoLxzaLGzdSE7v+cScvu9Ds7znmnMPhHsvs6abVn0Y4Ttm4DHNQW eu+8DZqpL2xazJLJNrIx2GXsKEsGF/htrKWTLELE66umqLD67eHikWNqfi68Au6f ktpijA== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fk6c7k6je-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 23 Jul 2026 13:15:16 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-51c1c7f135bso11074321cf.0 for ; Thu, 23 Jul 2026 06:15:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784812513; x=1785417313; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=O2Yu9Mq1SFTFe8Mrc+cdWZt3E4WobO9rD3AAbFfTYOQ=; b=j+O1sPD8yGupPQAUfn6e3TtHUExDOdeNBp+XfH11HX3TU7ObdEB3dX+cTbvkwChiQ3 R6EbNSnvmruH5dlmX4YoQjGDghjICZx9KCmNRSuL5TKZfQWiNFYNjY6f/WnTiViGdBJ0 dzk+hD+rTIuElSFI3XLD6t9aMvA8XtpEMb49toIAsGxOu3hiuMLgDRX484FJukh+eImc uii/WGPOHJ26i0QTyq7HzqJmbkGlplmctgWo+e9Pw3dphjL9j9ELtRcxoGqAteG/9Sv0 o9h6NvtKT91xXrqRmAmHyViT1pQGDQmWHl7G5q7+FZef2HiRMxEC+VX9oTRNkn/lZyym Anog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784812513; x=1785417313; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=O2Yu9Mq1SFTFe8Mrc+cdWZt3E4WobO9rD3AAbFfTYOQ=; b=MZyFgdnKtHPbUcUbHuIMsXxk0IcYmdfB8ph2RM5vOtDT9SyGDL4EKuHmPWq3SdRgvu rAG4iwyXEpAHhKKGNYIzbhvZjlv8PD6gIdKrEArM0PYey6V7IL8xWb7ng8Oi7sLN6Ave UCiigkrnnAoExd0WM9UAmAbqsip1A+L3JqQk2HD5CIWJkikhO0T/Y8z6bZ0wON7j3H5w tCJJs2Kk5lqTKYdyew5r4xz7Dc44WiSk2vyfCiXBJIheruCrTyhp/WK/ZgBM7YbTpyHg sYDqx2WACYwJvDnu8XOvlb/OKmxDAl5crL4Ki3HycXgCNFoqTsTeYOrxL+2INfzwJ0r1 444g== X-Forwarded-Encrypted: i=1; AHgh+Rps0F1iAh8KpvGWvapStKd/Z4HB0fjbGB9RjuBsI/E56VAQQ5rp0Dju9SURVF5POJCcbYUMgYibKfDj7pM=@vger.kernel.org X-Gm-Message-State: AOJu0YyQSmEYQw712Cyp+YCsgTZspMQHIm6PeUU0pcG6wM3GKxWtzR9p fGFx6auj/YDedhMKM2QznP9m5wSrCN4TeXrbnqzrYNachWGllsvihxW+Qyprt8S18a867u+voBJ V2MGhSEQKZ5KQ6Uae2mYNEiDvPGIAszSpn0iAscK3wR8j0o4BRfSSivSUoWsLM+sKCTw= X-Gm-Gg: AR+sD10lR07qu8US/oWfZI2sKZN54zfyGhsI+dC76p8bOEd2dU2C0lhlhfzQiMPfXPO QYah3Vz/jisW/N4G0Ai0sn0cNlZ/otbs6k6WxMkNzPe7ft7YLam1hqsy27mmvbKI62H/6FsPBVI EdDQF7ufQd0KS983QNpSt3j/dOKDacBdmOB9vGgN0psv9D7tfNPSpTPq0fcMXhN0XsPZfMYwqlp I57FSMSuvG2wkho77DaKC8ZoNAsSbnwWs7QZOXNVia/Y56cGGCxorwne06rXergGzdO0AAr7N8X iaI+NVHV+UjTFjkVPRM+45t1iFKRE5unOQ8zKTfCns1djbgq6mNBJ/5JlehFlDnzsLrdHQbjrzF PHQrfeeZUUvtQKCgGNRuPdR8aZMjTN0GUFnA= X-Received: by 2002:ac8:5a0d:0:b0:516:ed02:c85d with SMTP id d75a77b69052e-5283ddfb06dmr27815461cf.3.1784812513290; Thu, 23 Jul 2026 06:15:13 -0700 (PDT) X-Received: by 2002:ac8:5a0d:0:b0:516:ed02:c85d with SMTP id d75a77b69052e-5283ddfb06dmr27814741cf.3.1784812512670; Thu, 23 Jul 2026 06:15:12 -0700 (PDT) Received: from [10.219.57.229] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b2a9d31c73sm1031686e87.52.2026.07.23.06.14.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Jul 2026 06:15:11 -0700 (PDT) Message-ID: <01237c3d-7248-4460-a115-512ca3d0a706@oss.qualcomm.com> Date: Thu, 23 Jul 2026 18:44:53 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v23 03/13] power: reset: reboot-mode: Add support for predefined reboot modes To: Pavan Kondeti Cc: Sebastian Reichel , Mark Rutland , Lorenzo Pieralisi , "Rafael J. Wysocki" , Daniel Lezcano , Christian Loehle , Ulf Hansson , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Arnd Bergmann , Souvik Chakravarty , Andy Yan , Matthias Brugger , John Stultz , Moritz Fischer , Bartosz Golaszewski , Sudeep Holla , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Florian Fainelli , Krzysztof Kozlowski , Dmitry Baryshkov , Mukesh Ojha , Andre Draszik , Greg Kroah-Hartman , Kathiravan Thirumoorthy , mfd@lists.linux.dev, Srinivas Kandagatla References: <20260714-arm-psci-system_reset2-vendor-reboots-v23-0-e7453c548c21@oss.qualcomm.com> <20260714-arm-psci-system_reset2-vendor-reboots-v23-3-e7453c548c21@oss.qualcomm.com> <9367ec1e-d01c-489d-aa3a-fb361538331d@quicinc.com> Content-Language: en-US From: Shivendra Pratap In-Reply-To: <9367ec1e-d01c-489d-aa3a-fb361538331d@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: A73X2raokm5UFQW5vuWKs9epuS1RwK-F X-Proofpoint-ORIG-GUID: A73X2raokm5UFQW5vuWKs9epuS1RwK-F X-Authority-Analysis: v=2.4 cv=baZbluPB c=1 sm=1 tr=0 ts=6a6213e4 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=v7qggGzDPz5B41Fs5RsA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIzMDEzMCBTYWx0ZWRfX4pZCiTyh9gRQ 56LTQwuxJFsScM11AjYq+kbk7B9c4VeU0Qo2yQPJjpCySfohWqgo9ZPAjpsYy6MECUsMY0g01KY SEsUgiQ+sVB/XVUn4ibR1WZ7hB1IdUk= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIzMDEzMCBTYWx0ZWRfXyujZatlDGPxn xy4m5H/lhFViWm+Rak8ElOo7FR03PT+GR10BObMe5YI87DCmPgnrSBfKnX17DWEiz9WSu4FTT18 I90T4AB0CES5LAkyU4sy5Kl2OOFoWy6or0DpbN7lO6MxiCWXOPfgF1627N4VesWK+Sx3HYZ7SLp Ux5zH4r5I01lUomx01odSbt8OCBbOoHc78bEgAt7+ss5yFlH/06UySSZlbay2ucRZ2oOiEcnXmE HSixRZ7BHLh05khJ8TTXaF61EDIck5vWaiF61Bzso83rUuydNDf9Gc8aCd9SmC91UFcgTv4uoKn Lnj53VZUi4Xi4iovwciNkosQiLUEz4rw8SfDQdBe4A1Q/vbpdrAeD/gKv3AXLjwcY+3RUrNEsAN 2uUvJSBzGWpjIKZmxKLfU9eHyydoC+jDdZRgdPFUSxPnSP51Ma9/Cc9Y8ibW5vhm+LJVS5LmjDZ j7k4Asm+d1uuduZrq8Q== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-23_04,2026-07-22_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 lowpriorityscore=0 phishscore=0 suspectscore=0 adultscore=0 impostorscore=0 priorityscore=1501 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607230130 On 22-07-2026 14:34, Pavan Kondeti wrote: > On Tue, Jul 14, 2026 at 10:46:31PM +0530, Shivendra Pratap wrote: >> diff --git a/include/linux/reboot-mode.h b/include/linux/reboot-mode.h >> index 34a81e4b4f95..b216c7595f7e 100644 >> --- a/include/linux/reboot-mode.h >> +++ b/include/linux/reboot-mode.h >> @@ -4,18 +4,34 @@ >> >> #include >> >> +struct reboot_mode_entry { >> + const char *name; >> + u32 magic[3]; >> + int count; >> +}; >> + > > I see some where `count < 0` check, should not this be size_t or u32? -- count = device_property_count_u32(reboot->dev, prop->name); -- this can return -ve values on error. and we store the count in info- >count. Still the count in above struct can be a u32. Let me review this. thanks, Shivendra