From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06D5F2D2398 for ; Thu, 20 Nov 2025 14:27:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763648826; cv=none; b=hNmNw32AtP3bQe7ESp+4QSSAtMow5YospCjqqWs7X+fSeYTCtVH/6GXhgX7iebG1CuH8pQzhs9uSkCubmlEpWqYj14QKzKpF1pqujLE44goj2Cne23RIpoW5OTAfO1mZ6d9vF7XoSEljirW2OizHDXiTgixLNipzLgvJWgA9G80= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763648826; c=relaxed/simple; bh=oJbE4whOASdh+8bRk/HsytKHkKG+HmcYnxmUcrLLYSM=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=JctB1czGXOBW80oFv0FC0bO2iVkdUio6f/RrlSXijumbIflGYT07oU+BQS6FkAlcuxA33FNELx6SF20Pt82rHHm/VPPbYbl80KK8ZKxn2SxSP3E4+gFj14v5DNeH2VIeZrDfFDX+svi/PGiLtsT/n/+wm3k3qFESgnZnYPsms+Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=PH83Dq1Y; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="PH83Dq1Y" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id C5FB54E40E3D; Thu, 20 Nov 2025 14:26:55 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 834836068C; Thu, 20 Nov 2025 14:26:55 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 7E37710371C50; Thu, 20 Nov 2025 15:26:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1763648814; h=from:subject:date:message-id:to:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=qhSEdyzC1I4mVfbpR7tEIxNfN51B9bJ3G/OVA1ZGy+4=; b=PH83Dq1Yzq50xd6WxvKIUx/T+7l9TX9VbHg9dLb6Oz5nvKlKdlC47SGOS/KILeMgYDDPCz meHwIgd1x0mEAlKica8tu+Dq2EAVLtxRajW8Jd/UlQm8jdY/pkxEB0ABELh3+Z2cxO3WGB SwIXJ5J/5hzGVe8vxUatZek1GiWULQtWJyYychK4sw9iaIsJt02dOR24b8mB0NtyrMlHZU 7xVujetb0Z/JY67iMHWEvoIUBGznPemGymcGSgstWC8ZMFvL+zJY4dOP7hSzAqGVl1L3fd uRMFAtDHScg3efLvHeOPy6O+lsJX1F7Whg2CkAzRUaivrKQk4nCpT/n0Q/Hr8w== Message-ID: <0123aef5-9d85-4794-b868-831544d2d63c@bootlin.com> Date: Thu, 20 Nov 2025 15:26:49 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net] net: phy: mxl-gpy: fix bogus error on USXGMII and integrated PHY To: Daniel Golle , Xu Liang , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Raju Lakkaraju , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: From: Maxime Chevallier Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 On 20/11/2025 15:17, Daniel Golle wrote: > As the interface mode doesn't need to be updated on PHYs connected with > USXGMII and integrated PHYs, gpy_update_interface() should just return 0 > in these cases rather than -EINVAL which has wrongly been introduced by > commit 7a495dde27ebc ("net: phy: mxl-gpy: Change gpy_update_interface() > function return type"), as this breaks support for those PHYs. > > Fixes: 7a495dde27ebc ("net: phy: mxl-gpy: Change gpy_update_interface() function return type") > Signed-off-by: Daniel Golle That looks correct indeed :) Reviewed-by: Maxime Chevallier Maxime > --- > drivers/net/phy/mxl-gpy.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/phy/mxl-gpy.c b/drivers/net/phy/mxl-gpy.c > index 0daf0e86844a0..0058284b08f3b 100644 > --- a/drivers/net/phy/mxl-gpy.c > +++ b/drivers/net/phy/mxl-gpy.c > @@ -541,7 +541,7 @@ static int gpy_update_interface(struct phy_device *phydev) > /* Interface mode is fixed for USXGMII and integrated PHY */ > if (phydev->interface == PHY_INTERFACE_MODE_USXGMII || > phydev->interface == PHY_INTERFACE_MODE_INTERNAL) > - return -EINVAL; > + return 0; > > /* Automatically switch SERDES interface between SGMII and 2500-BaseX > * according to speed. Disable ANEG in 2500-BaseX mode.