From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753151AbbIWKMU (ORCPT ); Wed, 23 Sep 2015 06:12:20 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:49996 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751692AbbIWKMS (ORCPT ); Wed, 23 Sep 2015 06:12:18 -0400 X-AuditID: cbfee61a-f79a06d000005c6f-b9-56027b006c5f From: Chao Yu To: "'Jaegeuk Kim'" Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org References: <00d601d0f539$3d893e90$b89bbbb0$@samsung.com> <20150922225352.GA31427@jaegeuk-mac02.mot.com> In-reply-to: <20150922225352.GA31427@jaegeuk-mac02.mot.com> Subject: RE: [PATCH] f2fs: fix to correct freed section number during gc Date: Wed, 23 Sep 2015 18:11:36 +0800 Message-id: <012601d0f5e8$5315a690$f940f3b0$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: AQGHY1LVss8afjnxhpu5CeYirfQSKwEvkfKbntODwbA= Content-language: zh-cn X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrALMWRmVeSWpSXmKPExsVy+t9jQV2GaqYwg/Vt3BZP1s9itri0yN3i 8q45bA7MHptWdbJ57F7wmcnj8ya5AOYoLpuU1JzMstQifbsEroy/m2+zFHxnr+g79IK5gXED WxcjJ4eEgIlE4/8PLBC2mMSFe+uB4lwcQgKzGCV6TvaDJYQEXjFKzF2gBmKzCahILO/4zwRi iwioSfTumwJmMwt4SDR2fGftYuQAqs+SWLYxCSTMKWAtcenlG1YQWxioZHPPOzCbRUBVYuv6 rcwg5bwClhLdJ2JBwrwCghI/Jt9jgZioJbF+53Go6fISm9e8ZYY4U0Fix9nXjCCtIgJWEvvu CECUiEtsPHKLZQKj0Cwkk2YhmTQLyaRZSFoWMLKsYpRILUguKE5KzzXMSy3XK07MLS7NS9dL zs/dxAgO92dSOxgP7nI/xCjAwajEw2vxnTFMiDWxrLgy9xCjBAezkgjv0wCmMCHelMTKqtSi /Pii0pzU4kOM0hwsSuK8Nw4xhAkJpCeWpGanphakFsFkmTg4pRoYzYRm/uraFLn4ulr8kouy dkGiB5fPuV315fsV8+UVxy8dNpG60Vjk7DzTYwcn37KlcxsU3co6PD0zKmVOvHiYfOfcbHbR 9FvHurhkMya2/z/1675T+VzPd+97nT9uutnUKF9/fMJ8S6b6GSrXVlaxTX4958oUx6zkfy71 X+xmVH2eE/JScveEfUosxRmJhlrMRcWJAAcnVLNzAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jaegeuk, > -----Original Message----- > From: Jaegeuk Kim [mailto:jaegeuk@kernel.org] > Sent: Wednesday, September 23, 2015 6:54 AM > To: Chao Yu > Cc: linux-f2fs-devel@lists.sourceforge.net; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] f2fs: fix to correct freed section number during gc > > Hi Chao, > > On Tue, Sep 22, 2015 at 09:18:18PM +0800, Chao Yu wrote: > > We pass 'nfree' to has_not_enough_free_secs to check whether there is > > enough free section, but 'nfree' indicates the number of segment gced, > > should alter the value to section number. > > Yeah, but I think we need to increase nfree only when an entire section is gced > completely, since sometimes nfree can be increased across sections. Agree, I will fix that. Still have one question, for foreground gc, why would we give up retry writing out pages of last victim, but trying to select another victim for cleanup? Will new introduced method cause long latency for caller than before? Thanks,