From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55714242D9E for ; Fri, 19 Dec 2025 22:42:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766184130; cv=none; b=mFNf1DI6o55Q4XjKSM22Uo2rtwvbMtUBMD1Ux/+eCsn/sl0g7SeQhxGR1eSCMc+7S2dwtp4PP3iw8g+TXXOEj7Mz8ISFCLUSxyyBFRGB3U2BQ/GQlorw4UTYafNTQXmSnSqiiCKHlbZ84ipU5z5/dNRelT/ouPz6/hBk5f+uTeg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766184130; c=relaxed/simple; bh=dOBesZiZkvcbsrlIE1HpTeKXvjg0FO6Vfqc3uFf9vyw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sRj2/LL1eSGRYkg75mNnOGCRqMW3DdNuR9tgLTf5HX9lNWeCDX6PGJVBhpum+/ssL1+NxJA/xfhot1g+6TcbqSaVxbN6AXbGDLxBoCuuhRj6sGHnCgtLFCgrrf9EzbkPpNyuOMIa/Wi/zT0fpVSHWySYnv4K/CIkz03kSNIXdlA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=jpkHXg32; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="jpkHXg32" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1766184126; bh=dOBesZiZkvcbsrlIE1HpTeKXvjg0FO6Vfqc3uFf9vyw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=jpkHXg32VP1Om8nTwThFfO8jZpKksYrc/8u4nki4rh0tRzgmaLNFyoc4P/KgmwyEs Z83vsMSmf+VzwznJuB+/N3W0r1bqKev4P5MdzBU55+5NCMOgLUDStbhscExkPzjnSj fmp7Z80dCFe9I7xlwWRoOaklUvaiZVMc/x8x0yB1nt9cVROglVympfizNzjyZLzXZc mH946p3K2sd1g3R/GjQx5PZSOHlGlGLcjQYa5sz7ZN2a8zMR07SWOFmCINsB3OXU0A FJbABuZ22kbOGnvfTxQh8u4beZyCIGoLn/wfaKSNhYzm7tUdFWcBlQmHx766czhKGe yKscYz7payrKw== Received: from [192.168.1.90] (unknown [82.79.138.145]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id 9D1E017E0181; Fri, 19 Dec 2025 23:42:05 +0100 (CET) Message-ID: <012994e7-0e69-4885-8050-a404b7ae7608@collabora.com> Date: Sat, 20 Dec 2025 00:42:05 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/4] drm/rockchip: vop2: Support setting custom background color To: Chaoyi Chen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Sandy Huang , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Andy Yan , Louis Chauvet , Haneen Mohammed , Melissa Wen Cc: Robert Mader , kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org References: <20251118-rk3588-bgcolor-v3-0-a2cc909428ea@collabora.com> <20251118-rk3588-bgcolor-v3-4-a2cc909428ea@collabora.com> <0ed71b8d-5a2e-4213-bd2f-7ba317d1e4cb@rock-chips.com> <4a6443b8-d440-4921-8a43-7c20e4e265e7@collabora.com> <058027df-1b1b-4c46-b8e1-ec53fc809e82@collabora.com> <292ed476-2b5a-4b61-97e5-3b8d8a24c324@rock-chips.com> Content-Language: en-US From: Cristian Ciocaltea In-Reply-To: <292ed476-2b5a-4b61-97e5-3b8d8a24c324@rock-chips.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/30/25 5:01 AM, Chaoyi Chen wrote: > On 11/29/2025 5:50 PM, Cristian Ciocaltea wrote: >> Hi Chaoyi, >> >> On 11/29/25 5:49 AM, Chaoyi Chen wrote: >>> Hello Cristian, >>> >>> On 11/28/2025 5:44 PM, Cristian Ciocaltea wrote: >>>> The precision was something I initially looked into for CRC verification, in the >>>> context of the related IGT test. But since I've added the VKMS support, I think >>>> we should not worry about that anymore. >>>> >>>> Moreover, as already pointed out in [1], only RK3576 supports CRC generation at >>>> display controller level, and that is not particularly useful because it doesn't >>> >>> I believe you can get the CRTC CRC on the RK3576, even when only the >>> background is visible and all plane is disabled. Feel free to let me >>> know if you run into any issues :) >> >> Yes, CRTC CRC works on RK3576 for the planes, but not for the background, i.e. >> the CRC is not updated when setting a different background color. Unless >> there's a way to change this default behavior, which I'm not aware of. >> >> My current understanding is that the background color is applied at a later >> stage in the display pipeline, *after* blending the planes and computing CRC. >> > > Which CRTC are you using? If you're using VP0, you might run into this > problem. Please try VP1 instead. Yeah, that's VP0 as there's only one HDMI output port on my Radxa ROCK 4D board. I'll check if it's possible to switch to VP1.