From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753621AbeEWBX6 (ORCPT ); Tue, 22 May 2018 21:23:58 -0400 Received: from mail-ot0-f195.google.com ([74.125.82.195]:33197 "EHLO mail-ot0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753192AbeEWBX5 (ORCPT ); Tue, 22 May 2018 21:23:57 -0400 X-Google-Smtp-Source: AB8JxZpEkzENSpPqXCnp5qDyTttu5+dOFbrSA1ufP3Kec+mfZxtCFYbLvV9xCEVCdFi03aMRTCAFCA== Subject: Re: [PATCHv3 2/2] x86/vdso: Add build salt to the vDSO To: Andy Lutomirski Cc: Mark Wielaard , "H. J. Lu" , Masahiro Yamada , Linus Torvalds , X86 ML , LKML , Nick Clifton , Cary Coutant , linux-kbuild@vger.kernel.org References: <20180523001939.9431-1-labbott@redhat.com> <20180523001939.9431-3-labbott@redhat.com> From: Laura Abbott Message-ID: <012c44ae-d57b-1123-f74c-eb228537600c@redhat.com> Date: Tue, 22 May 2018 18:23:53 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/22/2018 05:33 PM, Andy Lutomirski wrote: > On Tue, May 22, 2018 at 5:19 PM Laura Abbott wrote: > > >> The vDSO is linked separately from the kernel and modules. Ensure it picks >> up the comment section, if available. > > Did you end up preferring this to just sticking the kernel version in a > .comment in the vDSO for some reason? > That's a good idea I hadn't considered. I'll do that for the next version. Thanks, Laura