From: "Andreas Färber" <afaerber@suse.de>
To: Rob Herring <robh@kernel.org>, TY Chang <tychang@realtek.com>
Cc: linux-realtek-soc@lists.infradead.org,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
linus.walleij@linaro.org
Subject: Re: [PATCH v3 5/9] dt-bindings: pinctrl: realtek: Add Realtek DHC SoC rtd1295
Date: Tue, 18 Aug 2020 12:12:21 +0200 [thread overview]
Message-ID: <012eee35-6835-7244-0013-9fc6980107e0@suse.de> (raw)
In-Reply-To: <20200817203358.GA1508879@bogus>
Am 17.08.20 um 22:33 schrieb Rob Herring:
> On Thu, 13 Aug 2020 15:49:04 +0800, TY Chang wrote:
>> Add device tree binding Documentation for rtd1295
>> pinctrl driver.
>>
>> Signed-off-by: TY Chang <tychang@realtek.com>
>> ---
>> .../pinctrl/realtek,rtd1295-pinctrl.yaml | 192 ++++++++++++++++++
>> 1 file changed, 192 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/pinctrl/realtek,rtd1295-pinctrl.yaml
>>
>
>
> Please add Acked-by/Reviewed-by tags when posting new versions. However,
> there's no need to repost patches *only* to add the tags. The upstream
> maintainer will do that for acks received on the version they apply.
>
> If a tag was not added on purpose, please state why and what changed.
The thing really missing here is a per-patch change log.
Things were added here that I'm sure you would not give your Reviewed-by
for, in particular new properties prefixed with unregistered rtk prefix
instead of the registered realtek prefix.
@TY, hiding such changes in a big previously reviewed patch without any
mention is problematic - please rather do smaller follow-up patches to
not invalidate previous reviews with new features.
Thanks,
Andreas
--
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)
next prev parent reply other threads:[~2020-08-18 10:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-13 7:48 [PATCH v3 0/9] pinctrl: update realtek DHC pinctrl driver TY Chang
2020-08-13 7:49 ` [PATCH v3 1/9] pinctrl: realtek: rtd1295: Add missed pins TY Chang
2020-08-13 7:49 ` [PATCH v3 2/9] pinctrl: realtek: rtd1295: Add pin configs TY Chang
2020-08-13 7:49 ` [PATCH v3 3/9] pinctrl: realtek: rtd1195: Add missed pins and " TY Chang
2020-08-13 7:49 ` [PATCH v3 4/9] dt-bindings: pinctrl: realtek: Add Realtek DHC SoC rtd1195 TY Chang
2020-08-17 20:33 ` Rob Herring
2020-08-13 7:49 ` [PATCH v3 5/9] dt-bindings: pinctrl: realtek: Add Realtek DHC SoC rtd1295 TY Chang
2020-08-17 20:33 ` Rob Herring
2020-08-18 10:12 ` Andreas Färber [this message]
2020-08-19 3:12 ` TY_Chang[張子逸]
2020-08-13 7:49 ` [PATCH v3 6/9] arm64: dts: realtek: rtd129x: fix SDIO pinctrl node TY Chang
2020-08-13 7:49 ` [PATCH v3 7/9] pinctrl: realtek: DHC: Fix pinctrl driver coding style according to checkpatch.pl TY Chang
2020-08-13 7:49 ` [PATCH v3 8/9] pinctrl: realtek: DHC: Move pinctrl drivers to realtek directory and rename TY Chang
2020-08-13 7:49 ` [PATCH v3 9/9] pinctrl: realtek: DHC: Add suspend/resume callback function TY Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=012eee35-6835-7244-0013-9fc6980107e0@suse.de \
--to=afaerber@suse.de \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-realtek-soc@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=tychang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®