From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 164A8C4338F for ; Wed, 11 Aug 2021 08:15:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EF5BB60F38 for ; Wed, 11 Aug 2021 08:15:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235945AbhHKIPv (ORCPT ); Wed, 11 Aug 2021 04:15:51 -0400 Received: from www381.your-server.de ([78.46.137.84]:54956 "EHLO www381.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235053AbhHKIPt (ORCPT ); Wed, 11 Aug 2021 04:15:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=metafoo.de; s=default2002; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID; bh=dUpACG8aiUQKUG+rkp01YuOY1SDfByf1trncBtx1z7c=; b=ds9Nrz6zHCpeudTBYLZWmxaPs6 XBTPus2B+JHGUjVVUrYMQGJb5tLCuIRZR7YqtCkAlJNzWNAYVQBDHqpswMrJEz+cq6lWpNXVCO5lH uGTohanqNiQRvqT5dKXLxFxPxJL4ZBtlUVidO4E4bepmSnZ6cCL/hCA/seUeYvvzG2y5OTu4/YHYJ dQVgi8TZ+k/W1KWL1gUP14kTQbR7K6ICcn/M6hV7f1IxALf6SpI8hK48ICQ9SwctLREwoACbBoIab alq3P6WVHT/Zkf737PKgKOHv13S3v9ACiQKdVviYh1Y8sq9vvPiVif04d4Lqu6rTFfQrhMVMZsCCe QE6e4lpw==; Received: from sslproxy06.your-server.de ([78.46.172.3]) by www381.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92.3) (envelope-from ) id 1mDjOH-00017W-Sp; Wed, 11 Aug 2021 10:15:09 +0200 Received: from [62.216.202.4] (helo=[192.168.178.20]) by sslproxy06.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mDjOH-0006Xj-HU; Wed, 11 Aug 2021 10:15:09 +0200 Subject: Re: [PATCH v2 2/2] iio: potentiometer: Add driver support for AD5110 To: Andy Shevchenko , Mugilraj Dhavachelvan Cc: "Bogdan, Dragos" , Darius , Rob Herring , Jonathan Cameron , Michael Hennerich , Guenter Roeck , Chris Packham , Slawomir Stepien , Krzysztof Kozlowski , Alexandre Belloni , Alexandru Ardelean , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org References: <20210809075745.160042-1-dmugil2000@gmail.com> <20210809075745.160042-3-dmugil2000@gmail.com> From: Lars-Peter Clausen Message-ID: <013bcb79-c496-44d8-2e93-57eb57834ee0@metafoo.de> Date: Wed, 11 Aug 2021 10:15:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Authenticated-Sender: lars@metafoo.de X-Virus-Scanned: Clear (ClamAV 0.103.2/26259/Tue Aug 10 10:19:56 2021) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/10/21 2:49 PM, Andy Shevchenko wrote: > >> + data->tol = data->cfg->kohms * (val & GENMASK(6, 0)) * 10 / 8; >> + if (!(val & BIT(7))) >> + data->tol *= -1; > Shouldn't you simple use corresponding sign_extend*()? The data is encoded a sign-magnitude. sign_extend() works for two's complement numbers.