From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753336AbdKXJ4X (ORCPT ); Fri, 24 Nov 2017 04:56:23 -0500 Received: from mout.web.de ([212.227.15.14]:53197 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752770AbdKXJ4V (ORCPT ); Fri, 24 Nov 2017 04:56:21 -0500 Subject: [PATCH 2/2] ASoC: wm8903: Improve two size determinations in wm8903_i2c_probe() From: SF Markus Elfring To: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, Jaroslav Kysela , Liam Girdwood , Linus Walleij , Mark Brown , Takashi Iwai Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: <013d9ad7-a8ff-6fad-ba82-40e68cf0a601@users.sourceforge.net> Date: Fri, 24 Nov 2017 10:55:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:+lFnd6WyfNB3FOFVpa8VZucxRRaYyqxyp4T7qUNf5CMy/B1aizA 7HOdlEILGFGTlA32PQ07hMrgWjkzgWbx5SGoj4tzqAJGGeq9SahsB8NguxLx4xusy3NxHMW OHLrzLft/2QzWhcJ6cm9n8JZmf6jbfwZ+ZadpwEOp6Hzb6Tq3qyYQlpUHMK5T3dBiZ3z20C KkcEp6aVQI1wFCv4C9EtA== X-UI-Out-Filterresults: notjunk:1;V01:K0:rQh/2VXgG/I=:s2zcGMVcxeZ1u/MHVGocEC WvwmhsNBBaY57hEyF4eJPqj3igkK7aDpTjeeBR3ka5j+3yACYeyuR/1brkyoGv7qtdcr+e9M+ htK9ArNxrI+iFVQei2Zpj9PdK0VL7kHUkouYa8tJnmybXxDBmaxJOQKur5MIwVcmnWTbRak9R WyvoMkkVjWluYzV0k6oEfpFvpFOzQDmTIWia/buYCW1QkHtTo7RrPmgyCLUFEX0A/4VD7fmFl SsUclz2gvB+vdcd69FTG5z4hdkjH8v9FiXwZTM2Ryx5yLJg1hM+DPa8SF4XR8QelBMYf9nIgn 6jFIerVNo0uaZ26/hJmAgeocpblQETc8Yo8EDEEJlmde5oyCKcgZiR1orcHWsuJB1zjAdgO2c J4hkbG7Mu2FiYJktvztY2HNG5s0bBXa7lb/a2X/rmZeSpA6UGRJsMhgRoav7RBKtXE/oA7w71 eKIZWit8Fsw4LN99QjA+slegS2MvYBmKXjL6OKXeLjiTADNyjqHpWyuFDE/BW21LF2yGed+9s Cms6OayWYb8tIG5oooytMpa6SLT6L2DNlMFATh9/zr9+OOcZPZ8zVITnkOfKjEc16xi9TLm0o CgVnRz9J6NF3IpweeSWlOrruf3m5jtkeYxbn1xCYC0p3puYktZCte/rQsJ/sI1eKqLweWyi4U edH+KIc/h+6O+gwZx8jHBHVWAHXNfQVmJbBKoJl8rd6K421HEpSn3YFjo3aQ+zVsCXIwpXw5Z qhYlE1hK5MrRmQNTERe2xDfDR1l2iCrP+L3lPGacwf6FkCR44RCIe2zs4Pyckwp/Uciw7n5Cu 3NzeeswzeR69x25FmHoD3wdQVx79M249dogpNXI8G1j4pjw85Q= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 24 Nov 2017 10:40:43 +0100 Replace the specification of two data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- sound/soc/codecs/wm8903.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/sound/soc/codecs/wm8903.c b/sound/soc/codecs/wm8903.c index 51eb7d61d446..cba90f21161f 100644 --- a/sound/soc/codecs/wm8903.c +++ b/sound/soc/codecs/wm8903.c @@ -1995,8 +1995,7 @@ static int wm8903_i2c_probe(struct i2c_client *i2c, unsigned int val, irq_pol; int ret, i; - wm8903 = devm_kzalloc(&i2c->dev, sizeof(struct wm8903_priv), - GFP_KERNEL); + wm8903 = devm_kzalloc(&i2c->dev, sizeof(*wm8903), GFP_KERNEL); if (wm8903 == NULL) return -ENOMEM; @@ -2017,9 +2016,8 @@ static int wm8903_i2c_probe(struct i2c_client *i2c, if (pdata) { wm8903->pdata = pdata; } else { - wm8903->pdata = devm_kzalloc(&i2c->dev, - sizeof(struct wm8903_platform_data), - GFP_KERNEL); + wm8903->pdata = devm_kzalloc(&i2c->dev, sizeof(*wm8903->pdata), + GFP_KERNEL); if (!wm8903->pdata) return -ENOMEM; -- 2.15.0