From: Krzysztof Kozlowski <krzk@kernel.org>
To: "André Draszik" <andre.draszik@linaro.org>,
"Sylwester Nawrocki" <s.nawrocki@samsung.com>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Rob Herring" <robh@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Tomasz Figa" <tomasz.figa@gmail.com>,
"Peter Griffin" <peter.griffin@linaro.org>
Cc: Tudor Ambarus <tudor.ambarus@linaro.org>,
Will McVicker <willmcvicker@google.com>,
kernel-team@android.com, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: pinctrl: samsung: google,gs101-pinctrl needs a clock
Date: Thu, 25 Apr 2024 20:18:50 +0200 [thread overview]
Message-ID: <013f2da9-1d91-4b62-b5b7-d603d0c09aef@kernel.org> (raw)
In-Reply-To: <56a32a2d-2f6f-4f7b-8359-6f3062c010e2@kernel.org>
On 25/04/2024 20:15, Krzysztof Kozlowski wrote:
>> + properties:
>> + compatible:
>> + contains:
>> + const: google,gs101-pinctrl
>> + then:
>> + required:
>> + - clocks
>> + - clock-names
>
> else:
> properties:
> clocks: false
> clock-names: false
>
> but anyway this is all a bit fragile, because pinctrl is not a driver
> and you rely on initcall ordering.
It is a driver, although initcall ordering is still there. Anyway, it's
the first soc requiring clock for pinctrl
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-04-25 18:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 16:03 [PATCH 0/2] clock support for Samsung Exynos pin controller (Google Tensor gs101) André Draszik
2024-04-25 16:03 ` [PATCH 1/2] dt-bindings: pinctrl: samsung: google,gs101-pinctrl needs a clock André Draszik
2024-04-25 18:15 ` Krzysztof Kozlowski
2024-04-25 18:18 ` Krzysztof Kozlowski [this message]
2024-04-26 10:54 ` André Draszik
2024-04-26 10:56 ` Krzysztof Kozlowski
2024-04-25 16:03 ` [PATCH 2/2] pinctrl: samsung: support a bus clock André Draszik
2024-04-25 18:29 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=013f2da9-1d91-4b62-b5b7-d603d0c09aef@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel-team@android.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=tomasz.figa@gmail.com \
--cc=tudor.ambarus@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®