From: Binbin Wu <binbin.wu@linux.intel.com>
To: Sean Christopherson <seanjc@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Kiryl Shutsemau <kas@kernel.org>,
Rick Edgecombe <rick.p.edgecombe@intel.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
kvm@vger.kernel.org, x86@kernel.org, linux-coco@lists.linux.dev,
linux-kernel@vger.kernel.org,
James Houghton <jthoughton@google.com>,
Xiaoyao Li <xiaoyao.li@intel.com>,
Yan Zhao <yan.y.zhao@intel.com>,
Ackerley Tng <ackerleytng@google.com>,
Vishal Annapurve <vannapurve@google.com>,
Sashiko Bot <sashiko-bot@kernel.org>
Subject: Re: [PATCH v2 1/3] KVM: x86: Add a helper to prepare vcpu->run for a SHUTDOWN exit to userspace
Date: Wed, 30 Sep 2026 11:04:06 +0800 [thread overview]
Message-ID: <01408d38-f9cc-458f-98d6-a591c342b336@linux.intel.com> (raw)
In-Reply-To: <20260930001127.3170009-2-seanjc@google.com>
On 9/30/2026 8:11 AM, Sean Christopherson wrote:
> Add kvm_prepare_shutdown_exit() to dedup the paths that exit to userspace
> with KVM_EXIT_SHUTDOWN, all of which happen to be x86 (presumably other
> architectures use KVM_EXIT_SYSTEM_EVENT?).
>
> Note, this adds a clearing of mmio_needed for SVM's shutdown_interception().
> Not clearing mmio_needed in that case is all but guaranteed to be benign;
> KVM should never enter the guest with outstanding emulated MMIO operations
> (the equivalent VMX and TDX paths likely copy+pasted the code from
> KVM_REQ_TRIPLE_FAULT, which does need to clear mmio_needed as KVM can
> synthesize a triple fault shutdown in the middle of instruction emulation).
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Sean Christopherson <seanjc@google.com>
Reviewed-by: Binbin Wu <binbin.wu@linux.intel.com>
next prev parent reply other threads:[~2026-09-30 3:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 0:11 [PATCH v2 0/3] KVM: TDX: Syntehsize SHUTDOWN on unhandled EPT Violation Sean Christopherson
2026-09-30 0:11 ` [PATCH v2 1/3] KVM: x86: Add a helper to prepare vcpu->run for a SHUTDOWN exit to userspace Sean Christopherson
2026-09-30 3:04 ` Binbin Wu [this message]
2026-09-30 0:11 ` [PATCH v2 2/3] KVM: TDX: Synthesize SHUTDOWN instead of returning -EIO on unhandled EPT violation Sean Christopherson
2026-09-30 4:58 ` Binbin Wu
2026-09-30 0:11 ` [PATCH v2 3/3] KVM: TDX: Ratelimit the "EPT Violation on pending acceptance page" warning Sean Christopherson
2026-09-30 5:01 ` Binbin Wu
2026-09-30 0:32 ` [PATCH v2 0/3] KVM: TDX: Syntehsize SHUTDOWN on unhandled EPT Violation Edgecombe, Rick P
2026-09-30 0:55 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01408d38-f9cc-458f-98d6-a591c342b336@linux.intel.com \
--to=binbin.wu@linux.intel.com \
--cc=ackerleytng@google.com \
--cc=dave.hansen@linux.intel.com \
--cc=jthoughton@google.com \
--cc=kas@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rick.p.edgecombe@intel.com \
--cc=sashiko-bot@kernel.org \
--cc=seanjc@google.com \
--cc=vannapurve@google.com \
--cc=x86@kernel.org \
--cc=xiaoyao.li@intel.com \
--cc=yan.y.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®