From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 927F3436352 for ; Tue, 28 Apr 2026 14:10:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777385447; cv=none; b=eiXyINYoCLGVSBXJRwBEeJvijI+h8BPg629zI4WYfCTgy+c+ZWn7AeX/Q+ZWYTFZZjrO6bz4IM0jFTYz4aWaPnE0PdQJBOtOofu5Dynpa3jjXdClQDYjDVkMmKHVK6iUxffsHUPlja/ZCoQTDdxaC+Y2fRG4ZEkyYIuzQI/UpEI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777385447; c=relaxed/simple; bh=8U5hrdolA+y+3mG3AaoqX+B0mjaYuFRJDFtJJ0yiStI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=X2LR1yfB0HLRTn13jZmTgfXIX0bqeCemmCysl64zYFOf98XpctxAovOHnKEda7REnl1s4dbrj4MgApl3xiRVoMO+4NADhGejoK9R/pOTR0Y+lJA9oarjroPfPk/EKWsTvnbxnwhtSeKCOvRv/tvJ8BoWx9ZDqTqtM3OIeafF9Ok= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=FI4BMrG1; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="FI4BMrG1" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1777385444; bh=8U5hrdolA+y+3mG3AaoqX+B0mjaYuFRJDFtJJ0yiStI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=FI4BMrG1hXG2CerAkIE98HWuFW4UGy71R5db0fNotmySofWyeW+iVcXPxvj6L6OBO OuClsBXSPBt6WHzbHsqRrn1Nkvn5ERDROxWu2iXCbJr2geCJiG8iYVbZPNhOg64BFy 28x/mBtxR1nCBPwiQGuogAJvCv1Dp4dkhh3x6FwAkkb7qrze5JAC8qMUllLMqgtBZA 9gRnnTqDg1JXTwrVCdNa71Jpi+JsyhkJ5RSkE8RtgdmG2OqoKZ0ALopGmbE1aCKZj4 fJVxqJu0V1Rm8sQzZxiE75pnLa9Dmiv4UNp787Fo4Rc0/uPvCGmQGXJKI1LZ/aHGHk RtAxW/IvSxjRg== Received: from [100.64.0.241] (unknown [100.64.0.241]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id 16D9917E128F; Tue, 28 Apr 2026 16:10:44 +0200 (CEST) Message-ID: <0143075a-098e-4275-b152-419700e4b7c0@collabora.com> Date: Tue, 28 Apr 2026 17:10:43 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 10/10] drm/rockchip: dw_hdmi_qp: Restrict HPD event to the affected connector To: Dmitry Baryshkov Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Sandy Huang , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Andy Yan , kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Diederik de Haas , Maud Spierings References: <20260426-dw-hdmi-qp-scramb-v5-0-d778e70c317b@collabora.com> <20260426-dw-hdmi-qp-scramb-v5-10-d778e70c317b@collabora.com> Content-Language: en-US From: Cristian Ciocaltea In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/28/26 4:53 AM, Dmitry Baryshkov wrote: > On Sun, Apr 26, 2026 at 03:20:22AM +0300, Cristian Ciocaltea wrote: >> Switch from drm_helper_hpd_irq_event(), which polls all connectors, to >> drm_connector_helper_hpd_irq_event(), which runs the detect cycle only >> on the affected connector. >> >> This avoids unnecessary work and redundant detect calls on unrelated >> connectors. > > This also doesn't feel correct. The dw_hdmi_qp is a bridge. As such it > should be using drm_bridge_hpd_notify() rather than any of the mentioned > functions. Would it be better to add the a corresponding wrapper to the > dw_hdmi_qp API and call one there? Let me try that. > Also consider implementing the > .hpd_enable() and .hpd_disable() callbacks for the bridge, which would > remove the necessity to call enable the IRQ in the bind function. Ack. Thanks, Cristian