From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16925C77B7F for ; Thu, 11 May 2023 18:12:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239155AbjEKSMA (ORCPT ); Thu, 11 May 2023 14:12:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239142AbjEKSL4 (ORCPT ); Thu, 11 May 2023 14:11:56 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B73E5FCA; Thu, 11 May 2023 11:11:32 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2B60D6507C; Thu, 11 May 2023 18:11:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 89484C433D2; Thu, 11 May 2023 18:11:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683828691; bh=gwG7e73Xzne2+itUdzAAaXUhIwWHZJlkWTQj+8xXLME=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=b3FEn2YcCVBwycKvYpAB9Wr1domTbJQQfuZUZx8+riLEeFfNI1Zt54G1uZcfYy149 SnVpYLiUf73dqb6untAtmL9nsUiLt9DZJUEsEfBdXC7GikC0KkDYwiFLwXA/cppVvl T8yUb9xFhAuLuEPbi2bknVgd9By3wz/r/stW2CHFO1FXFAQ6q3QFy7XqJneiz6TdO7 dgN/ERkE/mFivnBoY0diRVqvVISZkQHb5r3B9mRnPofXtpXUQAwEaKflR6H55awxs+ 38c/FBUQAfWu88XItFtmhc+dWcDrSg6z+iQ2Wa3kG2ctU/o2eHGoDlGgn3YTYzcuiX uamrgPq7nNODg== Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id 11763CE0FED; Thu, 11 May 2023 11:11:31 -0700 (PDT) Date: Thu, 11 May 2023 11:11:31 -0700 From: "Paul E. McKenney" To: Joel Fernandes Cc: rcu@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, rostedt@goodmis.org, Zqiang Subject: Re: [PATCH rcu 5/6] doc/rcutorture: Add description of rcutorture.stall_cpu_block Message-ID: <0146f6ad-9a2c-4a28-8992-e054afade42c@paulmck-laptop> Reply-To: paulmck@kernel.org References: <7ffd4a5d-61e9-4b4c-a312-a85bcde08c39@paulmck-laptop> <20230510171238.2189921-5-paulmck@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 10, 2023 at 10:47:36PM -0700, Joel Fernandes wrote: > On Wed, May 10, 2023 at 10:12 AM Paul E. McKenney wrote: > > > > From: Zqiang > > > > If you build a kernel with CONFIG_PREEMPTION=n and CONFIG_PREEMPT_COUNT=y, > > then run the rcutorture tests specifying stalls as follows: > > > > runqemu kvm slirp nographic qemuparams="-m 1024 -smp 4" \ > > bootparams="console=ttyS0 rcutorture.stall_cpu=30 \ > > rcutorture.stall_no_softlockup=1 rcutorture.stall_cpu_block=1" -d > > > > The tests will produce the following splat: > > > > [ 10.841071] rcu-torture: rcu_torture_stall begin CPU stall > > [ 10.841073] rcu_torture_stall start on CPU 3. > > [ 10.841077] BUG: scheduling while atomic: rcu_torture_sta/66/0x0000000 > > .... > > [ 10.841108] Call Trace: > > [ 10.841110] > > [ 10.841112] dump_stack_lvl+0x64/0xb0 > > [ 10.841118] dump_stack+0x10/0x20 > > [ 10.841121] __schedule_bug+0x8b/0xb0 > > [ 10.841126] __schedule+0x2172/0x2940 > > [ 10.841157] schedule+0x9b/0x150 > > [ 10.841160] schedule_timeout+0x2e8/0x4f0 > > [ 10.841192] schedule_timeout_uninterruptible+0x47/0x50 > > [ 10.841195] rcu_torture_stall+0x2e8/0x300 > > [ 10.841199] kthread+0x175/0x1a0 > > [ 10.841206] ret_from_fork+0x2c/0x50 > > Another way to get rid of the warning would be to replace the > cur_ops->readlock() with rcu_read_lock(). Though perhaps that will not > test whether the particular RCU flavor under testing is capable of > causing a stall :-). Exactly! > > rcutorture.stall_cpu_block= [KNL] > > Sleep while stalling if set. This will result > > - in warnings from preemptible RCU in addition > > - to any other stall-related activity. > > + in warnings from preemptible RCU in addition to > > + any other stall-related activity. Note that > > + in kernels built with CONFIG_PREEMPTION=n and > > + CONFIG_PREEMPT_COUNT=y, this parameter will > > + cause the CPU to pass through a quiescent state. > > + Any such quiescent states will suppress RCU CPU > > + stall warnings, but the time-based sleep will > > + also result in scheduling-while-atomic splats. > > Could change last part to "but may also result in > scheduling-while-atomic splats as preemption might be disabled for > certain RCU flavors in order to cause the stall". Is that needed given the earlier "in kernels built with CONFIG_PREEMPTION=n and CONFIG_PREEMPT_COUNT=y"? > > + Which might or might not be what you want. > > + > > Suggest drop this line ;-). OK, I will bite. ;-) What is your concern with this line? Thanx, Paul > - Joel > > > rcutorture.stall_cpu_holdoff= [KNL] > > Time to wait (s) after boot before inducing stall. > > -- > > 2.40.1 > >