From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F4047388E40 for ; Mon, 23 Mar 2026 13:12:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774271561; cv=none; b=SffjjFDG+rKF9j/GaHu6/+Lzzh68GDFn56yeEaqiCI3jTKMRS/Z5bc8+fB8+sU2f5quJpZ7iXLkuy7gEt+SFhJy1kCjtf+mxzz84lNJK17kaPgfVVOM/RXkBMr/m3iEbxZG82esCLEVlmkgtXB7JQ2k/O+JhrW8l/T6Z9Iu50yA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774271561; c=relaxed/simple; bh=onDmPmMxM3dk6Kw/wxvgO+Mev/+35UTFA2gPZBOu/lU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UUPc5xdCGu/+d7Vz6JGgRskGp9auTN3xzd9dsjzXZIZsmoaO/KbcQ8gc0r14y5t5/tus2zmPWnN5hqOoMuus+iJeO3/Gm44esCJdLbuX2tmUHubcVxUqCJnwnvw7xhkUJPmMLm6pGCJ/QqHbIUsEM+fvEqtY0As89XzKfVAH1k4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Eoj+xT9V; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=J2tAjTun; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Eoj+xT9V"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="J2tAjTun" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62N7Sxpl3532237 for ; Mon, 23 Mar 2026 13:12:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= MK3sQ2NCBQ5xyxGUot5AucAAnbtbEA64+KHUw1d7v+k=; b=Eoj+xT9V78iwKGQv POkBsUjewFY+/PhP9nrL11uRZluQY977E9CTuZ+FPjhYJ8znwiRdzIQP4WFMk0Wf oq5fCyEtnPdoQyb5TncJIxMGLEhHHQRbLPo+65VO1BXU/TCw45nApJwF6xBjxTq8 U3aC0TMX/P3OqcRDA3fs6YC0lZ3L0UumAZOr4Ei0E4aSSrTJBUzaKqKdMx/6x2Ip F6xogf16kQ5SVsl8gnKsiGTN3Zxrhh/kMxr71k+mt//q2dhhFzqAZYEDboOf+h3j PSHWfVMdE1Rb/Fq4cTOd5Ey0tXaWcSMIAa26yLvInW5ExBAt0zjaP8q9VEehtR48 TeMrjw== Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d2ca8keb6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 23 Mar 2026 13:12:39 +0000 (GMT) Received: by mail-vk1-f197.google.com with SMTP id 71dfb90a1353d-56cdc5244ddso335936e0c.2 for ; Mon, 23 Mar 2026 06:12:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774271558; x=1774876358; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=MK3sQ2NCBQ5xyxGUot5AucAAnbtbEA64+KHUw1d7v+k=; b=J2tAjTun0F0+HDtKc9sBsIEoGI7fmLGPHRqK08WJ3u7F+10UN/n8wUs1DdtloQYYO3 1uEfOU8rH3wuf0KLnYpeimmFh3oYBIFJL+vnqEaV8nx0SXNbCRsUIo9/fDVstdf2M5zh 24rH1/IoNegbZn7RJ22KF/qPQC9B+LMUdwbPhHPO6H4Ss0de66UsEu9wj4s1XYonHH6M vjunCacJmrc+j/If6ln59XEontpvDqtamUYDNAjjYHzfx9+XSBVrToLW8bK28lXlrgsL l/lSj4haMmhso6sMM5tETYRbsO3Rd4W4j+QD31TkZEmfQjYOtSk8/TeSRhi/Z0+7WSr5 7K9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774271558; x=1774876358; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MK3sQ2NCBQ5xyxGUot5AucAAnbtbEA64+KHUw1d7v+k=; b=GyLpX0ywIDdPGARkFVDj6d19o98Bf7fg8ty75tcPduj4QLx5ujUpR+03GP0PvgXx62 9EG8Yqirjk2CSv7O+vw1RF728Z11QX9xU+0oqlgFJrjvLfhA2Zb4JDEph0++kAvpXJxM u+xzEsCYQIqg3U8I/W63A5hsU6hfUvDSaKtWJY1XShlo16QtIvECkLAvU51QYDFrmMO9 eKCjnuCdDZv+ENtpDb6oN+uYukz53UXLNvEuK5aEpolu0KAMOwjtZkHLZk643TU9kAz2 ZMviE7bPV1y/xyezOu93182HTBDTXeKRY1ROg7avPIRL4QNHW4AYrDGwhV+KjRkxXCxR trzQ== X-Forwarded-Encrypted: i=1; AJvYcCXI5wLOg7WXXpjqkZ5mUCWZq7c1DIVRCDxevmOlFXubFZ9uHdJHxZ2ApBCEN16QW27vrCdNEsqj9WVgfVA=@vger.kernel.org X-Gm-Message-State: AOJu0Yw5RxlW6RrbCYTYLudZnt9gvI/qDtd1TwGNIgxwLLE2NNTG2jBM ZW5k7+M1DkjxlNhY+z6NFPezsXP6nBY5/tF64mm5TF/hmRNPB6qUv2aEWBeHsHPyX7Qs2Yxc7Sr 4+E7k6CSpSaV/4HTqo2fAOVfOnUwF8xaMVVEz0d1VxHLl8Wr4Qz6EACta7RFqJmbAUC0= X-Gm-Gg: ATEYQzw/Zcgt1umgvft9UIyhAVyNKWExPPK7jlXyMaIbB8Ecvev3W/9VXpRmfoQQ+qY yfkXPncfcMpyoqX9tPPYx1BW0C/ev9IzKkyZKklMHfGfkuO0s3W+0qZBa8LOVW/4p19w9Mc6Nim 8FbfS7DuhrvNrdDIKztWpjwehRfE8qEu4URzxei4h/FJTgrxAvIZdZXSexb2iN9HP+IRP14O/uI zBktAoXGkT6duK+24T1hbuoWHxFl0q9Lkd0asor2g1gJnJX8wThfoavQ2cTQCLBxyKvXqJwjdxE DhzeTsZkCRqlMg+mukJlN/QEdnKO4mvms3c5Tp1LSeh3Ha0/+jYW+ziPX5JoNXSoxk3Yrc9nX6q HMxnh+Zr4hkhK6Go0FMyXUAeb7HjcCnKSIsro+doXBMV74g+uu77ceJvmvqV51VieXUp2gumFtQ HuUCo= X-Received: by 2002:a05:6122:362a:b0:56b:6a54:1a24 with SMTP id 71dfb90a1353d-56cde40a346mr2329112e0c.2.1774271558283; Mon, 23 Mar 2026 06:12:38 -0700 (PDT) X-Received: by 2002:a05:6122:362a:b0:56b:6a54:1a24 with SMTP id 71dfb90a1353d-56cde40a346mr2329084e0c.2.1774271557791; Mon, 23 Mar 2026 06:12:37 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38bf99821c4sm28863331fa.27.2026.03.23.06.12.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Mar 2026 06:12:36 -0700 (PDT) Message-ID: <014e354f-aa4f-4e42-a249-6aca2fbeeeb4@oss.qualcomm.com> Date: Mon, 23 Mar 2026 14:12:33 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] arm64: dts: qcom: sm8750: Enable TSENS and thermal zones To: Gaurav Kohli , Amit Kucheria , Thara Gopinath , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio Cc: linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, aastha.pandey@oss.qualcomm.com, dipa.mantre@oss.qualcomm.com, Manaf Meethalavalappu Pallikunhi References: <20260313-sm8750_tsens-v1-0-250fcc3794a2@oss.qualcomm.com> <20260313-sm8750_tsens-v1-2-250fcc3794a2@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIzMDEwMSBTYWx0ZWRfXwtzK6/v4tJZU /S2rCLvmGdrVs7tVE4yKKq1cIiI9gH/KvTHPXSKW3hZLzGzpUCF07bHp4CvG/ie5Onls8hnDsdI f78kAk5KBL54ohQDPD6CcVJoAQ0JhusAHF1KrsnOcXOOw4gcanrCr55XqyE56W/sDG+xJtidIEz fveVUxzGSSst9ENH59La8myWEKwd/qmnDYSYR0Vi+SlfLJNjl6OZI+2+SpUJ54mXZszRypWX4bF IYGZEo8kSwbLL2Df1Ycubg92+sQH4uCRnCWhqGvG4EvB+d51BFyOhk6falhW6PDO7b4HGcnB0WE qHQCvOW7V35yTC8GY1DW4Br6/VyHZf+d0cSfRylaCR9CMQJKkJFlDGl6dR+EaC190/1GTagGB/r 4RrF6aBEVn2h4MaPaTSyXY4AUtK4pTtz4ZqM/xaEYKzPjP0vLZaEULSuYCB97JUUM52l0Mkjrg/ f7ScXU2jdTTFQK0P8aA== X-Authority-Analysis: v=2.4 cv=cf3fb3DM c=1 sm=1 tr=0 ts=69c13c47 cx=c_pps a=JIY1xp/sjQ9K5JH4t62bdg==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=zyAxkWfsCcm_7D0aKU0A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=tNoRWFLymzeba-QzToBc:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-ORIG-GUID: Kpq6V41XRxiKD_EQF9dEF2jwtgoXq1C5 X-Proofpoint-GUID: Kpq6V41XRxiKD_EQF9dEF2jwtgoXq1C5 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-23_04,2026-03-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 bulkscore=0 spamscore=0 impostorscore=0 malwarescore=0 phishscore=0 lowpriorityscore=0 clxscore=1015 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603230101 On 3/23/26 10:02 AM, Gaurav Kohli wrote: > > > On 3/18/2026 3:14 PM, Konrad Dybcio wrote: >> On 3/13/26 11:34 AM, Gaurav Kohli wrote: >>> From: Manaf Meethalavalappu Pallikunhi >>> >>> The sm8750 includes four TSENS instances, with a total of 47 thermal >>> sensors distributed across various locations on the SoC. >>> >>> The TSENS max/reset threshold is configured to 130°C in the hardware. >>> Enable all TSENS instances, and define the thermal zones with a hot trip >>> at 120°C and critical trip at 125°C. >>> >>> Signed-off-by: Manaf Meethalavalappu Pallikunhi >>> Signed-off-by: Gaurav Kohli >>> --- >> >> [...] >> >>> +        cpu-0-0-0-thermal { >>> +            thermal-sensors = <&tsens0 1>; >>> + >>> +            trips { >>> +                trip-point0 { >>> +                    temperature = <120000>; >>> +                    hysteresis = <5000>; >>> +                    type = "hot"; >>> +                }; >> >> Are we going to use these trip points for the CPUs? If not, let's only >> keep the critical ones (again, for CPUs specifically since they get >> externally throttled) > > thanks Konrad, for review. > We are not using this trip points for CPUs, For Kaanapali, Dmitry suggested to add more warning for CPUs also, if in case some user want to use it. So we have added for this soc also. Alright, please resubmit with Krzysztof's comments addressed and retain my r-b then Konrad