From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD502C001DC for ; Sat, 8 Jul 2023 01:57:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231280AbjGHB5i (ORCPT ); Fri, 7 Jul 2023 21:57:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40716 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229890AbjGHB5h (ORCPT ); Fri, 7 Jul 2023 21:57:37 -0400 Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0544E5 for ; Fri, 7 Jul 2023 18:57:35 -0700 (PDT) Received: by mail-lj1-x22b.google.com with SMTP id 38308e7fff4ca-2b6ff1a637bso40989781fa.3 for ; Fri, 07 Jul 2023 18:57:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688781454; x=1691373454; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Wwkh8pKXmB000uFIXf7QzEd4TnjTv7TK1I8MwngSb1U=; b=cB0DDfVlNx81Qa+CdHuaDXkowhn0UIBmUijEi6/MK4yPEa5LPrIl5HUkqW9yOfi+Mj doGsz/KGFFXTl0+Ir/tAb8LAqdtRRZElhL4SOU/DiwFTJnd+1rwJrBJfQi3r4h8IkZFu b4yD7Uy69SEFgGgvHrzAt542Py0zA29Z2csDRAexDnt/4HncnOS1Q6ChYc0kxyoDddgS sVES9b9y1CFvAKw9wfIKtg3XD+welY86e7QwXV04tby9+P4vdcgWxuCrkl7DWxfU7HtS lazyUTHet/c79kSl5R7HDO2wt/FlfM68fEOeovmZ4M5R3tWdLXXmY3RNOF6j3GmZnghL 3/Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688781454; x=1691373454; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Wwkh8pKXmB000uFIXf7QzEd4TnjTv7TK1I8MwngSb1U=; b=bBP3qr7Rz43cyBfQ7UzRnP2tKAgZjICpaOfHkrazIRO+Y1p+loeZNPlUSOW2PY/ZVs WrxB7M0Wwf1NT+96osRoD63Y0LBE9gqsCHR7JkDn9e9RtGbxYMmXBsMIVOSnNWhFvQTu j1zZqR/vCejFnflvdKI+wvqXgnDwcVGxpmrX9fKTC9xBbjvXVKDJYzU4TUUMdp0cZ55c qChIGM++w0aP3OGCFNPbv2QDWZi9ziHqEyx0/bjiG8fwRaJ3LkCNQSNfgKqrI/hn37Ti T2gFa5Gj+BlUpwPt28Q+DW0j2FR8Moot9a0JLcDtYdy7k0ThpjSd09w/fzYFqKXdPwBK RoLg== X-Gm-Message-State: ABy/qLbmFLXEby4p1z9vWG4x09mDkMPnIQPG5xyTcwG7A1hFITzOdJvA B6j834JHUOATv82GNPonv2XPng== X-Google-Smtp-Source: APBJJlFDVaBc1zEui+gCBg4MQrnljMQkMGLMJ5lft3Q2Ug4r1ftxh54PBw/phWz3nZmMH8jMFkZIpQ== X-Received: by 2002:a2e:8295:0:b0:2b6:9ab8:9031 with SMTP id y21-20020a2e8295000000b002b69ab89031mr2673029ljg.16.1688781454254; Fri, 07 Jul 2023 18:57:34 -0700 (PDT) Received: from ?IPV6:2001:14ba:a0db:1f00::8a5? (dzdqv0yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a0db:1f00::8a5]) by smtp.gmail.com with ESMTPSA id w4-20020a2e9bc4000000b002b475f087desm1022235ljj.56.2023.07.07.18.57.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Jul 2023 18:57:33 -0700 (PDT) Message-ID: <014ed874-6481-ba22-c3d7-4c2b082e515d@linaro.org> Date: Sat, 8 Jul 2023 04:57:33 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v5 6/6] drm/msm/dpu: Update dev core dump to dump registers of sub-blocks Content-Language: en-GB To: Ryan McCann , Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , David Airlie , Daniel Vetter Cc: Rob Clark , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, quic_jesszhan@quicinc.com References: <20230622-devcoredump_patch-v5-0-67e8b66c4723@quicinc.com> <20230622-devcoredump_patch-v5-6-67e8b66c4723@quicinc.com> From: Dmitry Baryshkov In-Reply-To: <20230622-devcoredump_patch-v5-6-67e8b66c4723@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/07/2023 04:24, Ryan McCann wrote: > Currently, the device core dump mechanism does not dump registers of > sub-blocks within the DSPP, SSPP, DSC, and PINGPONG blocks. Edit > dpu_kms_mdp_snapshot function to account for sub-blocks. > > Signed-off-by: Ryan McCann > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 66 +++++++++++++++++++++++++++------ > 1 file changed, 54 insertions(+), 12 deletions(-) Reviewed-by: Dmitry Baryshkov > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > index 7a2787279ba0..f7199a5c45ab 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > @@ -890,6 +890,7 @@ static void dpu_kms_mdp_snapshot(struct msm_disp_state *disp_state, struct msm_k > int i; > struct dpu_kms *dpu_kms; > const struct dpu_mdss_cfg *cat; > + void __iomem *base; > > dpu_kms = to_dpu_kms(kms); > > @@ -903,9 +904,16 @@ static void dpu_kms_mdp_snapshot(struct msm_disp_state *disp_state, struct msm_k > dpu_kms->mmio + cat->ctl[i].base, cat->ctl[i].name); > > /* dump DSPP sub-blocks HW regs info */ > - for (i = 0; i < cat->dspp_count; i++) > - msm_disp_snapshot_add_block(disp_state, cat->dspp[i].len, > - dpu_kms->mmio + cat->dspp[i].base, cat->dspp[i].name); > + for (i = 0; i < cat->dspp_count; i++) { > + base = dpu_kms->mmio + cat->dspp[i].base; > + msm_disp_snapshot_add_block(disp_state, cat->dspp[i].len, base, cat->dspp[i].name); > + > + if (cat->dspp[i].sblk && cat->dspp[i].sblk->pcc.len > 0) > + msm_disp_snapshot_add_block(disp_state, cat->dspp[i].sblk->pcc.len, > + base + cat->dspp[i].sblk->pcc.base, "%s_%s", > + cat->dspp[i].name, > + cat->dspp[i].sblk->pcc.name); Nit (no need to resend to correct this): the "%s_%s" logically fits the next line, as it it related to the names rather than base address. > + } > > /* dump INTF sub-blocks HW regs info */ > for (i = 0; i < cat->intf_count; i++) -- With best wishes Dmitry