From: Ravi Bangoria <ravi.bangoria@amd.com>
To: acme@kernel.org
Cc: peterz@infradead.org, irogers@google.com, jolsa@kernel.org,
namhyung@kernel.org, adrian.hunter@intel.com,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
sandipan.das@amd.com, ananth.narayan@amd.com,
santosh.shukla@amd.com, Ravi Bangoria <ravi.bangoria@amd.com>
Subject: Re: [PATCH v2] perf evsel amd: Fix IBS error message
Date: Mon, 26 Jun 2023 16:12:50 +0530 [thread overview]
Message-ID: <01605914-60fc-9540-389b-7dc377990f1e@amd.com> (raw)
In-Reply-To: <20230626103958.834-1-ravi.bangoria@amd.com>
On 26-Jun-23 4:09 PM, Ravi Bangoria wrote:
> AMD IBS can do per-process profiling[1] and is no longer restricted to
> per-cpu or systemwide only. Remove stale error message. Also, checking
> just exclude_kernel is not sufficient since IBS does not support any
> privilege filters. So include all exclude_* checks. And finally, move
> these checks under tools/perf/arch/x86/ from generic code.
>
> Before:
> $ sudo ./perf record -e ibs_op//k -C 0
> Error:
> AMD IBS may only be available in system-wide/per-cpu mode. Try
> using -a, or -C and workload affinity
>
> After:
> $ sudo ./perf record -e ibs_op//k -C 0
> Error:
> AMD IBS doesn't support privilege filtering. Try again with
> exclude_{kernel|user|hv|idle|host|guest}=0.
[1] https://git.kernel.org/torvalds/c/30093056f7b2
next prev parent reply other threads:[~2023-06-26 10:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-26 10:39 Ravi Bangoria
2023-06-26 10:42 ` Ravi Bangoria [this message]
2023-06-26 23:04 ` Namhyung Kim
2023-06-28 4:49 ` Ravi Bangoria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01605914-60fc-9540-389b-7dc377990f1e@amd.com \
--to=ravi.bangoria@amd.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ananth.narayan@amd.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=sandipan.das@amd.com \
--cc=santosh.shukla@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®