From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F9C3280331 for ; Tue, 30 Jun 2026 13:32:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782826335; cv=none; b=bp+e1OH0fQJ/WL9VhpV3ayUwV68hZ8LZ+7lt+N5owpUPH9WnMhtIzWDd5ARkBTLAuSnCsLxZWd/tn4x7GubtziwH6SWEZbF4d5uDURMhAJyycscjcxKDaDickUHH5BAMPSdcHbbSINHld7qyTYnwirC2pJkb39Skevnyg3bYfT0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782826335; c=relaxed/simple; bh=xpPMmV2m6fv5jfNde38a5Ol4Pz7X2NWCQ/YN94erzc0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HQDbRTZl8oJ0NwBBd87gnxGkpjIraH3DdhN9HRqFvHYLsDygcGv32Bna++H4cCjz+Y7vqZYUBiT2dKQdbWES5imOgKXvM84e11JI80E50udu+FDkV32oElgB+F+O41NvisJaqzWjh5VwUTtC8sjKfWFTZtXlYSSS4YR65NXP81Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=HmQxxYiS; arc=none smtp.client-ip=209.85.167.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HmQxxYiS" Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-5aeb906d6c6so203707e87.2 for ; Tue, 30 Jun 2026 06:32:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1782826332; x=1783431132; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=3k0gXgFqIFH85+EiNZcDCFD94DA0SXlTQoMWB+Asgdc=; b=HmQxxYiSA9I3I84UF5tJvaZ9OzFJm6BEfoirCpUNuEjqlaLZlM1EAhsysznRY/m4mf PzqVTHZN+fr1oRqSWmDSEh5pQdW4qDQ82nLCyRnaix7onaiQ4J4OWXs+KxEtp5X/9xyj 556m5Ptmthq5QQDsTPXQjqdvSD5n0EMF7UUsXxA78kqiKR+s926E+adgmi65GBIrjkrH yGheD0Hrkp0Fi7RznYdSQi1l+GK/WYvjcjxMHm53jM5GtuFmtnnGWB5saWSxbjni+JCz OXax9syPSHhl+TpNV6ZsAPNwhTUY3rIl4OpbHkPLoGNrbvTH/8LZcHDs4eZWFvyBnIlJ FCng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782826332; x=1783431132; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=3k0gXgFqIFH85+EiNZcDCFD94DA0SXlTQoMWB+Asgdc=; b=SphiAi4r3z8KSe0PidaNHh5c2+9GcPkpR98ZDvMii7PF6Vg/6ugdXG+sPRFhhDX+y3 pPbp7krMnTeqPFovbcOP6u6jBuhzzvopgVUxpBMFsCHxx//H5LF9AsdhzJ/ilHO7Wjuc qY1hafOurXMOhPCB0fTtbbZbTvkoXnIAGrd05Y7xC4zKlCxrXFLvIXInqQAaOknX3DaX 2cIfHIrezrla4GX3gK4lhiczma/GkEeyF/XtnLX98PHmZuFDmfXjG1RnYOjU4qqLQU0Z oantn4DNX9aHi5o5isQl1k0qFmhhnH+MJWLLs6gpmTvIvdQnITty3mYp9MOnjFYWVUH1 Pkmg== X-Forwarded-Encrypted: i=1; AHgh+RqW0UIpRDhgfxHGrEwSkVo6owP/mxcQrukVdQymY+Fl2q9IJO3QunvoCzLyGAFuDPeVpJkVlYoS47iNAWY=@vger.kernel.org X-Gm-Message-State: AOJu0Ywslb8DSWCWl2FLx7kqDYnRhpKn5IOCK1FGuxoYiSLFYxFlFiNl K+vsRZKMWC33nY33Wt1gV0N5uAsfripgIyHdrLDirW1F7d6BqHWrf0fzKmnqx9lzemo= X-Gm-Gg: AfdE7ckKpajv3DP3RZ+aIt8b9H64vVw09NC9tcClU37zXcwPzhO18I/YQkUy93/nkWb SRXaBQnZKK8H+UOnjnQWeogeTAxuczBeTm/ZPbzApa6ADXhoPxuAXfOtdwtCOv/hq63bEDnBuut ZYupujIJwz9AkcAH8v5vBKGtbiIWTJ4gPbpASdzVoAkZxJySklCrgK/9rHAzZYC9fr2mfP/Nc37 iWVvujHF726ivTeGn5lSagDgTnn/KwqiaG8sCfE6LnB+Q5MUbyYl1s+Khrm476nUakFOVvdA3en WHr3X99nB1BOlWRqZ7xIHoSi83VPn8KfkeyKKPsO48cskahOzZJGwjwcfEAmgEWujGY+N942qc2 S0bThp8qKV7b9jDdgDYpVFt14aCheM3ddCBcUUJbJgbDGZvDKFu4OGAXLiv+2kUXVIlrDWsSjHK xqPcsoR6GUvXB+SZTAvL558dul/aldnjBFDHYBZYBbvR+UDmafBHrPn2XnTXXNhqyCsUsDBbfna b6InA== X-Received: by 2002:a05:6512:8396:b0:5ae:b9fd:a0b4 with SMTP id 2adb3069b0e04-5aebdbd8724mr438715e87.7.1782826331545; Tue, 30 Jun 2026 06:32:11 -0700 (PDT) Received: from [192.168.1.100] (91-159-24-186.elisa-laajakaista.fi. [91.159.24.186]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5aebe33ce5asm564051e87.21.2026.06.30.06.32.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jun 2026 06:32:10 -0700 (PDT) Message-ID: <0161b69d-62fb-46b8-a43a-df0c8af4956a@linaro.org> Date: Tue, 30 Jun 2026 16:32:08 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/4] dt-bindings: media: qcom: Add JPEG encoder binding To: Bryan O'Donoghue , Atanas Filipov , linux-media@vger.kernel.org Cc: mchehab@kernel.org, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, andersson@kernel.org, quic_vgarodia@quicinc.com, quic_jesszhan@quicinc.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260629121750.3469292-1-atanas.filipov@oss.qualcomm.com> <20260629121750.3469292-3-atanas.filipov@oss.qualcomm.com> <_zZ7OLAmvphzTdIURTW71m_LKDwA-DEQ-a40gIiLYSqgDrdOOEf1bElz53zTbmSaDoqc8PDFyQXa7bycFaSTXw==@protonmail.internalid> <569539db-b079-439a-bd05-cb97c30141c1@linaro.org> From: Vladimir Zapolskiy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/30/26 16:19, Bryan O'Donoghue wrote: > On 29/06/2026 14:38, Vladimir Zapolskiy wrote: >>> + interconnects = >>> + <&gem_noc MASTER_AMPSS_M0 0 &config_noc SLAVE_CAMERA_CFG 0>, >>> + <&mmss_noc MASTER_CAMNOC_HF 0 &mc_virt SLAVE_EBI_CH0 0>, >>> + <&mmss_noc MASTER_CAMNOC_SF 0 &mc_virt SLAVE_EBI_CH0 0>, >>> + <&mmss_noc MASTER_CAMNOC_ICP 0 &mc_virt SLAVE_EBI_CH0 0>; >>> + interconnect-names = "cpu-cfg", >>> + "hf-mnoc", >>> + "sf-mnoc", >>> + "icp-mnoc"; >> Since the proper option for describing this hardware is to have it as >> a child device tree node of CAMSS device tree node, which should serve >> or be percepted as a bus, it makes no sense to repeat and moreover rename >> bus/parent's resources, here is the list: >> >> * "hf_axi", "sf_axi", "core_ahb", "cpas_ahb" and "cnoc_axi" clocks, >> * Titan GDSC power domain and all four interconnects. >> >> Only "jpeg" clock and iommus are left specific to the hardware description >> of this IP under CAMSS, right? Thus, it should be reflected like this in >> the dt description as well, and the complexity of shared resource management >> has to be done in the driver, which might be tedious unfortunately, but >> certainly doable. > > JPEG should be able to vote for its individual NoC / CamNoC dependencies > / requirements. There is no individual interconnects, JPEG interconnects are equal to bus/parent CAMSS ones. > > Both GDSCs and interconnects should be described in the sub-node. Why to do it in each child, if GDSCs and interconnects are CAMSS bus/domain specific? There is no acceptable explanation so far. > There's no functional linkage between CAMSS/IFE and JPEG - they are > peers within the CAMSS power-island. Over time we will migrate to I do not refer to any "functional linkage". > individual nodes for IFE CSID and these too will appear inside of the > CAMSS "bus" -> JPEG etc should describe their nocs and power-domains > individually. > > camss@X{ > camnoc@{} > csid@{ > interconnects = , ; > }; > jpeg@ { > interconnects = , ; > }; > ife@ { > interconnects = , ; > }; > }; It makes sense only if the lists of interconnects are different, this is not the case. -- Best wishes, Vladimir