From: "Guan Xuetao" <gxt@mprc.pku.edu.cn>
To: "'Stephen Boyd'" <sboyd@codeaurora.org>
Cc: "'Russell King - ARM Linux'" <linux@arm.linux.org.uk>,
<linux-arm-kernel@lists.infradead.org>,
"'Arnd Bergmann'" <arnd@arndb.de>, <linux-kernel@vger.kernel.org>,
"'Sam Ravnborg'" <sam@ravnborg.org>
Subject: RE: [PATCH] ARM: Use asm-generic/sizes.h
Date: Wed, 23 Mar 2011 16:30:31 +0800 [thread overview]
Message-ID: <016301cbe934$957a69f0$c06f3dd0$@mprc.pku.edu.cn> (raw)
In-Reply-To: <4D896616.7070307@codeaurora.org>
> -----Original Message-----
> From: Stephen Boyd [mailto:sboyd@codeaurora.org]
> Sent: Wednesday, March 23, 2011 11:17 AM
> To: Guan Xuetao
> Cc: 'Russell King - ARM Linux'; linux-arm-kernel@lists.infradead.org; 'Arnd Bergmann'; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] ARM: Use asm-generic/sizes.h
>
> On 03/22/2011 06:29 PM, Guan Xuetao wrote:
> >> -----Original Message-----
> >> From: Stephen Boyd [mailto:sboyd@codeaurora.org]
> >> Sent: Wednesday, March 23, 2011 2:40 AM
> >> To: Guan Xuetao
> >> Cc: 'Arnd Bergmann'; linux-arm-kernel@lists.infradead.org; 'Russell King - ARM Linux'; linux-kernel@vger.kernel.org
> >> Subject: Re: [PATCH] ARM: Use asm-generic/sizes.h
> >> Ah, I didn't notice this part. SZ_48M is actually used by ARM code so
> >> that would need to be added to the generic header should we go with this
> >> patch.
> > IMO, the content of asm-generic/sizes.h should only include power-of-2 sizes definitions.
> > And SZ_48M could be replaced by (SZ_32M | SZ_16M) or (SZ_32M + SZ_16M), or added to arch-specific headers.
> >
> >
>
> I'm hoping that kbuild gets asm-generic support sometime soon so files
> with only a "#include <asm-generic/*>" are generated instead of living
> in the tree. In that case I'd rather have the non power of 2 constants
> added to the generic sizes.h and be done with it. There isn't any strong
> technical reason to deny power of 2 constants from the generic header,
> right?
No.
I just think that power-of-2 sizes are more generic, not compulsively of course.
Sam Ravnborg had introduced a patch set to provide generic support for
architectures that using one-line asm-generic headers.
CC: Sam Ravnborg <sam@ravnborg.org>
>
> Note: SH could also move to this if SZ_26M is put in the generic header.
>
> --
> Sent by an employee of the Qualcomm Innovation Center, Inc.
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2011-03-23 8:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-21 23:51 Stephen Boyd
2011-03-22 8:34 ` Arnd Bergmann
2011-03-22 9:21 ` Russell King - ARM Linux
2011-03-22 10:10 ` Arnd Bergmann
2011-03-22 13:43 ` Guan Xuetao
2011-03-22 18:39 ` Stephen Boyd
2011-03-23 1:29 ` Guan Xuetao
2011-03-23 3:16 ` Stephen Boyd
2011-03-23 4:07 ` Paul Mundt
2011-03-23 8:30 ` Guan Xuetao [this message]
2011-03-23 14:31 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='016301cbe934$957a69f0$c06f3dd0$@mprc.pku.edu.cn' \
--to=gxt@mprc.pku.edu.cn \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=sam@ravnborg.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®