From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62EF03D4105 for ; Fri, 31 Jul 2026 14:07:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785506844; cv=none; b=eBsRUxBs/cnwBe+dCHG14c0tlNCzuMmCfResyHVVKLcWL+4HJjH3JSm/gpU2hxPcJ/h2/Wfila4tWUh/2GzH7+exIK1GCshwcFA/K6Dh6878YXvuStcmLOjsLKuzSOHkonyDa6/0Zq8EVzAcULrmZvNRwg14A3rh3YObxO8ZnJM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785506844; c=relaxed/simple; bh=Ipd83tvs5tHlvqKgCI2fStVgwKZodlwvcFrZ6rmFfnc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XRO+LoolPcksPSO76Ca8seNaLkj1iq1dadEv3Omt5nL94Y8InjjeH/1Wesue9kYT4KpDFn3kPCparvwTswWbo9goaXyNa9NJZctQ2BULvrFFGcFeWAxH1FJg3FYw1HENQTlzTGpWWqU2LKhLptqyI2vVcpUJQwuevpBwYCaHQd4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=aZ+kO3ne; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=EU0yma8J; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="aZ+kO3ne"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EU0yma8J" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66VCCB463778260 for ; Fri, 31 Jul 2026 14:07:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 0RTiRKJ5MonxgEru8fCq70aq6/NcAgUdpUxtAW+EJi8=; b=aZ+kO3nefTTOO27u EHbuin3w6oc9gMdbLhWWGFMTEPCYsFAGEsnL9sCMByAYrPoKvU/hLS2MoBu0WHfb i8zJ6uOy6za7dDuRcHknuazF3+ykTlVaV4cT18GLTHJz3BL7RUBhNNXDYbWAi/H2 2lql6pY3JDjLHSJrqiAKR/Q67o4dcExzPYRDFb9KjkGPXnTjwgRxIWh7Se/Ma6yQ IKeZr64/nHoqvfr2QhInSYmLMGfHhO1SrylT4uWDctOl8XjeIq7UJBafX6EYL8Pg gypbTdO/ByztJ6GKQWPJ2SfxUnPgixjwi+O6nTyXxSNVR76UQEfqISUpCeZyiPXR +Ix2QA== Received: from mail-ot1-f69.google.com (mail-ot1-f69.google.com [209.85.210.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4frugh0fdt-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 31 Jul 2026 14:07:22 +0000 (GMT) Received: by mail-ot1-f69.google.com with SMTP id 46e09a7af769-7e9ef09fd65so174168a34.1 for ; Fri, 31 Jul 2026 07:07:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785506842; x=1786111642; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=0RTiRKJ5MonxgEru8fCq70aq6/NcAgUdpUxtAW+EJi8=; b=EU0yma8JqxIrQkQCUezyn73HW706nNEm0YRCzebva4RZ14ur0+IsfS59i4etetFTSa AhquM2tLYUTx/SE95d89RCouLnkK0au9zy6iUw/kWh/WzoIk5i8zzBIDMZVvCh1/EGOK DK9tTlA3nt3HsG+SmsTPPACk5PNAy4/yzBvylke6sz0/zj83TCkndGg98fTFjWeKAXZ8 2rq2FZgUA5izlLl2iI7NtsU7ON3lAFU1qF7DvFifPUFZ2Q2lBzb/7klRThn/TTGR1hka hDPP4VZW2G1AP6aY/JNp518s18H5A9GjHhyGGhSYoDJhSRjrfap3YJeuwWtDsmUyDSA1 Me1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785506842; x=1786111642; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=0RTiRKJ5MonxgEru8fCq70aq6/NcAgUdpUxtAW+EJi8=; b=e8hRWWkkX0wk+vArDWKs7TaeUOYCD8bNEk0TtE+b/SmLWbCFQBGExYAnBXBwTsEcwA sF0MoYczAVmQHrr502Bjk6wf0kgPT86mF8hfXkM3f0U/WVocV4Uyav5heTsWGN7BOfu5 oWV3/LNxkb7RLOQGenvXUAa3Xs80DNp1NN9maxycM5+8AZNWzsduuTUpe9cxNjLNoVe8 6d5SSliObyq9zqpovBPtuRbnMtGseIBJHwcGbf+rwpcYLxOrN0lvMDwLwaANrM8+leSn VwY4yZjRSr0IiKuB9SPAV2kEHyIvXgwRG2w34iDK9Kc3Kv7WmOmVi6Yx7TGmWNWUYnvE 8Ekg== X-Forwarded-Encrypted: i=1; AHgh+RpSZSDBQQfpeCIZZ7ee59V2D8n+mmQB31K8XOsWjj2K6rkXeBaR+RFAz8+kv7KEABLlFjZLEk7/AveLJyw=@vger.kernel.org X-Gm-Message-State: AOJu0YzrQZK8XOsMiOE7kzqBWjBNfDDtg7t8FniL4CGFS84VBF/XJi4H xtle0+9J3BY1qrDZucduF7hgebhv6so5dJggDnBzW/x5RRKqOtWsWZEYslvStO5sdd/i2FksxQY Wfo1bQZbq5Kt91FVY18po4Yo/Mqoe3Y5PmVs4meBXuh5wOZAY+DAHh+le/4dIdI5YdEA= X-Gm-Gg: AR+sD11xxXspALROxpK3ZSsJuA0X6bSHbQMbAmP4J5cg7WG/dRE92HmI8lak7+Yi5MT aMlfgrOuULCr1kMTIdxkMB9jtxq8zUgbVxZz8AcSouY948v50EPF8njSNvy7vhr+WZp3Hr+We+n rqL4SabxPvGp89XTPtXldBRVNXfrrLthCflSNAF9FnsEJk42JWGNtAkX5hNxgsjD260bkOz7RPT eH9BjySN5fSncrUNSHYGVjGmk6CTGUuMVPNqK9CONjD00e9597v5K+h+yxTAeAxuaVF3TxRKkd+ A0MZz5Nq4ocPypwyWYix/blaViocxWeldICacOevjgCUAYs0DVoPs7s+AKYp9k+uy6U0FMS3C6O +xoaOtia27TCKPQqbZgjlsWZU X-Received: by 2002:a05:6820:5703:10b0:6a3:d9c7:376e with SMTP id 006d021491bc7-6ae431a3d85mr160321eaf.0.1785506841903; Fri, 31 Jul 2026 07:07:21 -0700 (PDT) X-Received: by 2002:a05:6820:5703:10b0:6a3:d9c7:376e with SMTP id 006d021491bc7-6ae431a3d85mr160282eaf.0.1785506841410; Fri, 31 Jul 2026 07:07:21 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1fd44e9ff0sm139807566b.42.2026.07.31.07.06.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Jul 2026 07:07:20 -0700 (PDT) Message-ID: <016603e6-8e87-47d7-96fb-5441ddbaeb28@oss.qualcomm.com> Date: Fri, 31 Jul 2026 16:06:19 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/5] i2c: qcom-cci: Switch msm8953 to the CCI v2 timing/rate config To: Loic Poulain , Robert Foss , Andi Shyti , Wolfram Sang , Dmitry Baryshkov , Luca Weiss Cc: linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, vladimir.zapolskiy@linaro.org, konradybcio@kernel.org, stephan.gerhold@linaro.org, Wenmeng Liu References: <20260729-cci-clk-fix-v3-0-f3c731d1596e@oss.qualcomm.com> <20260729-cci-clk-fix-v3-1-f3c731d1596e@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260729-cci-clk-fix-v3-1-f3c731d1596e@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzMxMDEwNyBTYWx0ZWRfXyNqELz/ExTSe lU2SfYCrY/VhrZXv1OXXpI34eD9I0X1c90FTJd28qWu8ileo/5bLZtkpLbe+RraXkqc2RpL8dSh eWqxQ6lh0PnRE6HMxV/Yehiw2074Ud8/mRUKLb1aeeEJPwLSOvcF/izQMliMLNunj++k8bZ8P0F pftDzjOIX0b3blgHSPVeYDNagTYF19ma3DpUvxhu2CrbS9RN4WB1GEsuAUTBEyh9ydkAuuulR74 g3kDiU6ioxP+aPE1z4vj2yGiQL7ZEL2Mo3ImqjjPlJ20S4HPLZylZNxcp1kNKMHgGEq2XuzfX4G VDPs/Qswb3sA3iu6dV0Uc3/J6pLjjdgq/Y4U9mSUEQ/7Pnm/Num4dHlgwbAvKLvtwWVaJyXMdwN nHHgoXYKBWw21amh51XsJ2jFdV/cHSuXmatg6o5r2S/rkLpC0nx2DiFSAEHNzM9tiq07EM4IoV9 H1OojMpt6tMa3Tz/2UA== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzMxMDEwNyBTYWx0ZWRfXx3uJy8xI+bSR CIQG+c7MLxUNCqhKkuYxqDP69bSwQJNfa/hPiUE4sW3JviINm1tEmXccQ++UC5rDBJc6ZITitV3 pa2sKrPJzLYMMd7WD39maZnJK2EJz+Y= X-Authority-Analysis: v=2.4 cv=U+iiy+ru c=1 sm=1 tr=0 ts=6a6cac1a cx=c_pps a=z9lCQkyTxNhZyzAvolXo/A==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=oFlMz6Kjfd5ZYSfE-JoA:9 a=QEXdDO2ut3YA:10 a=EyFUmsFV_t8cxB2kMr4A:22 X-Proofpoint-ORIG-GUID: hxtNDy_QHd3fvi9iECvUCz1rfXDUB1Ay X-Proofpoint-GUID: hxtNDy_QHd3fvi9iECvUCz1rfXDUB1Ay X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-31_04,2026-07-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 malwarescore=0 spamscore=0 lowpriorityscore=0 adultscore=0 impostorscore=0 suspectscore=0 bulkscore=0 clxscore=1015 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607310107 On 7/29/26 2:25 PM, Loic Poulain wrote: > The msm8953 CCI timing table is internally inconsistent. Its Standard > and Fast timings match v1/v1.5, which are calibrated for a 19.2 MHz CCI > clock, but its Fast+ timings are essentially the v2 values, which are > calibrated for 37.5 MHz. Since all masters share a single CCI clock, > no single rate can satisfy all three modes with the current table, and > the DT assigns 19.2 MHz, so Fast+ timings are wrong. > > The msm8953 CCI is the same hardware version as msm8996/sdm630, which > already use the cci_v2_data config (37.5 MHz). 37.5 MHz is supported by > the msm8953 CCI RCG, so reuse cci_v2_data for msm8953 as well and drop > the redundant, inconsistent standalone table. This makes all three I2C > modes self-consistent under a single clock rate. > > Note this requires the CCI clock to run at 37.5 MHz, the driver selects > and enforces the proper rate in following patches. > > Tested-by: Wenmeng Liu Wenmeng, have you actually tested this on MSM8953 device? Konrad