From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752324AbdH2Lmw (ORCPT ); Tue, 29 Aug 2017 07:42:52 -0400 Received: from mail-wr0-f175.google.com ([209.85.128.175]:35114 "EHLO mail-wr0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751432AbdH2Lmv (ORCPT ); Tue, 29 Aug 2017 07:42:51 -0400 Subject: Re: [PATCH 9/9] clocksource/drivers/bcm2835: Remove message on memory allocation failure To: SF Markus Elfring Cc: Thomas Gleixner , linux-kernel@vger.kernel.org, Florian Fainelli , Ray Jui , Scott Branden , Eric Anholt , Stefan Wahren , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com References: <20170829093354.GA2572@mai> <1503999271-15712-1-git-send-email-daniel.lezcano@linaro.org> <1503999271-15712-9-git-send-email-daniel.lezcano@linaro.org> <1822c0d4-8f5d-611c-21df-4945f298be0a@users.sourceforge.net> From: Daniel Lezcano Message-ID: <01662951-8a60-5c1c-cc72-464af1d3950d@linaro.org> Date: Tue, 29 Aug 2017 13:42:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1822c0d4-8f5d-611c-21df-4945f298be0a@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/08/2017 13:21, SF Markus Elfring wrote: > I would prefer to use the wording “for a” instead of “on” in the commit subject. > > >> The bcm2835_timer_init() function emits an error message in case of a memory >> allocation failure. This is pointless as the mm core already do that. > > Does this commit message contain a typo? > Would a wording like “… does that already.” be more appropriate here? Yep. Fixed. Thanks. -- Daniel -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog