From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756771AbcISKC6 (ORCPT ); Mon, 19 Sep 2016 06:02:58 -0400 Received: from mail-co1nam03on0081.outbound.protection.outlook.com ([104.47.40.81]:59488 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752279AbcISKCt (ORCPT ); Mon, 19 Sep 2016 06:02:49 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Christian.Koenig@amd.com; Subject: Re: [PATCH] drm/amdgpu: remove unused functions To: Baoyou Xie , "oded.gabbay@gmail.com" , "Deucher, Alexander" , "airlied@linux.ie" , "Li, Samuel" , "Zhou, Jammy" References: <1474207999-3380-1-git-send-email-baoyou.xie@linaro.org> CC: "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "arnd@arndb.de" , "xie.baoyou@zte.comm.cn" From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <0169238f-8a45-3f1c-da6a-9736fa55dcd6@amd.com> Date: Mon, 19 Sep 2016 12:02:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1474207999-3380-1-git-send-email-baoyou.xie@linaro.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [2a02:908:1251:7981:e5d2:5583:7841:2f5c] X-ClientProxiedBy: AMSPR02CA0013.eurprd02.prod.outlook.com (10.242.225.141) To BN6PR12MB1298.namprd12.prod.outlook.com (10.168.227.148) X-MS-Office365-Filtering-Correlation-Id: f6d7a92c-88fb-4f09-8655-08d3e0741b19 X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1298;2:t5aMdZPH/hF32STnIHkPDep1tzc7Ux3MIgF3DOpjAy08L4i/tnbU1VrzuopAOadsvg0t0hBcmKKCf93VjzMDkZKvv17ZBQoOA3ynkyfpAxs7eEOurJYZbJMAenE/dTf+jk/VmRAzGY+JDu72L1ms9QnLRhIJmZ6zYDVStIKZYd9i2jaeXIMOnLKxJgVo023s;3:BAqS64nN097rlm9l3F3P8x+2OlSZamw2HqTDjZj8YNcfTrhTb1yw0YxY2xG4+hVpVgp7mo83gREAbNhDBfLKYqCDv+YHJBDE9pCMEOlWiJEdaKRgK5blqgKlXIvhjupu X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN6PR12MB1298; X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1298;25:bJmQqZvKkvJ0rAMkro+wRNcV4kL4BCcaBjN1gF7rbuR8k92s9NUqjM6Reoa5+QT+WjqxoJVrM9sJu2ta7CR8n8oy5mJQ7VMiPal2L3e0jYvXtd/Et7/nIW21b68ITy1McD3v3Y8+h61qvq6XAwokj/h1K0PeC73qfn33HklSmNOO3ARd2Son5WntQwaQKAhLejNiNtQA6CQiKOyMjmWH0FqkroAQ/rItGrlwYRiASZyptBHRoJvsh3f6xnps6caF1QBNhAtYXYmU9t6wqFB14KpfCQuWF/0IfdXEN21R8sZpvluAQNUpdV4Tsr29QqlnUHVqOWauZ1MgoDHlaGdlfXq7B1sdxDCGB3Ne5iTgQIDjo/hHxhM8rK4WGNr1EwtiY65uwrf2rgQ6eWendApvLJemtGON3pSf/L2oQfIm7eCs6DimJZ2g8YAQuL1unUsW+KZUmQdZ3RyTeptt7TivYffCQdXJ56ACx5kdCfy5+GCYJtfgUSIrlaM8436un1D75fOKcKEvj/3/UghseE9Td5F+LGOoHcU8ZgLzIXXxyWkmcuWTR1xOUqnfG6ynFLpCGcnaUFgMB5u8OBwuU2/9q6m6ONwlP7acE90VGCIwl/D30fzueKQcwrp8nQW9ic2/oSJFlNMnijoVpJdQmTr2U4MeWwgTzBQR1cVJVadnHArZ7+pg+4s6zYzlXGCYc/mFzYtsQdbJMt6MHMedDh3Ub0Eu/ySJMEFsE/jaKFGo6xfIOUbhnyUE/hqvSP75ndmv X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1298;31:UH72o477vSJ/A68qcnjKnFRM//aS9FerEo+vkobm2oJL1AKk7firyTujFuAm2ug5d0eE5WXiZGlzdbTySASB7bNopevC/Yo13IwcK1nMqXentkBm9HCzSz6CZWR+rD5XxZjZM+7um9GRB/dNZIt0wknOXv/Jn9E6+OJohyTj0fz3yoCI4jqtky1uRzE/SU7tZdm0Di9GQ9Tv/3OSm+o7dQwSWcvVk0WaAgeTFLWElZQ=;20:x79yAfYj9GCi0pK5JsiDRDdL8tNf/4JeboV2BrnExugl1H40DiWDg4oEZiVutlfhqN50zsQvtsBgR66QGjpxUIrSRS332yiaWkQTKXDfgG19fTcIlupMFazzYhCuHTYnecPRjEDnbg1EyhPIfa6p9MlkSog3hsnQxcsmk3BBA8yoXsbenfn4/lMHg0LpVh1QbxwiiETDYCJGHCNARruA5sBwKiUdaN1GxmqtAlonGbwscSIAbyvF7Hnq7fB5RofjxMSIdXTa9ZUxnGBkU06elozspSm0QrOYjUw41pQB94uQWdpMxlj8L6BQQiOL1aMQvKtGnJELjsQjgXy3rwAjw2ZYLrVORZc8xPQ2hS2y+I+Hxua4khdqCZUFPxzCDhB4M3atuGkaXOMF5jC0onj6Z1zP/oc8wf+IRRitAkJcOCsRL7i53Gh8sOuaCxoDZe8gxCHdU1FyGCN/ilg/6cwALDWogMVMFVUmneSa/BuAkdHRLnFVlSwXEg4LI1k0e80C X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026);SRVR:BN6PR12MB1298;BCL:0;PCL:0;RULEID:;SRVR:BN6PR12MB1298; X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1298;4:hwwe5BS3ngw9dpE9Mbfvei8ypVD3mUIGECXBzowJOmmeQWEQJq+QRAgJ3QrzJkiyZh79ZqMN0ntHejWuXFqjA9HIlre1fEBn4y7noeHC6Hk33zhRKuG3Jh/XL8HDwFc9pmwskFwkwOqRDFV1m2LB0GqSHCn4FMetMmLAuQnIR3zqRtbI7f9u25u/pA7jBYtnQtfFiRsMfZcw1Y5oMX2QATbYn8HAQc1lTfR3bdTTnQTqpHpd4oA+fQdIs/b1qAlupelpI0PqLcnq+atEbs2OyXt2RVTZiQ1tzEc90pEhJNJBnUjJlZa/QaDq6nNMg0i3pstYW1A3r5pVGExS2WFXTbZRkp34JjAWfW9acmT7aJ6WFPxsGtU3ewyi1CrN8qe5EF+LG/mAj6OGzIjPmGfH7UD43eW82j0kblD5X+4D8g0p/IFHoddEu4EPf4eKaIKH X-Forefront-PRVS: 0070A8666B X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(199003)(189002)(65956001)(65826007)(7846002)(7736002)(68736007)(83506001)(106356001)(2870700001)(47776003)(65806001)(575784001)(86362001)(5660300001)(2950100001)(2906002)(81166006)(81156014)(4326007)(31696002)(2501003)(305945005)(8676002)(92566002)(19580395003)(77096005)(1706002)(19580405001)(6116002)(586003)(42186005)(31686004)(105586002)(23746002)(64126003)(76176999)(54356999)(189998001)(4001350100001)(50986999)(5001770100001)(97736004)(33646002)(36756003)(50466002)(101416001)(3826002);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR12MB1298;H:[IPv6:2a02:908:1251:7981:e5d2:5583:7841:2f5c];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BN6PR12MB1298;23:41BCigXzoG9dT0KUCaEWZKgyB4Gye2cf2drwv?= =?Windows-1252?Q?j9mWYBoYqPJuPwMgHzLVl6uVhFn7nfdECBBHBihdF7NDvFj4ufMUCnDR?= =?Windows-1252?Q?xiAWDfTJLIbZnIf6/H3oYKs5h82aSRXpfAGky1aXcvqtRF950255ty5N?= =?Windows-1252?Q?XMV1HSRy9wxB6GYYgmaGQjqjZWeD2HzbWtZjYSgCtsX1WqLnfauwuw+l?= =?Windows-1252?Q?L2E1uiYCuYw3lnxL6+rzCdqZwc/XS0GfWOFJKsPSlUCoa07xqLJkKlpZ?= =?Windows-1252?Q?e74orfGLvhHshI5dowHXRL1YMhU+jEeKLKXeJF5rKxY20dtJ1yprsv7L?= =?Windows-1252?Q?kl+AWkkJ8HN73m3N/zvMPK+kxRqfmgEygELMwZxsxuN7ehLKCcqWUGnC?= =?Windows-1252?Q?gS60hdM2zFoVUz4FpyRgONjyY5F/LP2wWnY0D6fQ+e4Y7NgJ47QTkaOo?= =?Windows-1252?Q?CNV+7YefDS0qR1Y2oAQCPQOG4vimvHD0+T8EyyPrJpK25mb8UNPfbeYi?= =?Windows-1252?Q?s/xgdBUVsbos7i9sM2LR6i5KixyrvR5lERCaxSz7xSdzTtaTWJv/vsk5?= =?Windows-1252?Q?cdFlwO+WTn02bVcJPyIR8SXmhKsuJL0mVnl2p1AOcDQ2XLK49xFMz5YY?= =?Windows-1252?Q?dC7ag83vFP/yWA29NULAxmZnenk05EmdtCrDoVD4OIvWE8k2J838VWXQ?= =?Windows-1252?Q?y+pPXT10BY8oDUTuA+0h98vQ5id8Fd5/KFcuWMbUqsWk032lomrHhMpN?= =?Windows-1252?Q?QFt9NzEq+oiPUnJCcvHp9rtf454ebzjyDHNhxeFPLinZ01AvY+9Vj1xU?= =?Windows-1252?Q?Ea2YFOIX+X/d3EHVGvYGIEBsAbOztTMDflrlHGkXdKVfUsmdgTRucBko?= =?Windows-1252?Q?jKaoFGWVC8L7nuN+d72PZ9otubSJQd0EzoXogGxOAX8dkzDlT/Zagia0?= =?Windows-1252?Q?ofJN5Zme0dq0DG/mH2cVS/MKZ5lhSP2eFBM5tAEbwTVOYfZNFLoYIVxD?= =?Windows-1252?Q?UQggavxIDynvQj/raubop6EsuLkmfH/ysWMvfHXUiguLJgDebREQ3ZSD?= =?Windows-1252?Q?hbqRv6FyZbpgD6WxrDVcMgOQUfCZhSPmVhfbTXBk0nSNumdMaYaybNFW?= =?Windows-1252?Q?+MkaFKcDYm58iMr1BaUteLi4zT4ZdFt6K6ce9dRS8Lb1f7SpOtxmKT3a?= =?Windows-1252?Q?BKZ1oSr5VFsuSW2Ax1OobTnenKI8GC7Rc0bIj+Mah08TKqa4W9w/pVmc?= =?Windows-1252?Q?puPgXnMqWNBOKy7/oa3UbF9UgpF+Q1m72BC0iwY2VmMXqalT9jaD0Nn3?= =?Windows-1252?Q?C1iL6eVrspmrfPU5jZkze641ObWOEfNewp4LDwo0/A88AtmaOLF+zMmP?= =?Windows-1252?Q?2dEyFzOkbuT?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1298;6:mh3pymosTorF/0UGRbjzujM16L659PutHGqlimEew6G49WI4a590HDnPkIW2UC/ZiArLK5d1F60P1mWVuWvHKio9sks6KQJxGvF73Jm8irX85qlblptUuN/2pBUvCMkqqVGwux4AlBsg8a4kBM6egWykM53p6iLvIQ6WZXkE8kZGBTfvwqhz9IvWBjFjxq2dyAHl+d1qJOo+cOptpiYqbT2uwemq0wbprNUor4L2suzTD+SbSjlWMON1gH9dkYjk3eZbwL8wlzFGgskRHsz8d8a2+qtaA07qARZTbp148a4QJhR/Lf3u9S7HiqmcEq+smfZUqFUG8B+kZGkT39gpcw==;5:SQbFQgj3sJ0JU1Ln33ehF3xBkt6PpLo3g4qTNsj7+NhLxdrOycHyC6p1FLL+wELAxrL4ITbNT2UJ6psRQkz5wd4lwG4jwC3ZnhNQEQrcfuy7hkF6K7bNrz9g5I4pz/89kKCgatYceQ25aZ26gb7WPA==;24:a+4kIh0YyummtQPef7VYHgx6fYoq/5c/KAXeOshue7hNwzABz3kdkZ8zcwXIUHGpn8VQis+hBKRkgEE8dL7+OOJhhPbP943EO4MWPuaWjqk=;7:fMuNNpShdGLIzQaEU5Jw4oJGG6xbFqhEKSRhLUuBwekA3TLN4M+alUfdPLCqEm8txleUGfvMbdLtM06SLbR6Nha4bEuYZVDd1Anjtw+NtZd4F61qBM6DiMj+drh674pLwg2e4rS3pgYG4my+6vf3PU6zOPBkvV+Ly7rCAdpk4GyErqKZDWwog5EYLHzX58FzWxyB8smo1MI4/IGoUOwLyL6F1iGyZfaFpiuQBE/VuMYfSB7fWqzLBBfXTTjIGa/e1lUt8zMFGV3Cp8nuVrIY7FJGcnISYjFiHxGbInYbmfDVdJHQ3qdsyyEd3zYz7/0P SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1298;20:Baedd0k+tV/4A3ww9cu97NMJhnI1+0Rcx7ZQxB8vO9VmICmmPxg3frE/XDbOQgwjwgENxEdX5U32Mtp6voJ7F0/k8WrfY6gw3OYZProSk+YijOhy6GDe3N1wI/BpTCaDLvuJASREg+i3mPJO2vbjiPseOId9FZu05XY5wuUCcWXCvgS5eT8AhTwJ7DEKoe7V6ekhqTXzif4Hrw4EA4eOH6zGC2ZXik58j3haimaHkeheSRvl8i33k863m5wF8P3e X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2016 10:02:45.1556 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1298 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 18.09.2016 um 16:13 schrieb Baoyou Xie: > We get 2 warnings when building kernel with W=1: > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c:146:5: warning: no previous prototype for 'pool_to_domain' [-Wmissing-prototypes] > drivers/gpu/drm/amd/amdgpu/cz_smc.c:104:5: warning: no previous prototype for 'cz_send_msg_to_smc_with_parameter_async' [-Wmissing-prototypes] > > In fact, both functions are called by no one and not exported, > so this patch removes them. > > Signed-off-by: Baoyou Xie Reviewed-by: Christian König > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 8 -------- > drivers/gpu/drm/amd/amdgpu/cz_smc.c | 7 ------- > 2 files changed, 15 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c > index d080d08..dba8a5b 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c > @@ -143,14 +143,6 @@ int amdgpu_amdkfd_resume(struct amdgpu_device *rdev) > return r; > } > > -u32 pool_to_domain(enum kgd_memory_pool p) > -{ > - switch (p) { > - case KGD_POOL_FRAMEBUFFER: return AMDGPU_GEM_DOMAIN_VRAM; > - default: return AMDGPU_GEM_DOMAIN_GTT; > - } > -} > - > int alloc_gtt_mem(struct kgd_dev *kgd, size_t size, > void **mem_obj, uint64_t *gpu_addr, > void **cpu_ptr) > diff --git a/drivers/gpu/drm/amd/amdgpu/cz_smc.c b/drivers/gpu/drm/amd/amdgpu/cz_smc.c > index 69ac373c4..db67e0c 100644 > --- a/drivers/gpu/drm/amd/amdgpu/cz_smc.c > +++ b/drivers/gpu/drm/amd/amdgpu/cz_smc.c > @@ -101,13 +101,6 @@ int cz_send_msg_to_smc(struct amdgpu_device *adev, u16 msg) > return 0; > } > > -int cz_send_msg_to_smc_with_parameter_async(struct amdgpu_device *adev, > - u16 msg, u32 parameter) > -{ > - WREG32(mmSMU_MP1_SRBM2P_ARG_0, parameter); > - return cz_send_msg_to_smc_async(adev, msg); > -} > - > int cz_send_msg_to_smc_with_parameter(struct amdgpu_device *adev, > u16 msg, u32 parameter) > {