From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932620AbeEaAi4 (ORCPT ); Wed, 30 May 2018 20:38:56 -0400 Received: from icp-osb-irony-out2.external.iinet.net.au ([203.59.1.155]:41948 "EHLO icp-osb-irony-out2.external.iinet.net.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932525AbeEaAix (ORCPT ); Wed, 30 May 2018 20:38:53 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2CvAADJQw9b/zXSMGcNTxoBAQEBAQIBA?= =?us-ascii?q?QEBCAEBAQGDGYENbTqDd5UtAQEBBn8pdRqVNSqETQKCPjgUAQIBAQEBAQECgQi?= =?us-ascii?q?FNAEBAQECASMVQRALDQsCAiYCAlcGDQYCAQGDHgKBcgUXpQ9tghwahD6DbYFjB?= =?us-ascii?q?YEKiDmBB4EPJII0NYJ6hHmCVAKHI5FCCAGFbIJXhheIA4UPiXGIeoFzMxoIKAi?= =?us-ascii?q?Cfh+CARcRaQEBh12FUF2PcwEB?= X-IPAS-Result: =?us-ascii?q?A2CvAADJQw9b/zXSMGcNTxoBAQEBAQIBAQEBCAEBAQGDGYE?= =?us-ascii?q?NbTqDd5UtAQEBBn8pdRqVNSqETQKCPjgUAQIBAQEBAQECgQiFNAEBAQECASMVQ?= =?us-ascii?q?RALDQsCAiYCAlcGDQYCAQGDHgKBcgUXpQ9tghwahD6DbYFjBYEKiDmBB4EPJII?= =?us-ascii?q?0NYJ6hHmCVAKHI5FCCAGFbIJXhheIA4UPiXGIeoFzMxoIKAiCfh+CARcRaQEBh?= =?us-ascii?q?12FUF2PcwEB?= X-IronPort-AV: E=Sophos;i="5.49,461,1520870400"; d="scan'208";a="114396597" Subject: Re: [RFC PATCH] m68k: set dma and coherent masks for Macintosh SONIC based ethernet To: Geert Uytterhoeven Cc: Finn Thain , Christoph Hellwig , Michael Schmitz , Guenter Roeck , Joshua Thompson , linux-m68k , Linux Kernel Mailing List References: <1527378785-13326-1-git-send-email-linux@roeck-us.net> <55c1c33b-4a34-bd72-57de-577ce8d95e0b@gmail.com> <2ffd0de6-e8d6-6449-7c05-cbbfd8a99a97@gmail.com> <10880132-7686-78f6-7f9f-3fc29c3e554a@linux-m68k.org> From: Greg Ungerer Message-ID: <016dfee5-5fca-548e-32df-f2e4ab8a5e41@linux-m68k.org> Date: Thu, 31 May 2018 10:38:48 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geert, On 31/05/18 05:55, Geert Uytterhoeven wrote: > On Wed, May 30, 2018 at 2:28 AM, Greg Ungerer wrote: >> On 28/05/18 20:15, Geert Uytterhoeven wrote: >>> On Mon, May 28, 2018 at 7:26 AM, Finn Thain >>> wrote: >>>> On Mon, 28 May 2018, Michael Schmitz wrote: >>>>> Am 27.05.2018 um 17:49 schrieb Finn Thain: >>>>>> On Sun, 27 May 2018, Michael Schmitz wrote: >>>>>>> That should have fixed the warning already ... >>>>>> >>>>>> It's still not fixed (hence my "acked-by" for Geunter's patch). >>>>> >>>>> Odd - does link order still matter even though the >>>>> arch_setup_dev_archdata() function from the core platform code is >>>>> declared as a weak symbol? >>>>> >>>>> I'll see what I can find out on elgar ... >>>> >>>> Any one of the numerous patches/rfcs/suggestions that I sent will avoid >>>> the WARN splat. >>>> >>>> When I said "it's still not fixed", what I meant to say was, "it's still >>>> not fixed in mainline and no proposed fix was accepted to the best of my >>>> knowledge". >>> >>> Indeed. >>> >>> Do we have a consensus on the way forward? The merge window for >>> v4.18 will open soon. >> >> For whatever it is worth I thought Finn's patch was the best approach >> (https://lkml.org/lkml/2018/5/17/333, "m68k: Set default dma mask for >> platform device"). > > FTR: done. Feel free to add my acked by if you like: Acked-by: Greg Ungerer Regards Greg >> We seem to be hitting quite a few places (within m68k) that otherwise >> need individual fixes. There is no immediate need to revert existing >> changes that have already been applied if we use this now either >> (like my FEC fix, commit f61e64310b75 "m68k: set dma and coherent >> masks for platform FEC ethernets"). > > Indeed. > > Gr{oetje,eeting}s, > > Geert >