From: Zong-Zhe Yang <kevin_yang@realtek.com>
To: Luka Gejak <luka.gejak@linux.dev>,
Kalpesh Solanki <skalpesh942@gmail.com>,
Ping-Ke Shih <pkshih@realtek.com>
Cc: "kvalo@kernel.org" <kvalo@kernel.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: RE: [PATCH v5 1/3] wifi: rtw88: clear RTW_FLAG_RESTARTING on stop and start failure
Date: Fri, 13 Nov 2026 08:22:58 +0000 [thread overview]
Message-ID: <0172ea8ade124189b52d5839d4f33a2e@realtek.com> (raw)
In-Reply-To: <9D4D810E-69D3-470C-BA90-3BBAC0788CC9@linux.dev>
Luka Gejak <luka.gejak@linux.dev> wrote:
>
> On November 13, 2026 7:52:23 AM GMT+01:00, Zong-Zhe Yang
> <kevin_yang@realtek.com> wrote:
> > In this case, I saw you clear RTW_FLAG_RESTARTING in rtw_ops_stop.
> > However, the reconfig flow might not have even run at that moment.
> >
> > How about clearing RTW_FLAG_RESTARTING when driver gets
> > IEEE80211_RECONFIG_TYPE_SUSPEND?
>
> As far as I can see that misses the stop case. If the last interface goes down
> during a recovery, the restart work finds open_count at 0 and
> mac80211 sends neither RESTART nor SUSPEND, so the flag would stay set.
> Suspend without WoWLAN also goes through drv_stop(), so rtw_ops_stop()
> covers both.
I missed to consider this corner case. My previous point was I don't want
RTW_FLAG_RESTARTING to be cleared too early (assumed open_count != 0).
I don't seem to have other way for this case except by clearing it in drv_stop().
So, keep the code. Thanks.
next prev parent reply other threads:[~2026-11-13 8:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 13:13 [PATCH v5 0/3] wifi: rtw88: firmware recovery fixes and LPS hang handling Kalpesh Solanki
2026-11-12 13:13 ` [PATCH v5 1/3] wifi: rtw88: clear RTW_FLAG_RESTARTING on stop and start failure Kalpesh Solanki
2026-11-12 21:28 ` Luka Gejak
2026-11-13 6:52 ` Zong-Zhe Yang
2026-11-13 7:19 ` Luka Gejak
2026-11-13 8:22 ` Zong-Zhe Yang [this message]
2026-11-12 13:14 ` [PATCH v5 2/3] wifi: rtw88: skip already reset station in rtw_sta_remove() Kalpesh Solanki
2026-11-12 21:29 ` Luka Gejak
2026-11-12 13:14 ` [PATCH v5 3/3] wifi: rtw88: ps: trigger firmware recovery only after consecutive LPS leave failures on PCI Kalpesh Solanki
2026-11-12 21:30 ` Luka Gejak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0172ea8ade124189b52d5839d4f33a2e@realtek.com \
--to=kevin_yang@realtek.com \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luka.gejak@linux.dev \
--cc=pkshih@realtek.com \
--cc=skalpesh942@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®