mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Mickaël Salaün" <mic@digikod.net>,
	"Stephen Rothwell" <sfr@canb.auug.org.au>
Cc: "Konstantin Meskhidze" <konstantin.meskhidze@huawei.com>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	linux-next <linux-next@vger.kernel.org>,
	"Willem de Bruijn" <willemdebruijn.kernel@gmail.com>,
	gnoack3000@gmail.com, linux-security-module@vger.kernel.org,
	Netdev <netdev@vger.kernel.org>,
	netfilter-devel@vger.kernel.org, yusongping@huawei.com,
	artem.kuzin@huawei.com,
	"Geert Uytterhoeven" <geert@linux-m68k.org>,
	"Randy Dunlap" <rdunlap@infradead.org>
Subject: Re: linux-next: build warning after merge of the landlock tree
Date: Tue, 03 Oct 2023 15:40:23 +0200	[thread overview]
Message-ID: <0174c612-ed97-44f3-bec5-1f512f135d21@app.fastmail.com> (raw)
In-Reply-To: <20231003.ahPha5bengee@digikod.net>

On Tue, Oct 3, 2023, at 15:15, Mickaël Salaün wrote:
> PowerPC-64 follows the LP64 data model and then uses int-l64.h (instead of
> int-ll64.h like most architectures) for user space code.
>
> Here is the same code with the (suggested) "%lu" token on x86_86:
>
>   samples/landlock/sandboxer.c: In function ‘populate_ruleset_net’:
>   samples/landlock/sandboxer.c:170:77: error: format ‘%lu’ expects 
> argument of type ‘long unsigned int’, but argument 3 has type ‘__u64’ 
> {aka ‘long long unsigned int’} [-Werror=format=]
>     170 |                                 "Failed to update the ruleset 
> with port \"%lu\": %s\n",
>         |                                                               
>             ~~^
>         |                                                               
>               |
>         |                                                               
>               long unsigned int
>         |                                                               
>             %llu
>     171 |                                 net_port.port, 
> strerror(errno));
>         |                                 ~~~~~~~~~~~~~
>         |                                         |
>         |                                         __u64 {aka long long 
> unsigned int}
>
>
> We would then need to cast __u64 to unsigned long long to avoid this warning,
> which may look useless, of even buggy, for people taking a look at this sample.
>
> Anyway, it makes more sense to cast it to __u16 because it is the
> expected type for a TCP port. I'm updating the patch with that.
> Konstantin, please take this fix for the next series:
> https://git.kernel.org/mic/c/fc9de206a61a
>
>
> On Tue, Oct 03, 2023 at 02:27:37PM +1100, Stephen Rothwell wrote:
>> Hi all,
>> 
>> After merging the landlock tree, today's linux-next build (powerpc
>> allyesconfig) produced this warning:
>> 
>> samples/landlock/sandboxer.c: In function 'populate_ruleset_net':
>> samples/landlock/sandboxer.c:170:78: warning: format '%llu' expects argument of type 'long long unsigned int', but argument 3 has type '__u64' {aka 'long unsigned int'} [-Wformat=]
>>   170 |                                 "Failed to update the ruleset with port \"%llu\": %s\n"

I think defining the __SANE_USERSPACE_TYPES__ macro should take care of this,
then __u64 has the same type as it does in the kernel.

        Arnd

  parent reply	other threads:[~2023-10-03 13:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-03  3:27 Stephen Rothwell
     [not found] ` <20230920092641.832134-12-konstantin.meskhidze@huawei.com>
2023-10-03 13:15   ` Mickaël Salaün
2023-10-03 13:23     ` Geert Uytterhoeven
2023-10-04 11:01       ` Mickaël Salaün
2023-10-03 13:40     ` Arnd Bergmann [this message]
2023-10-04 11:02       ` Mickaël Salaün
  -- strict thread matches above, loose matches on Subject: below --
2023-11-17  1:04 Stephen Rothwell
2023-06-07  3:52 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0174c612-ed97-44f3-bec5-1f512f135d21@app.fastmail.com \
    --to=arnd@arndb.de \
    --cc=artem.kuzin@huawei.com \
    --cc=geert@linux-m68k.org \
    --cc=gnoack3000@gmail.com \
    --cc=konstantin.meskhidze@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=mic@digikod.net \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=sfr@canb.auug.org.au \
    --cc=willemdebruijn.kernel@gmail.com \
    --cc=yusongping@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®