From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E408038A706 for ; Tue, 13 Jan 2026 10:20:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768299610; cv=none; b=bG99wau3dVaE+bEFiaU6M9aKuxxlUU1gzoJ8v7/3py/dCsXwZufIfSVCTOJg+vScH1y4IBMzcuS18TbLQ+hRJu128P/gtzunoNaBIRuhT/xRordgP9gkjrACsq5umfr8Jv6vW036+QUtc4Tv1ABc9zX9R8AwJXeYW1wfrO5gFTo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768299610; c=relaxed/simple; bh=qrJawEyRk9QiRfi3F12wRwzElwNErv3g2l29eOs+r0k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=C0EkNQXEIXeGeTzVRTEXFbgnDeeAD4QOBRpI3HCOpphwyo2PkmyztKgnsI6x81y2osoXtMhcppYifOv4zq/dXEWUOV+4lCGDL11Woinfhh5YW7duOrhHT3fFWMjiC/b/HTseWI9CPpMQFYPtb/87xRyJJ0UB7lKTVscfxGHiz+k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=egFMINjG; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Ooiqeq4C; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="egFMINjG"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Ooiqeq4C" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768299606; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Bv1RPjaO9ZdZred2Z39o/pHiVJywyFuAbsRMKmfexlM=; b=egFMINjG9sVNBqb/bV2XZhNplBDral3aIcm6MjzJ8KkONL0HSYMqaA3QbUO65Z3VmjlDC2 avtolazSY5YtoSfHzUhX8IHXZImPjTKrSF0SpQI64PSxuQnsUBdIaTLYXLPKpPTo/rpFnH rgclCKWeL9yRV6TXLr2qtEPxnARnTKo= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-529-WE5Y-k3sMWS_XHuxIspQCA-1; Tue, 13 Jan 2026 05:20:04 -0500 X-MC-Unique: WE5Y-k3sMWS_XHuxIspQCA-1 X-Mimecast-MFC-AGG-ID: WE5Y-k3sMWS_XHuxIspQCA_1768299603 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-430fe16b481so4144886f8f.3 for ; Tue, 13 Jan 2026 02:20:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768299603; x=1768904403; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Bv1RPjaO9ZdZred2Z39o/pHiVJywyFuAbsRMKmfexlM=; b=Ooiqeq4CDJAdeztIVeP08RIjonIFbu0Ix1QSuGAGLnpXxoa1G3zjRACEzvO2cO3ng5 K2zLp5murkupoMQjsTkt9xyL+bugptxPbtuaxL0PmUm2MeHLsh6JpmYCJcD6ViHvQH8v P3Xjf6FBz8ZsWfwg3RlydqvAFLgF734ZChGJX/Rxjup6E0lD0YazXep9YNEvw+gEXxhB y0PYSiW7q1diBoV5bcyaw+WPI0/VuMzlg9av8Bske1sOljgBO+qV2wTVqNaE7l0+wop6 BIE3XlsWPy2wCq73FGqRfy/zu5PLxZ441tO03GqAILwUpvnuVJdr777gVgEP+SxqdJ3w xkNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768299603; x=1768904403; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Bv1RPjaO9ZdZred2Z39o/pHiVJywyFuAbsRMKmfexlM=; b=QUwbPXNjK2EMm49pRpj5koYOq7STGdJniuU5EjztYIS0GL39Jr4fPhss4vDRmMvDq+ TzCma64Ze6bWKypaQwZw3wK7JuZ+3QKDg9ZyO2e0Sn7cEY0LPWH9fmHyU7pubM6cQdoP aLTShTiMse/gWxeBP0CnlK9vNxG+Ix51IDHs291woFXU3aUKRcbogeFPAbwaAOKH97dH ow3wujR1FDRrXvVi47jm/qRGDPjXUsxPdUov2x2qrglN8DfmwUj+0u3pwYrDAIKIRzEL h9kz7Nua7BYOjSJUBGCHtSWBQUfXUzPrtfqK2z5yARqP/WIW/ZyyhrwJ2GrVgPKOlvRE N0dQ== X-Forwarded-Encrypted: i=1; AJvYcCWD8Hsty4nxc2kyxp8UX9MJnhEWdP2MioXFOF0Fz8m/fI2HO9RHrdW3pwMX038AYXLmgeooHkOFco5gmfw=@vger.kernel.org X-Gm-Message-State: AOJu0YwegA3UeNfE7GhpVIQUz/kl1mkKYej92vihqEP0WkAoDV1KtSYQ hktzbjks+UBEmQtXYOl8IPbpjnUZjTekQPOcsOjvp2W/Bd5CCYEkudS5U4bIx3KJ3/3hFpmNu0X Vkht15iDgzZ5mTEb5gBwT9WZ5iNtuBYbj2EB5D5MhcPZ8Tkan8UFlu4Q6dLugpEb64A== X-Gm-Gg: AY/fxX4OkAZ9s8Ycevz05m9Uicsgg/S40TY7JNjzXZKQciD8YhM8QDO4hJzyeBE7h7b 7RG9rBRmc5u7iVAKCuOh98XS1DvfbR3ZDiVFDLwdM2twR/HI8yC+u90mFQXf2uiV90TkNOF3qft kROtJyKeFZpwoFFNUUslvSxuim8tOSNehECHkfa5vj4k4TL7M27vG9yI0QaQyMyhzepUCIguyIx cVw6+3cTQfHpdPyjmHL2nR2N+D7Z1jz68YUffO5z2Rbmf1Wl2IuYyuhq85kq2QLMWdQsGDLllB3 8cD6XEVHynjHMWoV24lO3VmceYtRD3p2uTGUuHBwQAmOkoXDe5o0rVndfCVKAPEInimUdEHnAfi A5VfcwylM6/Wy X-Received: by 2002:a05:6000:184d:b0:431:35a:4a97 with SMTP id ffacd0b85a97d-432c37c3600mr21248038f8f.59.1768299603321; Tue, 13 Jan 2026 02:20:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IHrath3hRlhdo9WrSLU/1jbO11BPh+MoIv4sHPe4d/wYiA0ReRHh6C563cNyJeTG7EVpok72g== X-Received: by 2002:a05:6000:184d:b0:431:35a:4a97 with SMTP id ffacd0b85a97d-432c37c3600mr21247977f8f.59.1768299602857; Tue, 13 Jan 2026 02:20:02 -0800 (PST) Received: from [192.168.88.32] ([212.105.155.93]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd5df96asm42541852f8f.28.2026.01.13.02.19.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jan 2026 02:20:02 -0800 (PST) Message-ID: <017b07c8-ed86-4ed1-9793-c150ded68097@redhat.com> Date: Tue, 13 Jan 2026 11:19:59 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v8 5/9] eth: bnxt: store rx buffer size per queue To: Pavel Begunkov , netdev@vger.kernel.org Cc: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Jonathan Corbet , Michael Chan , Pavan Chebbi , Andrew Lunn , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Joshua Washington , Harshitha Ramamurthy , Saeed Mahameed , Tariq Toukan , Mark Bloch , Leon Romanovsky , Alexander Duyck , Ilias Apalodimas , Shuah Khan , Willem de Bruijn , Ankit Garg , Tim Hostetler , Alok Tiwari , Ziwei Xiao , John Fraker , Praveen Kaligineedi , Mohsin Bashir , Joe Damato , Mina Almasry , Dimitri Daskalakis , Stanislav Fomichev , Kuniyuki Iwashima , Samiullah Khawaja , Ahmed Zaki , Alexander Lobakin , David Wei , Yue Haibing , Haiyue Wang , Jens Axboe , Simon Horman , Vishwanath Seshagiri , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kselftest@vger.kernel.org, dtatulea@nvidia.com, io-uring@vger.kernel.org References: Content-Language: en-US From: Paolo Abeni In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/9/26 12:28 PM, Pavel Begunkov wrote: > @@ -4478,7 +4485,7 @@ static void bnxt_init_one_rx_agg_ring_rxbd(struct bnxt *bp, > ring = &rxr->rx_agg_ring_struct; > ring->fw_ring_id = INVALID_HW_RING_ID; > if ((bp->flags & BNXT_FLAG_AGG_RINGS)) { > - type = ((u32)BNXT_RX_PAGE_SIZE << RX_BD_LEN_SHIFT) | > + type = ((u32)(u32)rxr->rx_page_size << RX_BD_LEN_SHIFT) | Minor nit: duplicate cast above. > diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.h b/drivers/net/ethernet/broadcom/bnxt/bnxt.h > index f5f07a7e6b29..4c880a9fba92 100644 > --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.h > +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.h > @@ -1107,6 +1107,7 @@ struct bnxt_rx_ring_info { > > unsigned long *rx_agg_bmap; > u16 rx_agg_bmap_size; > + u16 rx_page_size; Any special reason for using u16 above? AFAICS using u32 will not change the struct size on 64 bit arches, and using u32 will likely yield better code. /P