From: Zhihao Cheng <chengzhihao1@huawei.com>
To: Li Zetao <lizetao1@huawei.com>, <richard@nod.at>,
<miquel.raynal@bootlin.com>, <vigneshr@ti.com>,
<dedekind@linutronix.de>, <haver@vnet.ibm.com>,
<bbrezillon@kernel.org>
Cc: <boris.brezillon@free-electrons.com>,
<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] ubi: Fix use-after-free when volume resizing failed
Date: Fri, 21 Oct 2022 21:24:06 +0800 [thread overview]
Message-ID: <017d217a-5497-2627-afe3-c3c4ef70723a@huawei.com> (raw)
In-Reply-To: <20221021102157.1341807-2-lizetao1@huawei.com>
在 2022/10/21 18:21, Li Zetao 写道:
> There is an use-after-free problem reported by KASAN:
> ==================================================================
> BUG: KASAN: use-after-free in ubi_eba_copy_table+0x11f/0x1c0 [ubi]
> Read of size 8 at addr ffff888101eec008 by task ubirsvol/4735
>
> CPU: 2 PID: 4735 Comm: ubirsvol
> Not tainted 6.1.0-rc1-00003-g84fa3304a7fc-dirty #14
> Hardware name: QEMU Standard PC (i440FX + PIIX, 1996),
> BIOS 1.14.0-1.fc33 04/01/2014
> Call Trace:
> <TASK>
> dump_stack_lvl+0x34/0x44
> print_report+0x171/0x472
> kasan_report+0xad/0x130
> ubi_eba_copy_table+0x11f/0x1c0 [ubi]
> ubi_resize_volume+0x4f9/0xbc0 [ubi]
> ubi_cdev_ioctl+0x701/0x1850 [ubi]
> __x64_sys_ioctl+0x11d/0x170
> do_syscall_64+0x35/0x80
> entry_SYSCALL_64_after_hwframe+0x46/0xb0
> </TASK>
>
> When ubi_change_vtbl_record() returns an error in ubi_resize_volume(),
> "new_eba_tbl" will be freed on error handing path, but it is holded
> by "vol->eba_tbl" in ubi_eba_replace_table(). It means that the liftcycle
> of "vol->eba_tbl" and "vol" are different, so when resizing volume in
> next time, it causing an use-after-free fault.
>
> Fix it by not freeing "new_eba_tbl" after it replaced in
> ubi_eba_replace_table(), while will be freed in next volume resizing.
>
> Fixes: 801c135ce73d ("UBI: Unsorted Block Images")
> Signed-off-by: Li Zetao <lizetao1@huawei.com>
> ---
> drivers/mtd/ubi/vmt.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/ubi/vmt.c b/drivers/mtd/ubi/vmt.c
> index 8fcc0bdf0635..74637575346e 100644
> --- a/drivers/mtd/ubi/vmt.c
> +++ b/drivers/mtd/ubi/vmt.c
> @@ -464,7 +464,7 @@ int ubi_resize_volume(struct ubi_volume_desc *desc, int reserved_pebs)
> for (i = 0; i < -pebs; i++) {
> err = ubi_eba_unmap_leb(ubi, vol, reserved_pebs + i);
> if (err)
> - goto out_acc;
> + goto out_free;
> }
> spin_lock(&ubi->volumes_lock);
> ubi->rsvd_pebs += pebs;
> @@ -512,6 +512,8 @@ int ubi_resize_volume(struct ubi_volume_desc *desc, int reserved_pebs)
> ubi->avail_pebs += pebs;
> spin_unlock(&ubi->volumes_lock);
> }
> + return err;
> +
> out_free:
> kfree(new_eba_tbl);
> return err;
Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com>
next prev parent reply other threads:[~2022-10-21 13:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 10:21 [PATCH 0/2] Fix use-after-free and kmemleak in ubi_resize_volume() Li Zetao
2022-10-21 10:21 ` [PATCH 1/2] ubi: Fix use-after-free when volume resizing failed Li Zetao
2022-10-21 13:24 ` Zhihao Cheng [this message]
2022-10-21 10:21 ` [PATCH 2/2] ubi: Fix unreferenced object reported by kmemleak in ubi_resize_volume() Li Zetao
2022-10-21 13:24 ` Zhihao Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=017d217a-5497-2627-afe3-c3c4ef70723a@huawei.com \
--to=chengzhihao1@huawei.com \
--cc=bbrezillon@kernel.org \
--cc=boris.brezillon@free-electrons.com \
--cc=dedekind@linutronix.de \
--cc=haver@vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=lizetao1@huawei.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®