From: "Caprioru, Mircea" <Mircea.Caprioru@analog.com>
To: "jic23@kernel.org" <jic23@kernel.org>
Cc: "lars@metafoo.de" <lars@metafoo.de>,
"Popa, Stefan Serban" <StefanSerban.Popa@analog.com>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"Hennerich, Michael" <Michael.Hennerich@analog.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] iio: adc: ad7124: Remove input number limitation
Date: Thu, 20 Jun 2019 10:30:57 +0000 [thread overview]
Message-ID: <0183e4e49732e3de44fe9229c45764b307af8838.camel@analog.com> (raw)
In-Reply-To: <20190620091908.12041-1-mircea.caprioru@analog.com>
On Thu, 2019-06-20 at 12:19 +0300, Mircea Caprioru wrote:
> The driver limits the user to use only 4/8 differential inputs, but
> this
> device has the option to use pseudo-differential channels. This will
> increase the number of channels to be equal with the number of inputs
> so 8
> channels for ad7124-4 and 16 for ad7124-8.
>
> This patch removes the check between channel nodes and num_inputs
> value.
>
> Signed-off-by: Mircea Caprioru <mircea.caprioru@analog.com>
> ---
> drivers/iio/adc/ad7124.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/iio/adc/ad7124.c b/drivers/iio/adc/ad7124.c
> index 659ef37d5fe8..810234db9c0d 100644
> --- a/drivers/iio/adc/ad7124.c
> +++ b/drivers/iio/adc/ad7124.c
> @@ -462,13 +462,6 @@ static int ad7124_of_parse_channel_config(struct
> iio_dev *indio_dev,
> if (ret)
> goto err;
>
> - if (ain[0] >= st->chip_info->num_inputs ||
> - ain[1] >= st->chip_info->num_inputs) {
> - dev_err(indio_dev->dev.parent,
> - "Input pin number out of range.\n");
> - ret = -EINVAL;
> - goto err;
> - }
> st->channel_config[channel].ain =
> AD7124_CHANNEL_AINP(ain[0]) |
> AD7124_CHANNEL_AINM(a
> in[1]);
> st->channel_config[channel].bipolar =
Please ignore this patch serie, just did a RESEND.
Thanks,
Mircea
prev parent reply other threads:[~2019-06-20 10:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 9:19 Mircea Caprioru
2019-06-20 9:19 ` [PATCH 2/4] iio: adc: ad7124: Add buffered input support Mircea Caprioru
2019-06-20 9:19 ` [PATCH 3/4] iio: adc: ad7124: Shift to dynamic allocation for channel configuration Mircea Caprioru
2019-06-20 9:19 ` [PATCH 4/4] dt-bindings: iio: adc: Convert ad7124 documentation to YAML Mircea Caprioru
2019-06-20 10:30 ` Caprioru, Mircea [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0183e4e49732e3de44fe9229c45764b307af8838.camel@analog.com \
--to=mircea.caprioru@analog.com \
--cc=Michael.Hennerich@analog.com \
--cc=StefanSerban.Popa@analog.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®