From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751210AbbJELgi (ORCPT ); Mon, 5 Oct 2015 07:36:38 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:22144 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750781AbbJELgh (ORCPT ); Mon, 5 Oct 2015 07:36:37 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-73-561260c2808d From: Pavel Fedin To: "'Pankaj Dubey'" , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: thomas.ab@samsung.com, k.kozlowski@samsung.com, kgene@kernel.org, heiko@sntech.de References: <1440403348-8974-1-git-send-email-pankaj.dubey@samsung.com> In-reply-to: <1440403348-8974-1-git-send-email-pankaj.dubey@samsung.com> Subject: RE: [PATCH v2 0/7] Add support for Exynos SROM Controller driver Date: Mon, 05 Oct 2015 14:36:32 +0300 Message-id: <018501d0ff62$1650b410$42f21c30$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: AQG13x99tKvb5gCon/JqZ+EwhdtfMJ6TBJ8Q Content-language: ru X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrPLMWRmVeSWpSXmKPExsVy+t/xq7qHEoTCDNq2sVv8f/Sa1eL1C0OL /sevmS02Pb7GanF51xw2ixnn9zFZLNr6hd2iYxmjA4fHplWdbB6bl9R79G1Zxeix/do8Zo/P m+QCWKO4bFJSczLLUov07RK4MtrWFBQ8Z6/YsPoHYwPjcrYuRk4OCQETiWVP/7BD2GISF+6t B4pzcQgJLGWUuHRpJwtIQkjgO6NE9w2wBjYBdYnTXz+wgBSJCMxglLh9bhJYN7NAuETXjU1s EA3uEu83TgCzOQU8JO5NnsrcxcjBISzgKbHgbgRImEVAVeLd7GtMIDavgKXEs+fP2SFsQYkf k++xQIzUkli/8zgThC0vsXnNW2aIQxUkdpx9zQgyUkTASOL8J0aIEhGJaf/uMU9gFJqFZNIs JJNmIZk0C0nLAkaWVYyiqaXJBcVJ6bmGesWJucWleel6yfm5mxgh0fJlB+PiY1aHGAU4GJV4 eA/EC4YJsSaWFVfmHmKU4GBWEuG1dBUKE+JNSaysSi3Kjy8qzUktPsQozcGiJM47d9f7ECGB 9MSS1OzU1ILUIpgsEwenVANjPGPK39BZFvrvp1/ZZH1ubZ3T9K1qAmsrbx0OkzvKWGSyv8k4 taW1av2WrE22f6Q1L4pdbI5buuzQhKCKZ//P6Gu5iVrb3Xn0omz1DHPWi/vLjLWZV3NOXVL7 QVpcfZ34zPdMzbElXV4H8nN0NZsDDl/hm+G9Rqvt3LJTXtHn3cLvFU2q71mkxFKckWioxVxU nAgAAYccTJICAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello! > This patch set adds support for Exynos SROM controller DT based driver. > Currently SROM register sets are used only during S2R, so driver > basically added for taking care of S2R. It will help us in removing > static mapping from exynos.c and other extra code handline during S2R. Very good news, but, your driver seems not to do anything except suspend/resume. But how do i add some device plugged into it? In order to be operational, its outputs have to be configured. But how do i do it with your driver? For example, on SMDK boards SROM controller is used to connect SMSC9111 etherner chip. Currently i use hardcoded initialization based on of_machine_is_compatible(), but i believe this would be considered a hack and such a thing cannot be pushed upstream. I guess i have to put all needed configuration into device tree somehow. But how? Are there any recommentations? Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia