From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0AFF53E4C63 for ; Thu, 23 Apr 2026 09:23:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776936218; cv=none; b=obyxh7/Nq8SUGZG+XYFgGzy+F62BnvZfbqo+IkqrnyBrjNjsHM6mH7pPak9/a9DsrE4XfRPlvw5l/dbijX58C1js6LyOX7DF1Q/cWrE4+ZAIP4AjtpRy30p+95YlvjkI2laGrayHWyr1jeaUuK/et+Luta71QOghwDfhEhKbOq8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776936218; c=relaxed/simple; bh=53ennj+hj5rWSokWbGEQbLWHb/17dqpf2YXvQKqdVmk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jWPWx7e0aOgCNjPRUmkVYnNzzljvO9XNcGLOlc3bv1Nav4x4Ltexoy1Gs+htGZQXoIJk0ANdPukJvzeuFkvRKLB2nD9OFM2fRA9+phsDsdL4OPxrxyrPINuDYRqiw7EeAKw3az6IZRBpy6tsOdmGfJmrhYvKPaMUTyUsKsTWQF4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=nnSAa6JA; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nnSAa6JA" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-488a9033b2cso71070515e9.2 for ; Thu, 23 Apr 2026 02:23:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1776936215; x=1777541015; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pL1SbrFnD2hMqCJhJcMRGY0Wdq8twCe13/ZvMTtbqsQ=; b=nnSAa6JAkMlO9I+eelz2YY2WvP1fN6LDHtLdH6OLt3luUoJe7UnBphiQt2IYRiotgS rjpGCh7kc90cyQdZ7XpF2QtVhsHEkG2hnZMBN7RgRqhUQaRuDxa36SUr4z5MSi4cAZlC Dv4ZNggdFkO+tXFiAMd7P8n2lSUH8rGDpByGD5Cwygy4XytJT+UPgUbegZL40iHH++5R DJA7fY6Q8dMxqF/cZo5IiR0rUDzXfBBuKbQ9rAo63Y20uhUbgtSibPBJx+t+qXALqdy/ jO0v88MJRa7dZ1oMPmQr88llgf0BdCJDvZKk741t/0/gQZ11OKpET728URYKD7MarIX8 Xg3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776936215; x=1777541015; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pL1SbrFnD2hMqCJhJcMRGY0Wdq8twCe13/ZvMTtbqsQ=; b=RiwlqKuYEVRoOpRyVb2QRmmU2bX2wrgFD09atT0nWgppcDytMiae4A4n/wyNH8FOA4 VXnHmSDpbm/0gCCLH9mIp8oB8vLNpWRK9MasiVHwnHmPbx5+G3/Jw8RamLydvnRLbtsp 6CdPbxBaW9tSuo/WIpwU5kiv4PsYdKi5AXoy9xImE9IKHEUnFF2U4WFfZ2VvD5cHKdJO HsZ53TTyy/W3slFhHrmxamhFtP+N1g6POLsR2vmqP1f454XWE+E1cUP8HaIEj0RBeLb5 meNoF+El9Q1dE/s04R9PRbycVjPkJnhiw1ubF4yXn5adAqL0noS/fyHFkWNJeOyYzOWV sgUw== X-Forwarded-Encrypted: i=1; AFNElJ9b/PUkitAIf9gn6W3Gy6et3Ft+hnI/ASZFA7f2Q07VO8vyUpGcsXYBWAYOMj9H/vP28DZfF0/zREI++6U=@vger.kernel.org X-Gm-Message-State: AOJu0YzyVq6jh0C8iwsnX6tR0SKlRVrMgziKOWTg0YcHx7eEIkLFMw4x 9Y692vj2h3+rSRsze5Z/GtER65XXz1HR4viHA/qVvVsEFTU6c+/tsYC+3I26J3aYtQ0= X-Gm-Gg: AeBDies8TAEQ2y1kw393AGNwvzGvnaoaEtmsM/8gs5ufVGxcaugIKn8lEMFzgP+wU71 zQCC/6QnnSITqzi0f7QYqglAQRk4IbdWyZVNbxZJXwcfhGikNVl81DyaB57SDACONs84iKiWV2+ qEit/LOLWIC+sRdyOm4BcQR0TNJrmRRxI+CTy0+hNl4ud0v4GS+23oB+c72onMNuIm45wrljCKp GDMWMh9nLlRaofm4ba3ize+fe4Z3hx5SijYAT6WnCBVm7pZOKYdHetyi9JxtvZxMuxyQaCnikAP k4XBEa/OMl6x/nimObevul0Mxnoe4gck3/bYN3igbtUaIYJAHXXoFhv2KIA50bzjYtdaUHsll02 y3DAYrDJ9WaDym4KWV69F5lpSxwDE61NkeFWUmswqdExeqKBJaWvOVEQbUmnuRIq/AHec4rp5ZU b8tzNEHet9WnubcuEP05xtAjIr2w+sM3f6p8HncEGstsXpd1yW5l+HK7U= X-Received: by 2002:a05:600c:5246:b0:487:219e:42d with SMTP id 5b1f17b1804b1-488fb750a1dmr369865355e9.11.1776936215211; Thu, 23 Apr 2026 02:23:35 -0700 (PDT) Received: from [192.168.0.167] ([109.77.41.87]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a5d27d6casm20573705e9.27.2026.04.23.02.23.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Apr 2026 02:23:34 -0700 (PDT) Message-ID: <01851aef-6198-4fc7-8707-eca66bfab63f@linaro.org> Date: Thu, 23 Apr 2026 10:23:33 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/7] media: qcom: iris: Fix bitmask test in iris_allow_cmd() To: Dikshita Agarwal , Vikash Garodia , Abhinav Kumar , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Deepa Guthyappa Madivalara Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue References: <20260422-iris-code-improvement-v1-0-8e150482212d@oss.qualcomm.com> <20260422-iris-code-improvement-v1-3-8e150482212d@oss.qualcomm.com> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: <20260422-iris-code-improvement-v1-3-8e150482212d@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 22/04/2026 12:16, Dikshita Agarwal wrote: > iris_allow_cmd() incorrectly tests a single sub‑state bit using a scalar > comparison I don't think scalar is the right term here. You're changing logical comparison to bit-wise comparison. Otherwise Reviewed-by: Bryan O'Donoghue --- bod