From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751807AbbIOIVU (ORCPT <rfc822;w@1wt.eu>);
	Tue, 15 Sep 2015 04:21:20 -0400
Received: from mail113-250.mail.alibaba.com ([205.204.113.250]:37087 "EHLO
	us-alimail-mta1.hst.scl.en.alidc.net" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1751438AbbIOIVS (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 15 Sep 2015 04:21:18 -0400
X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R501e4;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e02c03276;MF=hillf.zj@alibaba-inc.com;NM=1;PH=DS;RN=3;SR=0;
Reply-To: "Hillf Danton" <hillf.zj@alibaba-inc.com>
From: "Hillf Danton" <hillf.zj@alibaba-inc.com>
To: "'Daniel Thompson'" <daniel.thompson@linaro.org>
Cc: "'linux-kernel'" <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>
References: <016701d0ef82$c303d6a0$490b83e0$@alibaba-inc.com> <017001d0ef83$e18a5d00$a49f1700$@alibaba-inc.com> <55F7D291.5090509@linaro.org>
In-Reply-To: <55F7D291.5090509@linaro.org>
Subject: RE: [PATCH] arm: Fix backtrace generation when IPI is masked
Date: Tue, 15 Sep 2015 16:20:30 +0800
Message-ID: <018c01d0ef8f$62c8c130$285a4390$@alibaba-inc.com>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="utf-8"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Outlook 14.0
Thread-Index: AQFT9AKCQQbGB4ZDSA8woPqUCBbjNQKwvns3AaLEF0CfFJpH8A==
Content-Language: zh-cn
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> > Better if dump_stack() is added in a separate patch, given that
> > it is not mentioned in commit message.
> 
> Adding dump_stack() is mentioned in passing ("Some small changes to the
> generic code are required to support this.") but you're right that the
> reason for the change is not explicitly called out.
> 
> I can certainly respin as two patches but perhaps its better just to
> improve the commit message. Something like:
> 
>  > This can be fixed by detecting that the calling context cannot be
>  > preempted and issuing the backtrace directly in this case. Issuing
>  > directly leaves us without any pt_regs to pass to nmi_cpu_backtrace().
>  > Modify the generic code to call dump_stack() when its argument is
>  > NULL.
> 
Looks nice!

thanks
Hillf