From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761042AbdADQi6 (ORCPT ); Wed, 4 Jan 2017 11:38:58 -0500 Received: from mail-wj0-f193.google.com ([209.85.210.193]:36598 "EHLO mail-wj0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751052AbdADQix (ORCPT ); Wed, 4 Jan 2017 11:38:53 -0500 Subject: Re: [PATCH v4 04/15] mtd: nand: rename nand_get_flash_type() into nand_detect() To: Boris Brezillon , Richard Weinberger , linux-mtd@lists.infradead.org References: <1483448495-31607-1-git-send-email-boris.brezillon@free-electrons.com> <1483448495-31607-5-git-send-email-boris.brezillon@free-electrons.com> Cc: David Woodhouse , Brian Norris , Cyrille Pitchen , Icenowy Zheng , Valdis.Kletnieks@vt.edu, linux-kernel@vger.kernel.org From: Marek Vasut Message-ID: <018e0948-a867-ac4d-2414-38038e1cbb20@gmail.com> Date: Wed, 4 Jan 2017 16:01:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 In-Reply-To: <1483448495-31607-5-git-send-email-boris.brezillon@free-electrons.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/03/2017 02:01 PM, Boris Brezillon wrote: > The only caller of nand_get_flash_type() (nand_scan_ident()) actually > don't use the returned nand_flash_dev pointer except for converting it to > to an error code. > Rename this function nand_detect() and make it return an integer. Ummmm, it did return an integer before though ? The commit message is kinda cryptic, really. > Signed-off-by: Boris Brezillon > --- > drivers/mtd/nand/nand_base.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c > index 3a31b705af6f..efb3ade568d8 100644 > --- a/drivers/mtd/nand/nand_base.c > +++ b/drivers/mtd/nand/nand_base.c > @@ -4010,8 +4010,7 @@ static bool find_full_id_nand(struct nand_chip *chip, > /* > * Get the flash and manufacturer id and lookup if the type is supported. > */ > -static int nand_get_flash_type(struct nand_chip *chip, > - struct nand_flash_dev *type) > +static int nand_detect(struct nand_chip *chip, struct nand_flash_dev *type) > { > struct mtd_info *mtd = nand_to_mtd(chip); > int busw; > @@ -4368,7 +4367,7 @@ int nand_scan_ident(struct mtd_info *mtd, int maxchips, > nand_set_defaults(chip); > > /* Read the flash type */ > - ret = nand_get_flash_type(chip, table); > + ret = nand_detect(chip, table); > if (ret) { > if (!(chip->options & NAND_SCAN_SILENT_NODEV)) > pr_warn("No NAND device found\n"); > -- Best regards, Marek Vasut