From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753724AbdCOLnW (ORCPT ); Wed, 15 Mar 2017 07:43:22 -0400 Received: from lelnx193.ext.ti.com ([198.47.27.77]:50957 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753173AbdCOLmj (ORCPT ); Wed, 15 Mar 2017 07:42:39 -0400 Subject: Re: [PATCH] serial: 8250: 8250_core: Use dev_name() during request_irq() To: Andy Shevchenko References: <20170308121943.29340-1-vigneshr@ti.com> <2a0cf043-6e3f-6807-0794-d9d6f46b77f5@ti.com> CC: Greg Kroah-Hartman , Jiri Slaby , "linux-serial@vger.kernel.org" , "linux-kernel@vger.kernel.org" , linux-arm Mailing List From: Vignesh R Message-ID: <01911ed2-d64b-6f81-5ca2-7efa9b63d70f@ti.com> Date: Wed, 15 Mar 2017 17:12:17 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 14 March 2017 09:29 PM, Andy Shevchenko wrote: > On Tue, Mar 14, 2017 at 3:44 PM, Vignesh R wrote: >> On Monday 13 March 2017 01:35 AM, Andy Shevchenko wrote: >>> On Wed, Mar 8, 2017 at 2:19 PM, Vignesh R wrote: >>>> Passing "serial" as name during request_irq() results in all serial port >>>> irqs have same name. This does not help much to easily identify which >>>> irq belongs to which serial port instance. Therefore pass dev_name() >>>> during request_irq() so that better identifiable name is listed for >>>> serial ports in cat /proc/interrupts output. >>>> >>>> Output of cat /proc/interrupts >>>> Before this patch: >>>> 26: 689 0 GICv2 309 Edge serial >>>> After this patch: >>>> 26: 696 0 GICv2 309 Edge 2530c00.serial > >> But, this change is making interrupt name more descriptive > > It doesn't in PCI case, it makes it worse. > > (The world is not DT-centric) > >>> Besides that imagine what would be the name of PCI device here. >>> I would suggest adding ID if you need one in a form like >>> "serial%d", where ID may or may not be supplied by the actual 8250 drivers. >>> >> >> Are you suggesting to use serial_index() as ID? > > Yes. > Ok thanks, I will send on incremental fix as this patch is already applied. -- Regards Vignesh