From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A572C433E0 for ; Fri, 12 Feb 2021 10:24:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1236D64E65 for ; Fri, 12 Feb 2021 10:24:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230469AbhBLKYj (ORCPT ); Fri, 12 Feb 2021 05:24:39 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:42278 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230150AbhBLKYe (ORCPT ); Fri, 12 Feb 2021 05:24:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613125361; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r4CbtXLdEFF6nW7YkQkQgLv+lYmFaX3damrF89lHHB8=; b=gMdBb7vIjmc8Mw0oBvnDt4lu7+9kpspEcG/8imNumDqq9bAqJdfnMlU8SVHhRX1xRk53mr DMb9Fqp4YXSPiQlsbeqqKNFPv9hmcCHu9PA9uhCHV5zcORTh6nHwhF8wLExEeOIvNZoIc8 Gdo0WPFUP7D6Z31l0uvt3uEYCokmYj8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-571-JO9ONT6qOS2ulcwdPpnldg-1; Fri, 12 Feb 2021 05:22:37 -0500 X-MC-Unique: JO9ONT6qOS2ulcwdPpnldg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4425A8799E0; Fri, 12 Feb 2021 10:22:36 +0000 (UTC) Received: from [10.36.114.178] (ovpn-114-178.ams2.redhat.com [10.36.114.178]) by smtp.corp.redhat.com (Postfix) with ESMTP id DC63410016F9; Fri, 12 Feb 2021 10:22:34 +0000 (UTC) Subject: Re: This reply comments on the patch to fixes the missing a blank line warning From: David Hildenbrand To: Adithya Chandrakasan , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org References: <20210211072918.376837-1-adithya.chandrakasan@gmail.com> <3512c272-dbec-2c0a-4476-203315341fe2@gmail.com> <35cbe08d-6c29-c904-1402-de18b787c5b0@redhat.com> Organization: Red Hat GmbH Message-ID: <0192c01f-4f90-7a58-ce12-b753495fec8c@redhat.com> Date: Fri, 12 Feb 2021 11:22:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <35cbe08d-6c29-c904-1402-de18b787c5b0@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12.02.21 11:14, David Hildenbrand wrote: > On 11.02.21 19:20, Adithya Chandrakasan wrote: >> On 2/11/21 2:36 AM, David Hildenbrand wrote: >>> ^ >>> >>> Please create proper patch subjects. Nobody has a glue what you are doing when looking at the subject. >>> >>> "mm/util: fix ??? warning" >>> >>> Which raises the question, what is ??? >>> >>> Compiler? static code checker? ... ? >>> > > > >>> >>> Thanks >>> >>> On 11.02.21 08:29, Adithya Chandrakasan wrote: >>>> FILE: mm/util.c:930: WARNING: Missing a blank line after declarations >>>> >>>> Signed-off-by: Adithya Chandrakasan >>>> --- >>>>    mm/util.c | 1 + >>>>    1 file changed, 1 insertion(+) >>>> >>>> diff --git a/mm/util.c b/mm/util.c >>>> index 8c9b7d1e7c49..60286876636d 100644 >>>> --- a/mm/util.c >>>> +++ b/mm/util.c >>>> @@ -927,6 +927,7 @@ int get_cmdline(struct task_struct *task, char *buffer, int buflen) >>>>        unsigned int len; >>>>        struct mm_struct *mm = get_task_mm(task); >>>>        unsigned long arg_start, arg_end, env_start, env_end; >>>> + >>>>        if (!mm) >>>>            goto out; >>>>        if (!mm->arg_end) >>>> >>> >>> >> Hi David, >> >> Thanks for feedback. I have fixed the issues in the patch thread with >> change in subject and also log message. > > Hi, > > Please always send patches via proper mails and versioned. > > E.g., > > rm *.patch > git format-patch -1 -v2 > git send-email --to ... *.patch > > > The introducing patch is from 2014. So I wonder how you even get a > checkpatch warning? > > a90902531a06a ("proc read mm's {arg,env}_{start,end} with mmap semaphore > taken.") Sorry wrong pointer, it's from 2014 a90902531a06 ("mm: Create utility function for accessing a tasks commandline value") -- Thanks, David / dhildenb