From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752113AbbEDCx1 (ORCPT ); Sun, 3 May 2015 22:53:27 -0400 Received: from mail113-249.mail.alibaba.com ([205.204.113.249]:33092 "EHLO us-alimail-mta1.hst.scl.en.alidc.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751640AbbEDCxU (ORCPT ); Sun, 3 May 2015 22:53:20 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R101e4;FP=0|-1|-1|-1|0|-1|-1|-1;HT=r41g03043;MF=hillf.zj@alibaba-inc.com;PH=DS;RN=4;RT=4;SR=0; Reply-To: "Hillf Danton" From: "Hillf Danton" To: "'Laura Abbott'" Cc: "'Russell King'" , "'linux-kernel'" , References: <042801d066b3$0ca78a30$25f69e90$@alibaba-inc.com> <5543C529.4080203@labbott.name> In-Reply-To: <5543C529.4080203@labbott.name> Subject: [patch] ARM: fix module-bound check in setting page attributes Date: Mon, 04 May 2015 10:52:31 +0800 Message-ID: <019401d08615$5e093000$1a1b9000$@alibaba-inc.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQKWkNKu4FurPqc1WAFJ+6S68oSOowHpVX6Sm8+6L9A= Content-Language: zh-cn Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It was introduced in commit f2ca09f381a59 (ARM: 8311/1: Don't use is_module_addr in setting page attributes) We have no need to check start twice, but see if end is also in range. Signed-off-by: Hillf Danton Acked-by: Laura Abbott --- --- a/arch/arm/mm/pageattr.c Mon May 4 10:33:49 2015 +++ b/arch/arm/mm/pageattr.c Mon May 4 10:35:32 2015 @@ -52,7 +52,7 @@ static int change_memory_common(unsigned if (start < MODULES_VADDR || start >= MODULES_END) return -EINVAL; - if (end < MODULES_VADDR || start >= MODULES_END) + if (end < MODULES_VADDR || end >= MODULES_END) return -EINVAL; data.set_mask = set_mask; --