From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751457AbdH0UK3 (ORCPT ); Sun, 27 Aug 2017 16:10:29 -0400 Received: from mout.web.de ([217.72.192.78]:51628 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751294AbdH0UK2 (ORCPT ); Sun, 27 Aug 2017 16:10:28 -0400 To: linux-leds@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Benjamin Herrenschmidt , Jacek Anaszewski , Michael Ellerman , Paul Mackerras , Pavel Machek , Richard Purdie From: SF Markus Elfring Subject: [PATCH] leds-PowerNV: Delete an error message for a failed memory allocation in powernv_led_create() Cc: LKML , kernel-janitors@vger.kernel.org Message-ID: <019499e0-68d8-b89d-f5d6-6aefd9cbaf04@users.sourceforge.net> Date: Sun, 27 Aug 2017 22:10:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:YhRBFjl+M200bpeh8dagQrpz5DJqQi1AtpTdR1UzuxBygS5jZ4j nYAh8NjkUHazD35eLDDwynJQT4laKUXdpeOC1EKsG4N65TKbe5QXCYs8fB5TfJdWhngW7eP AOjMk350gpXZRXhzGkHUVybLHClYW00lEqvUCPX22+/yboohut9/GajZJushZvP4hxwUXkC dmiGwCs/eCK042rqzP3dw== X-UI-Out-Filterresults: notjunk:1;V01:K0:QwxlA7Rm/L8=:c82B9W4Lqg/iUkFVYLBl6D NG3NSQdTl3ctt2hGNdLoEzGK+ryu5C12kMAh39g4Rdb5DkQPse22/zQ88a0ws3CljliQ4oBp9 xk/a84X+NQAI73z+AvGApnSHje0wMeMz8zxOagcto0rkhVTTCmavyeRMzXKO0G1Y2J7D3CpvA JcUR6hB6mvWgvCoB7eUPUbkKoLqzKGjUqrr9EEuC0sGepZ4DsBZffIjPNUnI+jlfTW86+Ri7G joN0s0rI+PmAgUOK+gko80V4enHXZg/ke2MzuQ7/vZO+0PfcPnDfacSRGDildkjTYxd+kj31y Qpf8aX5A3z892WKAx+N1gpxr261TVbnwKFwVSkQp39DtDE9N9igPL0PoFF5kCcaO3DWxaOKNG oxpz58iwBDaFRltrPlrS0OeZT7MEDjJ7CuTKfUL78A+dETXwpUeHg3UGJzpIIrV8kRqxWNANs 8wZGjLNcJhFbRSbjCxfuGeg5xDpw92KA+T82b20yo8aCcCoi/PIvyf32+UmU5T4aGYflx4dsI usaa6S4ZpUSrO5Il/NDDPFWmPaRtNsFx73DNf/Ya+00hnxCSZrRtIqe0Lgo85hiyLurBxEUao IJOjMNUhax4XNEjiav8ZcuPB0vz+Vw9FBcuKi5gzEuMs2TQz8Pvw2cVf5zGsuAD9cJGP0l+U8 12AmzaKuBpe3l41tkl97pNFcAlw/VeWomtgIJl32rXwaFL9H3AzlNpDdKlCt7cWtn6x0AYgsT GdzvYvxbuqZE/AFl4jjX1QgPIgujHK3XonUNsr2I5YObea4CNZC/o6cDFTQ7Hhc4Vjp2TAFlQ sBZt46yNbIXEJ+B+G4CaCjP3hDVsllEbxuRPfuh9qnXsfBqnEs= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sun, 27 Aug 2017 22:00:22 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/leds/leds-powernv.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/leds/leds-powernv.c b/drivers/leds/leds-powernv.c index b2a98c7b521b..b1adbd70ce2e 100644 --- a/drivers/leds/leds-powernv.c +++ b/drivers/leds/leds-powernv.c @@ -224,12 +224,8 @@ static int powernv_led_create(struct device *dev, powernv_led->cdev.name = devm_kasprintf(dev, GFP_KERNEL, "%s:%s", powernv_led->loc_code, led_type_desc); - if (!powernv_led->cdev.name) { - dev_err(dev, - "%s: Memory allocation failed for classdev name\n", - __func__); + if (!powernv_led->cdev.name) return -ENOMEM; - } powernv_led->cdev.brightness_set_blocking = powernv_brightness_set; powernv_led->cdev.brightness_get = powernv_brightness_get; -- 2.14.1