From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87CC3C433F5 for ; Tue, 31 May 2022 18:11:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346843AbiEaSLp (ORCPT ); Tue, 31 May 2022 14:11:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50770 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237803AbiEaSLm (ORCPT ); Tue, 31 May 2022 14:11:42 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 204691E5 for ; Tue, 31 May 2022 11:11:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654020698; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XMQEK/kjTo0pUfkHM6FfBJm4lgYJdNQsWtCnnztaaGk=; b=KqHpJdly/rKBYvG61fz15rHLuZYzQwflK+ObDFoB7V5Ucug2C7Y0ztm1d3TMS+iSs0TAWp qB+lpaZMhTM8+ouWszifUMPmPKxbIoS9j6xRrmfA1PBS7NoTCFBUJ6AvG/1kmlhC2aDMpT 4Sww2SccVf5tUX9alCDednjizazQPMQ= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-663-0Qq93t4iOReclPsLUOWmQQ-1; Tue, 31 May 2022 14:11:36 -0400 X-MC-Unique: 0Qq93t4iOReclPsLUOWmQQ-1 Received: by mail-ed1-f71.google.com with SMTP id o17-20020a50fd91000000b0042dbded81deso6714971edt.0 for ; Tue, 31 May 2022 11:11:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:cc:references:from:subject:in-reply-to :content-transfer-encoding; bh=XMQEK/kjTo0pUfkHM6FfBJm4lgYJdNQsWtCnnztaaGk=; b=AqKurfePNwfH5nUd7XgjJwaXDJAVdZA4DNHd6dQZDAkT9dJsqVumddyjxD/tmIr8Oi ZD6THSqZAgBRcVF/828et2eyOdOzjVz1g4gD2UcF016Z67byxxx6Ct7nW0gBxJUSOPrt +uMFwElbVhIPHLXRF4KIWQ1T2aJw7C5EmMEM3t4/tB/pojP1INQNHZmYTRnoDc1W1BV4 xapSI5kmvQvlXzpA3y82H5mHAgVX1GubwI/2Qp5s6t6WwdjarmRpysH6hEhZvStmdZ4O msvYu2HPSYa8j6JaVZB57Sby3mk2e5qwU8LUDX05Br2IqCgTwOqO3nhyVu8tf+ZHunWn 36Dg== X-Gm-Message-State: AOAM532hODZFJPHLdllD/0x9IKlDuM2+f0KEQAXZhLy3LWM0g2j7dR12 4p1x28OcA6Ow2+ngiOHO/PmXe+fijLYcn6MGqO5tT0TYLd02jY6Cu83eeGjkNCHyaqYmSbSWbnT 0Wwsj4awdtpqsFtA/hRD94c39 X-Received: by 2002:a17:906:6a0d:b0:6ff:15a8:acbf with SMTP id qw13-20020a1709066a0d00b006ff15a8acbfmr27459124ejc.143.1654020695314; Tue, 31 May 2022 11:11:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy1ff2p+ikBQ55Lof6tEFQQIwQKvq0MZaz2IlORv4sb3mJO9fUCPL0TZ2jkvbnDaJnhq6pOwA== X-Received: by 2002:a17:906:6a0d:b0:6ff:15a8:acbf with SMTP id qw13-20020a1709066a0d00b006ff15a8acbfmr27459105ejc.143.1654020695066; Tue, 31 May 2022 11:11:35 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:9af8:e5f5:7516:fa89? ([2001:b07:6468:f312:9af8:e5f5:7516:fa89]) by smtp.googlemail.com with ESMTPSA id z5-20020a1709060ac500b00702d8b37a03sm740362ejf.17.2022.05.31.11.11.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 May 2022 11:11:34 -0700 (PDT) Message-ID: <0194b22a-38a1-08a1-a576-de6463389ce4@redhat.com> Date: Tue, 31 May 2022 20:11:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Content-Language: en-US To: Metin Kaya , jalliste@amazon.com Cc: bp@alien8.de, diapop@amazon.co.uk, hpa@zytor.com, jmattson@google.com, joro@8bytes.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, mingo@redhat.com, rkrcmar@redhat.com, sean.j.christopherson@intel.com, tglx@linutronix.de, vkuznets@redhat.com, wanpengli@tencent.com, x86@kernel.org References: <20220531105925.27676-1-jalliste@amazon.com> <20220531114333.29153-1-metikaya@amazon.co.uk> From: Paolo Bonzini Subject: Re: [PATCH] KVM: VMX: CPU frequency scaling for intel x86_64 KVM guests In-Reply-To: <20220531114333.29153-1-metikaya@amazon.co.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/31/22 13:43, Metin Kaya wrote: > Thanks, Jack. > > Reviewed-by: Metin Kaya > Please try a bit harder. "Reviewed-by" is neither "this matches what's been forever in the Amazon kernel" nor "I guarantee that Jack is a nice guy and doesn't screw up". I'm sure he is but everybody screws up, and in this case the patch: - does not even *apply* to the upstream kernel, because it uses (presumably Amazon-specific) CAP numbers above 10000 - does not work if the vCPU is moved from one physical CPU to another - does not work if the intel_pstate driver writes to MSR_HWP_REQUEST - does not include documentation for the new capability - does not include a selftest - is unacceptable anyway because, as mentioned in the cover letter, it isn't undone when the process exits Jack, please understand that I am not really blaming you in any way, and ask some of your colleagues with upstream kernel experience (Alex Graf, David Woodhouse, Filippo Sironi, Jan Schoenherr, Amit Shah are the ones I know) which patches could be good targets for including upstream. Paolo