From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BACA8C3A5A6 for ; Sat, 31 Aug 2019 08:57:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 94E3F2342E for ; Sat, 31 Aug 2019 08:57:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727911AbfHaI5l (ORCPT ); Sat, 31 Aug 2019 04:57:41 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:6156 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726102AbfHaI5l (ORCPT ); Sat, 31 Aug 2019 04:57:41 -0400 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id B80689698DBCC816583C; Sat, 31 Aug 2019 16:57:36 +0800 (CST) Received: from [127.0.0.1] (10.74.191.121) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.439.0; Sat, 31 Aug 2019 16:57:29 +0800 Subject: Re: [PATCH v2 7/9] sparc64: numa: check the node id consistently for sparc64 To: David Miller CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , References: <1567231103-13237-1-git-send-email-linyunsheng@huawei.com> <1567231103-13237-8-git-send-email-linyunsheng@huawei.com> <20190830.235337.570776316111294728.davem@davemloft.net> From: Yunsheng Lin Message-ID: <0195eb73-99ae-fec2-3e11-2cb9e6677926@huawei.com> Date: Sat, 31 Aug 2019 16:57:04 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <20190830.235337.570776316111294728.davem@davemloft.net> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.74.191.121] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/8/31 14:53, David Miller wrote: > From: Yunsheng Lin > Date: Sat, 31 Aug 2019 13:58:21 +0800 > >> According to Section 6.2.14 from ACPI spec 6.3 [1], the setting >> of proximity domain is optional, as below: > > What in the world does the ACPI spec have to do with sparc64 NUMA > node ID checking? I am not sure I understand your question fully here. Here is my issue when the bios does not implement the proximity domain of a device because the feature is optional according to the ACPI spec, the dev_to_node(dev) return -1, which causes out of bound access when using the value to get the device's cpu mask by calling cpumask_of_node. Did you mean sparc64 system does not has ACPI, the device's node id will not specified by ACPI, so the ACPI is unrelated here? Or did you mean the commit log is not clear enough to justify the change? Or did you mean this problem should be fixed in somewhere else? Any detail advice and suggestion will be very helpful, thanks. > > . >