From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753704Ab1C2Oym (ORCPT ); Tue, 29 Mar 2011 10:54:42 -0400 Received: from mprc.pku.edu.cn ([162.105.203.9]:46821 "EHLO mprc.pku.edu.cn" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753494Ab1C2Oyk (ORCPT ); Tue, 29 Mar 2011 10:54:40 -0400 From: "Guan Xuetao" To: "'Arnd Bergmann'" Cc: "'Paul Mundt'" , , References: <019701cbee1e$c4e2d260$4ea87720$@mprc.pku.edu.cn> <201103291642.49555.arnd@arndb.de> In-Reply-To: <201103291642.49555.arnd@arndb.de> Subject: RE: [PATCH] unicore32 framebuffer driver fix: make videomemory kmalloc-ed and floatable Date: Tue, 29 Mar 2011 22:54:27 +0800 Message-ID: <019a01cbee21$341d2d90$9c5788b0$@mprc.pku.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQIFvKgm+ycIK6IzhVqIuzAjQEIKYgHgnBR1k8HC7iA= Content-Language: zh-cn Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Arnd Bergmann [mailto:arnd@arndb.de] > Sent: Tuesday, March 29, 2011 10:43 PM > To: Guan Xuetao > Cc: Paul Mundt; linux-kernel@vger.kernel.org; linux-fbdev@vger.kernel.org > Subject: Re: [PATCH] unicore32 framebuffer driver fix: make videomemory kmalloc-ed and floatable > > On Tuesday 29 March 2011, Guan Xuetao wrote: > > > > 1. make videomemory kmalloc-ed in fb-puv3.c > > 2. remove resource reservation for old fixed UNIGFX_MMAP & UVC_MMAP space > > 3. remove unused PKUNTIY_UNIGFX_MMAP_BASE, PKUNITY_UNIGFX_MMAP_SIZE, > > PKUNITY_UVC_MMAP_BASE, PKUNITY_UVC_MMAP_SIZE and KUSER_UNIGFX_BASE > > 4. remove unused header linux/vmalloc.h in fb-puv3.c > > > > Signed-off-by: Guan Xuetao > > How does this work? UNIFB_MEMSIZE seems to be 4 MB, much more than the > maximum of 128 KB that kmalloc can allocate. I'm surprised. But kmalloc() returns success with 0xc7000000. > > Shouldn't this use get_free_pages() instead of kmalloc? I will check and correct it. > > Arnd Thanks. Guan Xuetao