From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42ABC3BB5A for ; Tue, 21 Apr 2026 02:03:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776737022; cv=none; b=D3+2hprzP2fWIU3/NR3CxwxP1elkMqRu6out4RD8gL6AUFh6Y+JttbKP/3JRxlbDwNkRrbTZqPXeapb2n1Be0zypajy5732wr7/LV8VzP+vuwrna7pstQFjoc50h6A7OjOCcBnS2psQUhwirEPZZLRjG4z+wS1tM4QvAsYRUJmU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776737022; c=relaxed/simple; bh=/Dv8cvp4dyydKcDv8Uj6PeNSb/LTw5WxdHCmfDaVWQA=; h=Date:From:To:CC:Subject:In-Reply-To:References:Message-ID: MIME-Version:Content-Type; b=qWMOjNDRKkbjft5QERG+EgdVh1P4LD3XuqJpOmE4vNJMqZJBwenhFz8vno8GjN7gbrFRMbv8MPo9v5GEGYQ1jwbfxJ1W+A5sZJPB7owxhbyARyvk44qLNtlCeTSZwrkiHY4B5O49aHQxtmxJnl9rlHv8QDGaBW+3IDb/ubU3N/Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=q4OlvWCY; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="q4OlvWCY" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-82748257f5fso2512588b3a.1 for ; Mon, 20 Apr 2026 19:03:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776737021; x=1777341821; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=hy29epMyfsYUurE4pd5MGoUMpPF9IzGtxLeHSnRuzNM=; b=q4OlvWCYyYoaxhpQOR1fMVaxFiQ79R2yabBUFv/tnJot0rSwfrjWTk6kkGQMNXoMBB yNkKbcRA/vX4voICkcScVWJo+51e2p/zDzRBt+/K5riE/knxSNaeTW4F1n/EvEXzlGG2 EaURviheocga7X61wFnEQapx/OunM5Q1ISAW7DeOF+lHp40HYah17plAta/QFd2pt7i2 VvO9WcLRMRO+iWW0JPODnp+Zfeh/mB3eBKNry0DAGsakJGkbnsIGQ8r2I9QzkdbLhGWF rS7LWEUE9RFD39hfVjWN8QinD+QYs31oa+9/vs11cA7m9hFD1K7lQl9s5NXrTh9EEHqn dZ3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776737021; x=1777341821; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hy29epMyfsYUurE4pd5MGoUMpPF9IzGtxLeHSnRuzNM=; b=FKhHuX1Ds+cXUdLz2V+voF3r+XSqIBAeaJnnoPgJhpwMUJfdbtXHaVa3LFPRdQfgUI +lf/++wTd5sMcnQpySrI4ucz0Zs8zLnMG4iXW272Kxwg5tIdVJFDX2Uuf3xl/Ct+rS1F aAqQWJWioONbr5hZFXuyp4xpILvCnmhwRfVA0gw4+aGcGh2M031vOzeuWoVZJ/CLvshu BsuyCK9VaTd9JjwpIzLjd26YgXRxrR97uv/Ob1sFv0mmpJpnRIt9h8hj0/hE6y+EKExU p9F0566VnfK7XmBDylwa+jpfnUSi0R3L7BznaC6pbwcMFYb3fGWrNseCPdA/Vd9yRIIb GYDA== X-Forwarded-Encrypted: i=1; AFNElJ/Ux7d2IiIntne3068XAMi4nf18T4aY7oauKYF5VmsTPuOSLLQCxpC1BGNdTmo8sfJmeGnq4NbUpa9S+64=@vger.kernel.org X-Gm-Message-State: AOJu0Yz/ouSn2bHL23i2MuAxaf2Vi9BDJcPFBKvhJkL3ZjoujLX+5F7d xUclkbdNifOJ9M+mVT/rsSTzNQKe3/nPbIsluTiTCb62QdDwnGN5bgoR X-Gm-Gg: AeBDiesuN367iir5h3FKy3t+GfaqiD5CZORltQddjVmZBxhcARI0hQHTGNZ3ZyA+Zh7 tDgkt655dbRSH0zTfbx78Yn9ca/eagDnhA5GPxjNic76sBlkq6804oRlURPKdKdZmD8q6ziAUo8 tTTW98+snAl9BG8dLkvcoo0GmkOR5jihHoO38CsSGveWxMWcH3i2yJAA8diahkUJSNriiPyx1hn O/LHKu4rqaxrc3BzSpofjRDCI6P4QUSke/yVpgbIhcvdW0BgxQV+TJqG1UHZpYRIADCZ6211BYN x3Jdt+UN8NycDBcSlLXUOwmqjB4kCdBFhBioVvEh0qMnB2Io0jPv/Mo1d4P/cwl8vvb2aoYnIBZ oPym/03Z8bFGdl0hxXHUwECS2U5ZMkRtDVd6UsIqaR7QDekUqvvEMxqGlty52vgAIKHFXAkJGex lJm1KVd7y3HBBNp+erV6AivEATKFsB8ffqUg/if/o9JdQbLZqWAzxhqNiaLA== X-Received: by 2002:a05:6a00:4b01:b0:82f:49b5:cfc3 with SMTP id d2e1a72fcca58-82f8b551df5mr13447987b3a.18.1776737020637; Mon, 20 Apr 2026 19:03:40 -0700 (PDT) Received: from ehlo.thunderbird.net ([2401:4900:ae21:d323:b31b:43e0:4f1e:901c]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8ec05391sm12529130b3a.56.2026.04.20.19.03.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Apr 2026 19:03:40 -0700 (PDT) Date: Tue, 21 Apr 2026 07:23:41 +0530 From: Sanjay Chitroda To: Andy Shevchenko CC: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iio: accel: mma8452: use pm_ptr() for dev_pm_ops User-Agent: Thunderbird for Android In-Reply-To: References: <20260414192045.3598010-1-sanjayembedded@gmail.com> Message-ID: <01DD8F0A-6CB9-4C98-91B9-0754E82BC588@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 15 April 2026 3:12:15=E2=80=AFpm IST, Andy Shevchenko wrote: >On Wed, Apr 15, 2026 at 12:50:45AM +0530, Sanjay Chitroda wrote: > >> Use pm_ptr() so the PM ops pointer is automatically set to >> NULL when CONFIG_PM is disabled=2E This avoids unused-function warnings >> and follows modern kernel power-management conventions=2E > >=2E=2E=2E > >> static const struct dev_pm_ops mma8452_pm_ops =3D { >> SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, pm_runtime_force_re= sume) > >You also want to change this to DEFINE_RUNTIME_DEV_PM_OPS()=2E > Hi Andy, Thank you for the review and feedback=2E I will update changes in next version=2E Thank, Sanjay Chitroda