From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756162AbdKCNRy (ORCPT <rfc822;w@1wt.eu>);
        Fri, 3 Nov 2017 09:17:54 -0400
Received: from mail-io0-f196.google.com ([209.85.223.196]:56653 "EHLO
        mail-io0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755972AbdKCNRw (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 3 Nov 2017 09:17:52 -0400
X-Google-Smtp-Source: ABhQp+RklJ2jnr9jIdtqIN5PYcbJRsJIAGFU/Mxh/zf1a8oF6Buz5i70X9tumMri7ZGlZj7Uu6Wjsw==
Subject: Re: [PATCH] soc: qcom: remove unused label
To: Arnd Bergmann <arnd@arndb.de>, Andy Gross <andy.gross@linaro.org>,
        David Brown <david.brown@linaro.org>
Cc: Rob Herring <robh@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20171018083041.3072321-1-arnd@arndb.de>
From: Alex Elder <elder@ieee.org>
Message-ID: <01a0ee1e-660c-80b2-150a-78f13b12fd46@ieee.org>
Date: Fri, 3 Nov 2017 08:17:50 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171018083041.3072321-1-arnd@arndb.de>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/18/2017 03:30 AM, Arnd Bergmann wrote:
> The newly added driver comes with a harmless warning:
> 
> drivers/soc/qcom/rmtfs_mem.c: In function 'qcom_rmtfs_mem_probe':
> drivers/soc/qcom/rmtfs_mem.c:211:1: error: label 'remove_cdev' defined but not used [-Werror=unused-label]
> 
> This removes the unused label to avoid the warning.
> 
> Fixes: 702baebb8e00 ("soc: qcom: Remote filesystem memory driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Looks good.

Reviewed-by: Alex Elder <elder@linaro.org>

> ---
>  drivers/soc/qcom/rmtfs_mem.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/soc/qcom/rmtfs_mem.c b/drivers/soc/qcom/rmtfs_mem.c
> index f6f2f0cb3b3a..ce35ff748adf 100644
> --- a/drivers/soc/qcom/rmtfs_mem.c
> +++ b/drivers/soc/qcom/rmtfs_mem.c
> @@ -208,8 +208,6 @@ static int qcom_rmtfs_mem_probe(struct platform_device *pdev)
>  
>  	return 0;
>  
> -remove_cdev:
> -	cdev_device_del(&rmtfs_mem->cdev, &rmtfs_mem->dev);
>  put_device:
>  	put_device(&rmtfs_mem->dev);
>  
>