From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752558AbbJOHqC (ORCPT <rfc822;w@1wt.eu>);
	Thu, 15 Oct 2015 03:46:02 -0400
Received: from mail113-251.mail.alibaba.com ([205.204.113.251]:44759 "EHLO
	us-alimail-mta1.hst.scl.en.alidc.net" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1751771AbbJOHqA (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 15 Oct 2015 03:46:00 -0400
X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R511e4;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e02c03285;MF=hillf.zj@alibaba-inc.com;NM=1;PH=DS;RN=5;SR=0;
Reply-To: "Hillf Danton" <hillf.zj@alibaba-inc.com>
From: "Hillf Danton" <hillf.zj@alibaba-inc.com>
To: "'Lukasz Pawelczyk'" <l.pawelczyk@samsung.com>
Cc: "Andy Lutomirski" <luto@amacapital.net>,
        "Kees Cook" <keescook@chromium.org>,
        "linux-kernel" <linux-kernel@vger.kernel.org>,
        <linux-security-module@vger.kernel.org>
References: <019801d1071b$2c124000$8436c000$@alibaba-inc.com>
In-Reply-To: <019801d1071b$2c124000$8436c000$@alibaba-inc.com>
Subject: Re: [PATCH v4 09/11] smack: namespace groundwork
Date: Thu, 15 Oct 2015 15:38:56 +0800
Message-ID: <01a101d1071c$8ce631b0$a6b29510$@alibaba-inc.com>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Outlook 14.0
Thread-Index: AQGwINKpDRsl9OAWOmdjA0WePMlYyp6t9ULg
Content-Language: zh-cn
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> 
> +static inline void smack_userns_free(struct user_namespace *ns)
> +{
> +	struct smack_ns *snsp = ns->security;
> +	struct smack_known *skp;
> +	struct smack_known_ns *sknp, *n;
> +
> +	list_for_each_entry_safe(sknp, n, &snsp->smk_mapped, smk_list_ns) {
> +		skp = sknp->smk_unmapped;
> +
> +		mutex_lock(&skp->smk_mapped_lock);
> +		list_del_rcu(&sknp->smk_list_known);
> +		if (sknp->smk_allocated)
> +			kfree(sknp->smk_mapped);
> +		kfree(sknp);

sknp is released,
> +		mutex_unlock(&skp->smk_mapped_lock);
> +
> +		list_del(&sknp->smk_list_ns);

but it is used again! typo?
> +	}
> +
> +	kfree(snsp);
> +}
> +
>