From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751239AbcHAH2K (ORCPT ); Mon, 1 Aug 2016 03:28:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52952 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750716AbcHAH2H (ORCPT ); Mon, 1 Aug 2016 03:28:07 -0400 Subject: Re: [PATCH 3/3] ehci-platform: add the max clock number to 4 To: Icenowy Zheng , Arnd Bergmann , "linux-arm-kernel@lists.infradead.org" References: <20160731112536.4625-1-icenowy@aosc.xyz> <20160731112536.4625-3-icenowy@aosc.xyz> <2477355.hXm3xYUusy@wuerfel> <414101470035152@web9j.yandex.ru> Cc: Rob Herring , Maxime Ripard , Chen-Yu Tsai , Mark Rutland , "devicetree@vger.kernel.org" , "linux-usb@vger.kernel.org" , Greg Kroah-Hartman , Reinder de Haan , "linux-kernel@vger.kernel.org" , Kishon Vijay Abraham I , Tony Prisk , Alan Stern From: Hans de Goede Message-ID: <01a348da-3b26-68a6-9d9f-c37d81b4fd64@redhat.com> Date: Mon, 1 Aug 2016 09:27:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <414101470035152@web9j.yandex.ru> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Mon, 01 Aug 2016 07:27:21 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 01-08-16 09:05, Icenowy Zheng wrote: > clocks = <&ccu CLK_A64_BUS_OHCI1>, > <&ccu CLK_A64_BUS_EHCI1>, > <&ccu CLK_A64_USB_OHCI0>, > <&ccu CLK_A64_USB_OHCI1>; > > On A64, EHCI requires the matched OHCI to work. Ah, so just like on the H3 (where this also is needed and not documented). > And OHCI1 clock requires OHCI0 clock to work. Hmm, that one is new, can you double check this ? Regards, Hans > > (But from the SoC's user manual we cannot get any infomation > about the relationship between OHCI1 clock and OHCI0 clock, > and in the manual OHCI0 clock is called OTG-OHCI) > > 01.08.2016, 15:01, "Arnd Bergmann" : >> On Sunday, July 31, 2016 7:25:36 PM CEST Icenowy Zheng wrote: >>> Allwinner A64 EHCI requires 4 clocks to be enabled. >>> >>> Signed-off-by: Icenowy Zheng >> >> Can you say what those four clocks are? >> >> Are you sure that it's not just a case of a clock being >> incorrectly described in the clk driver, i.e. you reference >> one clock along with its parent here? >> >> Arnd