From: Anton Eliasson <anton.eliasson@axis.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linux-samsung-soc@vger.kernel.org>,
<linux-serial@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<kernel@axis.com>
Subject: Re: [PATCH] tty: serial: samsung: Set missing PM ops for hibernation support
Date: Wed, 9 Aug 2023 15:19:27 +0200 [thread overview]
Message-ID: <01a3c57a-bef4-9a9e-3f8b-0231653232a8@axis.com> (raw)
In-Reply-To: <9967fa81-f3f4-04c4-a837-d507a19989cc@linaro.org>
On 07/08/2023 15.50, Krzysztof Kozlowski wrote:
> On 03/08/2023 13:26, Anton Eliasson wrote:
>> At least freeze, restore and thaw need to be set in order for the driver
>> to support system hibernation. The existing suspend/resume functions can
>> be reused since those functions don't touch the device's power state or
>> wakeup capability. Use the helper macros SET_SYSTEM_SLEEP_PM_OPS and
>> SET_NOIRQ_SYSTEM_SLEEP_PM_OPS for symmetry with similar drivers.
>>
> Looks sensible, although you should also test the other sleep methods,
> e.g. suspend to idle.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Best regards,
> Krzysztof
>
Yes, s2idle still works. Standby / Power-On Suspend and s2ram we don't
have support for so I can't test it. Thanks for the review!
Anton Eliasson
prev parent reply other threads:[~2023-08-09 13:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 11:26 Anton Eliasson
2023-08-05 21:38 ` Andi Shyti
2023-08-07 9:57 ` Anton Eliasson
2023-08-07 21:34 ` Andi Shyti
2023-08-09 13:57 ` Anton Eliasson
2023-08-07 13:50 ` Krzysztof Kozlowski
2023-08-09 13:19 ` Anton Eliasson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01a3c57a-bef4-9a9e-3f8b-0231653232a8@axis.com \
--to=anton.eliasson@axis.com \
--cc=alim.akhtar@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kernel@axis.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®