From: Markus Elfring <Markus.Elfring@web.de>
To: Yu Kuai <yukuai3@huawei.com>,
linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Yi Zhang <yi.zhang@huawei.com>, Barry Song <baohua@kernel.org>
Subject: Re: [PATCH] pinctrl: sirf: Add missing put_device() call in sirfsoc_gpio_probe()
Date: Tue, 2 Jun 2020 20:56:42 +0200 [thread overview]
Message-ID: <01abac73-2107-daf2-d7bd-bef9d73d554a@web.de> (raw)
> in sirfsoc_gpio_probe(), if of_find_device_by_node() succeed,
> put_device() is missing in the error handling patch.
How do you think about another wording variant?
A coccicheck run provided information like the following.
drivers/pinctrl/sirf/pinctrl-sirf.c:798:2-8: ERROR: missing put_device;
call of_find_device_by_node on line 792, but without a corresponding
object release within this function.
Generated by: scripts/coccinelle/free/put_device.cocci
Thus add a jump target to fix the exception handling for this
function implementation.
Would you like to add the tag “Fixes” to the commit message?
Regards,
Markus
next reply other threads:[~2020-06-02 18:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 18:56 Markus Elfring [this message]
2020-06-03 1:12 ` yukuai (C)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01abac73-2107-daf2-d7bd-bef9d73d554a@web.de \
--to=markus.elfring@web.de \
--cc=baohua@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®