From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753540AbcFGGdf (ORCPT <rfc822;w@1wt.eu>);
	Tue, 7 Jun 2016 02:33:35 -0400
Received: from out4133-146.mail.aliyun.com ([42.120.133.146]:47026 "EHLO
	out4133-146.mail.aliyun.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1751500AbcFGGdd (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 7 Jun 2016 02:33:33 -0400
X-Greylist: delayed 318 seconds by postgrey-1.27 at vger.kernel.org; Tue, 07 Jun 2016 02:33:33 EDT
X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R101e4;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e02c03296;MF=hillf.zj@alibaba-inc.com;NM=1;PH=DS;RN=10;SR=0;TI=SMTPD_----4u-wFwJ_1465280868;
Reply-To: "Hillf Danton" <hillf.zj@alibaba-inc.com>
From: "Hillf Danton" <hillf.zj@alibaba-inc.com>
To: "'Mike Kravetz'" <mike.kravetz@oracle.com>, <linux-mm@kvack.org>,
        <linux-kernel@vger.kernel.org>
Cc: "'Andrea Arcangeli'" <aarcange@redhat.com>,
        "'Hugh Dickins'" <hughd@google.com>,
        "'Dave Hansen'" <dave.hansen@linux.intel.com>,
        "'Kirill A. Shutemov'" <kirill.shutemov@linux.intel.com>,
        "'Naoya Horiguchi'" <n-horiguchi@ah.jp.nec.com>,
        "'Michal Hocko'" <mhocko@suse.com>,
        "'Andrew Morton'" <akpm@linux-foundation.org>
References: <1465235131-6112-1-git-send-email-mike.kravetz@oracle.com> <1465235131-6112-4-git-send-email-mike.kravetz@oracle.com>
In-Reply-To: <1465235131-6112-4-git-send-email-mike.kravetz@oracle.com>
Subject: Re: [RFC PATCH 3/6] mm/userfaultfd: add __mcopy_atomic_hugetlb for huge page UFFDIO_COPY
Date: Tue, 07 Jun 2016 14:27:48 +0800
Message-ID: <01ad01d1c085$b61fdd60$225f9820$@alibaba-inc.com>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Outlook 14.0
Thread-Index: AQFIAb16Dzin1UVn/An5D6g5RcAXAwJIr/QzoN7B7qA=
Content-Language: zh-cn
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> @@ -182,6 +354,13 @@ retry:
>  		goto out_unlock;
> 
>  	/*
> +	 * If this is a HUGETLB vma, pass off to appropriate routine
> +	 */
> +	if (dst_vma->vm_flags & VM_HUGETLB)

Use is_vm_hugetlb_page()?
And in cases in subsequent patches?

Hillf
> +		return  __mcopy_atomic_hugetlb(dst_mm, dst_vma, dst_start,
> +						src_start, len, false);
> +
> +	/*
>  	 * Be strict and only allow __mcopy_atomic on userfaultfd
>  	 * registered ranges to prevent userland errors going
>  	 * unnoticed. As far as the VM consistency is concerned, it
> --
> 2.4.11