From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13EE6C433EF for ; Fri, 20 May 2022 12:50:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349553AbiETMui (ORCPT ); Fri, 20 May 2022 08:50:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349453AbiETMub (ORCPT ); Fri, 20 May 2022 08:50:31 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A13F166D5A for ; Fri, 20 May 2022 05:50:28 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id c19so1049294lfv.5 for ; Fri, 20 May 2022 05:50:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=rw557JuqqBfkrIeMqm9Q73SdR1LCTiOOmhhgFZlhrWo=; b=Nps8png1xqwqaXRARrrO0C+DfZYSf2bntdBhj+6Ri1e5U4zbqewJS2ReLdLXfNseaJ +GR6dNvZ9KmcKDqw/yAl8FIa9T7xhwJrHW8hzzaPVmLQCh/qJMZcx7lzHVsCQPn1W+jN DY3inZbdl0olc/vIN+nPO2SEXkZ/nAdDnYFkDBVBqn67nzFjwvq7zc4ClLDNHVW/ycJT 51cR7UgzrqLkUzOO+ME7jdVLz2vTdnOdejHIyBsCsg5Ww6kYnNN7TRp+1SkD80OcTU15 0qCO24dIDN7iM9RzktkTAHwFacxgYU67R9uEPwvleLP2sejndHkw8Ios1VlFVDa7CZwe JN/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=rw557JuqqBfkrIeMqm9Q73SdR1LCTiOOmhhgFZlhrWo=; b=yHQ7DZxDIOCvY63WTs6zCqWqMbz5mXt1MjHohm7x3s4YqSWKxZULIlg8OFJ1MOwEy+ Ry+mLuABWRQNwrXimWbZwcVbDGp9CGRE8E/Y3o0Ia4NhlGiIIHHo8Yrpl+MTDkOidAgb As8k/NwC7qSlWqwB5YcD+Mvq21JEGnmHPCv+kzX+mrJ71kt5LX7yyoP/G3eVWTzrJ/F/ 4zjMtWBpx5B+2DScXaYyepHblOiSutIAR7SAyaQyS4nw4tlztgErFcmfTEwYNYr1Fb9f 4BYbm9g0oik9q/5KNbyJF1UeduwJ2msKNQFdlXB8i1hQFMdlJrCozxBr6c/sQCnhnZ0g jtFA== X-Gm-Message-State: AOAM531v9VyTZTMRljbQRZj/KUwScan2S0Hryn7fmC8r96VRMD+ULLxY mHiHCoosfZiAy29I4lnrAxEP0A== X-Google-Smtp-Source: ABdhPJxEkqrTB396TYyemRowxMKtKjQKYNzjkppAXp92YM0ZAbZjILr9av0gjhay7sjVxpd9D2tQjA== X-Received: by 2002:a19:5e55:0:b0:477:bae8:e5fc with SMTP id z21-20020a195e55000000b00477bae8e5fcmr6671440lfi.14.1653051026539; Fri, 20 May 2022 05:50:26 -0700 (PDT) Received: from [192.168.0.17] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id v5-20020a2e9605000000b0024f3d1daeaasm309855ljh.50.2022.05.20.05.50.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 May 2022 05:50:25 -0700 (PDT) Message-ID: <01b31a02-523e-10bf-3b46-5b830e456522@linaro.org> Date: Fri, 20 May 2022 14:50:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 2/3] dt-bindings: usb: atmel: Add Microchip LAN966x compatible string Content-Language: en-US To: Herve Codina Cc: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Michael Turquette , Stephen Boyd , Horatiu Vultur , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Thomas Petazzoni References: <20220513105850.310375-1-herve.codina@bootlin.com> <20220513105850.310375-3-herve.codina@bootlin.com> <8f0d4127-7e66-cf50-21c9-99680f737e30@linaro.org> <20220520133426.3b4728ae@bootlin.com> <20220520142109.57b84da2@bootlin.com> From: Krzysztof Kozlowski In-Reply-To: <20220520142109.57b84da2@bootlin.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/05/2022 14:21, Herve Codina wrote: >>> I think it makes sense to keep 'microchip,lan966x-udc' for the USB >>> device controller (same controller on LAN9662 and LAN9668) and so >>> keeping the same rules as for other common parts. >> >> Having wildcard was rather a mistake and we already started correcting >> it, so keeping the "mistake" neither gives you consistency, nor >> correctness... >> > > I think that the "family" compatible should be present. > This one allows to define the common parts in the common > .dtsi file (lan966x.dtsi in our case). > > What do you think about: > - microchip,lan9662-udc > - microchip,lan9668-udc > - microchip,lan966-udc <-- Family > > lan966 is defined as the family compatible string since (1) in > bindings/arm/atmel-at91.yaml and in Documentation/arm/microchip.rst > You can add some family compatible, if it makes sense. I don't get why do you mention it - we did not discuss family names, but using wildcards... Just please do not add wildcards. Best regards, Krzysztof