From: Krzysztof Kozlowski <krzk@kernel.org>
To: Franz <franzelfranzel@gmail.com>,
Jeff Johnson <jjohnson@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: Johannes Berg <johannes@sipsolutions.net>,
Abel Vesa <abelvesa@kernel.org>,
ath12k@lists.infradead.org, linux-wireless@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC 2/3] wifi: ath12k: honour disable-rfkill from the device tree
Date: Sat, 3 Oct 2026 11:28:56 +0200 [thread overview]
Message-ID: <01b38753-d66e-48e3-a5b2-1482afd5c0c2@kernel.org> (raw)
In-Reply-To: <20261003091509.4822-3-franzelfranzel@gmail.com>
On 03/10/2026 11:15, Franz wrote:
> ath12k_core_rfkill_config() skips the hardware rfkill setup only when
> ACPI says so. DT-based boards have no equivalent. On the Microsoft
> Surface Pro 11 (X1E80100), the WCN7850 rfkill input reads as "radio
> off", so the interface is hard-blocked:
>
> iwd: Error bringing interface 4 up: Operation not possible due to RF-kill
>
> Also skip the setup when the device's DT node has "disable-rfkill". The
> PCI core attaches the node to the pci_dev, so ab->dev->of_node sees it.
>
> Tested on a Surface Pro 11 with next-20260929 and the matching DT
> change: the interface comes up and connects (5 GHz, 160 MHz).
>
> Assisted-by: Claude:claude-opus-5-5
LLM, see docs.
> Signed-off-by: Franz <franzelfranzel@gmail.com>
Please read submitting patches document carefully to understand what is
needed when sending patch, e.g. what you need to certify with your full
name.
Your LLM cannot certify anything.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-10-03 9:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-03 9:15 [PATCH RFC 0/3] Allow DT boards to disable WCN7850 hardware rfkill Franz
2026-10-03 9:15 ` [PATCH RFC 1/3] dt-bindings: net: wireless: qcom,ath12k: add disable-rfkill Franz
2026-10-03 9:27 ` Krzysztof Kozlowski
2026-10-03 9:15 ` [PATCH RFC 2/3] wifi: ath12k: honour disable-rfkill from the device tree Franz
2026-10-03 9:28 ` Krzysztof Kozlowski [this message]
2026-10-03 9:15 ` [PATCH RFC 3/3] arm64: dts: qcom: x1-microsoft-denali: disable WCN7850 hardware rfkill Franz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01b38753-d66e-48e3-a5b2-1482afd5c0c2@kernel.org \
--to=krzk@kernel.org \
--cc=abelvesa@kernel.org \
--cc=andersson@kernel.org \
--cc=ath12k@lists.infradead.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=franzelfranzel@gmail.com \
--cc=jjohnson@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®