From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B47A42D73B9 for ; Tue, 30 Jun 2026 09:43:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782812589; cv=none; b=gQYZ+1EAgXsXti+a5tHlFSgdifqrmUv6MTznaTxsMEV4yukI51cTw4NVG1kQ+gprDL1D/+l13rxgGt6fWt2GSrBrJnfApbXDNLK4tm+rU3tW84h/18FlQoSRZ939fKOHQblTM+HXn0YIb42TJKlocLdSOGPDKtViZS3gaillFjg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782812589; c=relaxed/simple; bh=gjuHbqLsc1t77MjXkOk1s5u4i5Rjk4tLfCfcxr3gdFA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NiKAIFCh1Pf8/YvCbPyrIECfnJ8Gqr+Smq6BCp4cqemaKQgw8RCkGvITofiBMCZEG7BM7pXe6iiN0KtH6X6yAL7X6CPSknD9miToEFOhtjFhxy8bay7p5r3icvChg++U1jAwdrVsB8dpAvWw6gFwW9AWMoG5T5JITmiBmsiXUO8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PNleNZGS; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cyqEMFNe; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PNleNZGS"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cyqEMFNe" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65U6CKxo1089388 for ; Tue, 30 Jun 2026 09:43:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= e0z6v/3XR6OT9Ka0uNrvJzg5uwpb1hRYu/d4UpVlOv4=; b=PNleNZGSVmPM7rZP 9sfZm+GQRNYfefjKUjpUh1iDvO+2jsv4LZeiiDQ4R0DD6vTR5RMGSlTw9FABAIsg lS+hE7Q5FIdRD2usKDwY5rxRNuy2iEokj4Xs+TIYadDHPxUpB2MmKkC5Dg82DGkH T3Bad+tatwGzW+AET9HPufoIe5KgMrzejkpS7/UM7LrYhRi4MjorYpvJ3FXjTphG KzpcqwYtOiANauZHVhP1uPDkNmF8IcZp8Z8ibdGT28K9whBWyqym0gnSllACCy3P RK/FWWA2PGCccsGFOzblUdYR4kPPbtoiHISnSRx9vRh1TMeUSeXnw3wdhbujDSZu FpQ6nQ== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f43vfhwp4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Jun 2026 09:43:07 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-8478a1ec69fso1527172b3a.0 for ; Tue, 30 Jun 2026 02:43:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782812587; x=1783417387; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=e0z6v/3XR6OT9Ka0uNrvJzg5uwpb1hRYu/d4UpVlOv4=; b=cyqEMFNebEpN5yBlm+v5mbkT0578cOsyohZMfdgbN4AEzkF/8l3sJJi8un8d10ZzlE xH7UuBobftua2lgluwBPloLl+O517VUAVJwgwF+VYHQfAyddLOmg+eoTHpdBgoeqyzfs e98+c8156dDX0gWjWbm/bS8f9uA1dmAoscSdWismDUQipOIQCqImsziMI3Q0zTKGOWD7 5f/Wuuvon67LiSRuQFrtOdQwNUeAq8z2BsDpZVUz5GczW4tA+vxa2PIhZz+3cVrTfpLz 8hYEjaVmRYqlXjHSMaLe/rgIAczDuErfpNlm65+ps7yHHIFqaQo7qasn8mP6Iylf+uQ4 ZGlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782812587; x=1783417387; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=e0z6v/3XR6OT9Ka0uNrvJzg5uwpb1hRYu/d4UpVlOv4=; b=L87Zkc8pBD+m7bD8RDW4jBgkUu5X957HQG05QoqcB1Qd46kZFUbAAq2NY83sazZbk6 Z6vzHHFilQG5OM2tiO5omDP0CCjQgA3GQblV7K7kr/CoJYBRUhDlFfdeuL7+kJO/R4JS cvXb75s2pv9kHlzZOsE8nQWoBegPZw8vADFFVnHPL1e+SmKeriXminCOwPrQaT2duqMS 9SsPhKNY1E3mJpmP3rDGWpTm0Dbs8tlB9Pz2d3mgIw03KklhPzi1c04ixSVVeJ943GEl N78rgGRyb3HLoUPr9+DaI2ywsfHAfb1HOg7NqSMKtwlAcb/CYQpbQhZZ7jPMFDouJwAi VL+A== X-Forwarded-Encrypted: i=1; AFNElJ8rQQdpCxCeBsGG5/lIMPtGMvuOvn+rX7aD9fz0jLPEcDcn0JohlI7TWWG864ZcoORHLfWmlmxmkIkIJyg=@vger.kernel.org X-Gm-Message-State: AOJu0YxoWqr43R6a0tncV95EAxUS06i4zJLED4W1RFREQ8Hj9AsyZQqa /32lOzQpxTLC3GRZph6mvASPhkSF19+020hyShB3W18V8bRXhKNwFTPFjU788HWZibmBjbrpinz ZXui+sQieLluvbN5lgVJbMRcMa+u5DMXKbjUWlW+S1FYNF8XgY25T8WKrhygSKj8H4IE= X-Gm-Gg: AfdE7cmk19O1uZYavmVuwCTK099WEMfClQ8o3CudPnDvL9VJ6AGU5TfKDAk26bXQbsr JmFgvQrSFJQ8oSocNy3OPKPJgqDLH2zO7B2WoqP+lvwDynwbwlb3cQ9hgUdPSuVaNpiUP9BSpOm zvJYaf33LnBkLdYISXCgyR2UE0IdY5wbMM8zb0CmW9wV1kKdcIf0Z7SRKLKzZutPbwNMFqSpInS 8S68Krr14nMbwhvCKWuqZbw6UKRpqwxQy6fZQQOAQTHgXZDPvH9Z8S0YlqHZQstMBwGv+qLMP4s Trk806l/KsbFf9BotG1orAH/R9dC6zQ+4a9oYmb29feYf5jHvtAaWyhhUTx88yZCrQ+7s2Pykv9 A8p2jQA3zlkHLiEDAMbacCkuEaxZy7Ghgs23XtjQ= X-Received: by 2002:a05:6300:4047:b0:3bf:b6e3:fbe1 with SMTP id adf61e73a8af0-3bfc549e62amr2736297637.55.1782812587215; Tue, 30 Jun 2026 02:43:07 -0700 (PDT) X-Received: by 2002:a05:6300:4047:b0:3bf:b6e3:fbe1 with SMTP id adf61e73a8af0-3bfc549e62amr2736273637.55.1782812586756; Tue, 30 Jun 2026 02:43:06 -0700 (PDT) Received: from [10.152.196.198] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-847a002c995sm1549725b3a.24.2026.06.30.02.43.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jun 2026 02:43:06 -0700 (PDT) Message-ID: <01b3c5b2-bd31-4862-ad4b-ebabc29f57a1@oss.qualcomm.com> Date: Tue, 30 Jun 2026 15:13:02 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] wifi: ath12k: Flush the posted write after writing to PCIE_SOC_GLOBAL_RESET To: Manivannan Sadhasivam , jjohnson@kernel.org Cc: linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, ath11k@lists.infradead.org, linux-kernel@vger.kernel.org, mani@kernel.org, Alex Williamson References: <20260623141649.41087-1-manivannan.sadhasivam@oss.qualcomm.com> <20260623141649.41087-2-manivannan.sadhasivam@oss.qualcomm.com> Content-Language: en-US From: Raj Kumar Bhagat In-Reply-To: <20260623141649.41087-2-manivannan.sadhasivam@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: 5bv_LNkjB1mJw1Dha8H2NF99ntD3NR9H X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjMwMDA4NyBTYWx0ZWRfX6GIRVAndqgkG uHbwt4vz0ovXUZ8+VzL2DFh1I89iomgkr5OEQ2VNBqLp8WSKZBPKKYti1otevExkMt7ZSQ7JrCm PAfsaYwLzx7ycth54fmxzOU7Oy6fGrLPN9+kEpwbzJs0lTOR6KcWsOyZPu3UytW+8Dk1O/NQPQR Wmxo19Ek5n5eAElorCSEQi//A/BQEYPLA1d/2cnn6MN1PbTmc2yvyeWsCnTbUkV2PhDTfcuP49T RdZF+1GgCMWXysRf1QVzGRWGN76o/nFx3OxKsps8LrWnD/ut7UuLK2UhPE1KUy8qJC1wqA+BX9O UE7iTmqCFgadQ2OEm0eQcxpaXcarA5dEeOeBMrQIbNIK3udW5QjqwUZ3udYw5J73IQgB4fQDRyu 5ScbCq3/naGZ4TuinhngpQIFQU0xAY7ii6op6qc/G9DQ0ZY35MUAUH1VCQN3khpP3N2KEzeXS+m MZ8K/iHQm4K7AUSN/cg== X-Proofpoint-Spam-Info: AW1haW4tMjYwNjMwMDA4NyBTYWx0ZWRfX7n7vygHcm42O Ppt3MYp2efhhOY4eJ4FixgBRlX0WU8gAH+YwyK5+zRW/Z1TLT85VSTVNfxl5VqEadKx97AbjJIt X8k0pxCweE4KXMVHBpFc7KAkJ2nfx+0= X-Proofpoint-GUID: 5bv_LNkjB1mJw1Dha8H2NF99ntD3NR9H X-Authority-Analysis: v=2.4 cv=PcXPQChd c=1 sm=1 tr=0 ts=6a438fab cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=VwQbUJbxAAAA:8 a=r1p2_3pzAAAA:8 a=EUspDBNiAAAA:8 a=-7ihF9cDai9aFXk1VuAA:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 a=r_pkcD-q9-ctt7trBg_g:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-30_02,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 clxscore=1015 impostorscore=0 bulkscore=0 adultscore=0 priorityscore=1501 malwarescore=0 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606300087 On 23-06-2026 19:46, Manivannan Sadhasivam wrote: > ath12k_pci_soc_global_reset() tries to reset the device by writing to the > PCIE_SOC_GLOBAL_RESET register. But it doesn't do a read-back to ensure > that the write gets flushed to the device before the delay. > > This may lead to the delay on the host to be insufficient, if the posted > write doesn't reach the device before the delay. > > So add a read-back after writing to the PCIE_SOC_GLOBAL_RESET register and > before the delay. > > Compile tested only. > > Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices") > Reported-by: Alex Williamson > Closes:https://lore.kernel.org/linux-pci/20260622160822.09350246@shazbot.org > Signed-off-by: Manivannan Sadhasivam > --- > drivers/net/wireless/ath/ath12k/pci.c | 4 ++++ > 1 file changed, 4 insertions(+) Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.6-01243-QCAHKSWPL_SILICONZ-1 Tested-by: Raj Kumar Bhagat Validated with 25+ successful ath12k and ath12k_wifi7 module reload (rmmod/insmod) cycles on QCN9274. -- Raj Bhagat