mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Lukas Bulwahn" <lukas.bulwahn@gmail.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Jiri Slaby" <jirislaby@kernel.org>,
	linux-serial@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty: serial: remove obsolete config SERIAL_SAMSUNG_UARTS_4
Date: Fri, 17 Mar 2023 08:56:47 +0100	[thread overview]
Message-ID: <01b8aa89-2de5-4f98-8b93-659022c7e8e1@app.fastmail.com> (raw)
In-Reply-To: <20230317071538.29366-1-lukas.bulwahn@gmail.com>

On Fri, Mar 17, 2023, at 08:15, Lukas Bulwahn wrote:
> Commit 1ea35b355722 ("ARM: s3c: remove s3c24xx specific hacks"), allows
> simplifying the whole config logic for SERIAL_SAMSUNG_UARTS, and did this
> config simplification. However, it misses that SERIAL_SAMSUNG_UARTS_4's
> effect was just to control SERIAL_SAMSUNG_UARTS, and with the commit's
> change, the config SERIAL_SAMSUNG_UARTS_4 has no remaining effect and can
> be deleted.
>
> Remove this obsolete config SERIAL_SAMSUNG_UARTS_4.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>

Nice find!

I tried to carefully check that all Kconfig options that were
no longer selectable got removed recursively, along with the code
that they control, but I missed this one as I did not search
the other way.

Acked-by: Arnd Bergmann <arnd@arndb.de>

      reply	other threads:[~2023-03-17  7:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-17  7:15 Lukas Bulwahn
2023-03-17  7:56 ` Arnd Bergmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=01b8aa89-2de5-4f98-8b93-659022c7e8e1@app.fastmail.com \
    --to=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®