From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932091AbcFINvw (ORCPT ); Thu, 9 Jun 2016 09:51:52 -0400 Received: from mx0a-0016f401.pphosted.com ([67.231.148.174]:63983 "EHLO mx0a-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751168AbcFINvt (ORCPT ); Thu, 9 Jun 2016 09:51:49 -0400 From: Amitkumar Karwar To: Julian Calaby , Javier Martinez Canillas , Xinming Hu CC: "linux-kernel@vger.kernel.org" , Kalle Valo , netdev , linux-wireless , Nishant Sarmukadam Subject: RE: [PATCH 7/8] mwifiex: don't print an error if an optional DT property is missing Thread-Topic: [PATCH 7/8] mwifiex: don't print an error if an optional DT property is missing Thread-Index: AQHRuCLb0KcdlKMqQEuf6DYk1H3O9Z/Ufw2AgACfbACAAJ0LgIALfnxA Date: Thu, 9 Jun 2016 13:51:45 +0000 Message-ID: <01bb6d9c1c7f4419b2d88051b8e811f4@SC-EXCH04.marvell.com> References: <1464358702-19083-1-git-send-email-javier@osg.samsung.com> <1464358702-19083-8-git-send-email-javier@osg.samsung.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.93.176.43] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-06-09_05:,, signatures=0 X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1606090151 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u59DpuEt017683 > From: Julian Calaby [mailto:julian.calaby@gmail.com] > Sent: Thursday, June 02, 2016 4:44 AM > To: Javier Martinez Canillas; Xinming Hu > Cc: linux-kernel@vger.kernel.org; Amitkumar Karwar; Kalle Valo; netdev; > linux-wireless; Nishant Sarmukadam > Subject: Re: [PATCH 7/8] mwifiex: don't print an error if an optional DT > property is missing > > Hi Javier, > > On Wed, Jun 1, 2016 at 11:51 PM, Javier Martinez Canillas > wrote: > > Hello Julian, > > > > Thanks a lot for your feedback and reviews. > > > > On 06/01/2016 12:20 AM, Julian Calaby wrote: > >> Hi All, > >> > >> On Sat, May 28, 2016 at 12:18 AM, Javier Martinez Canillas > >> wrote: > >>> The > >>> Documentation/devicetree/bindings/net/wireless/marvell-sd8xxx.txt DT > >>> binding document say that the "interrupts" property in the child > node is optional. So the property being missed shouldn't be treated as > an error. > >> > >> Have you checked whether it is truly optional? I.e. nothing else > >> breaks if this property isn't set? > >> > > > > That's what the DT binding says and the IRQ is only used as a wakeup > > source during system suspend, it is not used during runtime. And that > > is why the > > mwifiex_sdio_probe_of() function does not fail if the IRQ is missing. > > Awesome, that's what I wanted to know. > > > Now, I just got to that conclusion by reading the binding docs, the > > message in the commits that introduced this and the driver code. > > Xinming Hu should comment on how critical this feature is for systems > that needs to be wakeup. > > Xinming, could you review this also? > Yes. IRQ is the optional parameter. System has a flexibility to not use it, but it still can configure other device tree parameters. The patch looks good. Regards, Amitkumar