From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7801C35BDA0 for ; Mon, 23 Mar 2026 06:46:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774248396; cv=none; b=IhKk5Y5vWfZCE3V8z2/Lv6hIbLxQ4rzTq7nEz2BC2XxB73pZ0AQz+o0QNN4az1hdxCuLhdZGjmq2DdHokYWOWAW87bPaJQf7K7aaGCXr4nr/5vH6CxnXDlGk08HFVJkPz6Dl4fjoHQOM7t+Vf6fix7GSA/hzeepf6dde3baCqaY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774248396; c=relaxed/simple; bh=YaD+CatjIqfxIvSpZJAbYPQwzCHAxtNUw4nAc7oYroc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FUQv0jlEyWy9WORcp95J9U5N7IGFA/s6KWLeMgrnrw6F1VnjBsA36lfQmsejhaD+QtMTj9evzEHI+1X7+3HqEyA9drW61M5pHFAPrY9cMM50gN9HiQNjH1/8r9zXJQXVUxQhhk9LxEE/PBg7TmXEG+pIRIGjzU23htjM2aWQ7Uc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=j8S//1c1; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Q5mhrDkZ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="j8S//1c1"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Q5mhrDkZ" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62MMlRkv162920 for ; Mon, 23 Mar 2026 06:46:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= JzgrEA8u622UtmJ7BDFdV+2Neo9h7xytlbrUEgoYnlA=; b=j8S//1c1CV4vxAD7 1/OS5fuZttK0wmEfc9YsihpbbwJwmx9EeNZYVkXEXRo6VdRcxGr5WOKU70g1QOWl 2doE6d45nStmLCMkGkab3BppeBhGnOt239mmwvFhEoKzUQKVSg67Z6XEhXHIZRFb FB2bs2kEF4Ue+40jwbk080kNQRe5P/HfTg+1QSGhHAvdzzMldr7zN9VKA9/wdt3C rr8hKoPUMEh+SORmHs3t1xLiK2k/UZVPX8IQVOt93vLiDv3B0mGFtFLRswTlb1yt yGCpRieCzGe1jylYIYJlFQM74WxKAez8TdT487dHr+kyYnV5eERe1Hxsq9k/AMBq YBOYfg== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d1gpk48mr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 23 Mar 2026 06:46:33 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-358e425c261so4547042a91.3 for ; Sun, 22 Mar 2026 23:46:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774248392; x=1774853192; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JzgrEA8u622UtmJ7BDFdV+2Neo9h7xytlbrUEgoYnlA=; b=Q5mhrDkZ5lItoKp+E/dAPB/7rMukvIOK/oCF2VwN4QOAMP6eQ1YHPTAQ7vYBQzcN6/ N3S3YilK8KgFkb5Rl0RX2EFt4u1PdctkEVCNvHwMGwN7trgyMysQTn2WDCh69Cz6g3kv UowEjbGhCgqcu+F0m3npDxXH7Z8ZYp0apgPHmNgMXyP1LfeUB59dUOaWFB81kTfpQM0i AzUP2EdRc0qJvklisdHBGBIlZorvGoesJu3bDvzZyorg0+gm3K7DhCPlMV3ZmhFEgNIG aCyPRxyp9Yo0T9rcoUJdj3Ck7vDeLD5tfCHWbW04+Z3HuOqhOfsGB9Z2NnKfDg2jPFm4 gRzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774248392; x=1774853192; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JzgrEA8u622UtmJ7BDFdV+2Neo9h7xytlbrUEgoYnlA=; b=KbGfVFl0YwYLbf/YF2Pj90yv9iY3Ypksw23s676/Y8N52hddMQ7EKLYZogSZWkujoQ cc5SKtgSc6UkxDdmt1x6Jd20vaS2VqbnIzhUXwWV6oLoq5xpsOA4emTfyQctjxBOoYeD 515Wb76TETucGqDaIpI92BPkghzJ3nHQOGe3+Fl0Z8KpEMVBgns8yofiq3qbsV6dDz2n T4sBNsay5+LnE7hU09Xdkqqm5rO7Z+/oBOHnTlvjCRMP1dICzTc7PQtDWsM2zxwhUj7N YtaLIN/HVI2DMQ9a3Q5SLzsC8ypM0TheqAa8+s1gaUngb5mtw/JQsaXsgrA0IbXMcAyD UiQA== X-Forwarded-Encrypted: i=1; AJvYcCW47r1Jvuw7fn+PagaCToEj35vMU95lwfnCKNVStGb9agmGrMq5y+0szqGaft5WhYl7olHx1tWio19i/3o=@vger.kernel.org X-Gm-Message-State: AOJu0YyJHiLSRNZDcrk/EqhPuAQQOiW1AyaF97mRsiYAijZnvPCeX/lW c833jqR4MF8u8NYgToryZt5CaeE9eEGEarDKorOP0WI/yKKGM9XU1JtKQAugFkM4YpM3vMD8Woa BTEpgadQyrz9ThZtnIOAJFaRXOf5oSHgllvoQ6hiQ/eP19xnfrgJrWHYuux8+CuaNC5I= X-Gm-Gg: ATEYQzx1Rg/GEkb/HKh6XCoOkNnxmtqjzdRvHl7p8LI8lIVhJsXoqYdRoQLrNsRZhDw MGt+8NnsndGNglZTaUHXed38IjBwlatHn1PUZimgkV//UE91Wvu6RoU58lnzBdPaf7HSURF86Xf 0YxO05NvnWgYNf6QdoBmcZzz2U0ALuPoGWSzWE0Kp/Lvzf25S8LOd5sPOSnWj9haeQ86G1FHX8J dJvqC9amHLKkWjGX65EHpGssqbm9VKv+1YAX3/ORdsSdb3u6AP2oLurU3yO27vpo8TTD6/pN4OJ TatCRSTOMddlzEDS5V0wz6efmiMrI/QuV2071biqt4AX2qJUUrXQOtoni3oQ1G1fVUCimKtjd+P T0TCIez33cZfFGO4sHeWxQ6xMsfWphZvcit3lGgGJLqH65I9SHdXnuJoKow6vbEVYpA== X-Received: by 2002:a17:90b:4c48:b0:35b:e844:3bd with SMTP id 98e67ed59e1d1-35be8440fadmr3293680a91.31.1774248392307; Sun, 22 Mar 2026 23:46:32 -0700 (PDT) X-Received: by 2002:a17:90b:4c48:b0:35b:e844:3bd with SMTP id 98e67ed59e1d1-35be8440fadmr3293667a91.31.1774248391804; Sun, 22 Mar 2026 23:46:31 -0700 (PDT) Received: from [10.151.37.217] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35bd33919a0sm4548940a91.2.2026.03.22.23.46.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 Mar 2026 23:46:31 -0700 (PDT) Message-ID: <01bd44db-32b7-4195-ad66-0a608b25dca3@oss.qualcomm.com> Date: Mon, 23 Mar 2026 12:16:26 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] pinctrl: qcom: Introduce IPQ5210 TLMM driver To: Bjorn Andersson Cc: Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov References: <20260318-ipq5210_tlmm-v2-0-182d47b3d540@oss.qualcomm.com> <20260318-ipq5210_tlmm-v2-2-182d47b3d540@oss.qualcomm.com> Content-Language: en-US From: Kathiravan Thirumoorthy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: WmCt4IW-x_asTVQ5tlwB_4YzW1tAhtT2 X-Proofpoint-GUID: WmCt4IW-x_asTVQ5tlwB_4YzW1tAhtT2 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIzMDA1MCBTYWx0ZWRfX+39sU0sUz2Bn i7mSBxVil2aDBgb3McIW/DC7Q8yT67bGljp+KEhBxjS+hdRmFOvHf7sdqnOanLY7ZV4Vx/yo3n7 pUeUhuaP5M6jkD30IW0ufb4mZFaRtdWakWzRdTcVsrkbL8qjH9U/hE7yP+1rl8I5k8VjpHSF6pD pJiLjx6zKCBqJpfSYfQAbPjMkr53zY1X2o/coK6Pqo08ojhJtv+WN8t/Zr7hsiY5DIpS/+GTXMR vEOD1N/sixHu/0GaXOo5rK5hBIrINfUgW7tIGBpWrsnrZOdrGxJ7JHnLiDHhto25RVroI5oA/Eb bp4g9xPDixTEQ5Qe819hbDwMp5x5oTj9b9zylgEsXLZ+qFY8IrUXaIPs9ZmVy9rSWH1Lp3urHWs I6fm+nr4Vgd4Foczt60DS/+MMgNt0kVPPA1qS8NO8yzij5ad9yfyyS/mjtrj3Z8Szsmic+Ffrlz y/6VXfn74uaq0/4ODNw== X-Authority-Analysis: v=2.4 cv=QKhlhwLL c=1 sm=1 tr=0 ts=69c0e1c9 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=xLcBPJq00M2AN48BsqkA:9 a=QEXdDO2ut3YA:10 a=O8hF6Hzn-FEA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-23_02,2026-03-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 bulkscore=0 spamscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 phishscore=0 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603230050 On 3/19/2026 7:47 AM, Bjorn Andersson wrote: > On Wed, Mar 18, 2026 at 12:44:31PM +0530, Kathiravan Thirumoorthy wrote: >> diff --git a/drivers/pinctrl/qcom/pinctrl-ipq5210.c b/drivers/pinctrl/qcom/pinctrl-ipq5210.c > [..] >> +static const struct pinfunction ipq5210_functions[] = { > [..] >> + MSM_PIN_FUNCTION(qup_se5_l01), >> + MSM_PIN_FUNCTION(qup_se5_l10), >> + MSM_PIN_FUNCTION(qup_se5_l11), >> + MSM_PIN_FUNCTION(qup_se5_l2), >> + MSM_PIN_FUNCTION(qup_se5_l3), >> + MSM_PIN_FUNCTION(qup_se5_l4), >> + MSM_PIN_FUNCTION(qup_se5_l5), > Listing each pin of each QUP SE as their own function forces the DT > author to write one state definition per pin. Group these into their > logical functions instead. > > Same thing with other logical functions that you have split into > multiple separate functions. Sure, will take care of this in next spin. > >> + MSM_PIN_FUNCTION(resout), >> + MSM_PIN_FUNCTION(rx_los00), >> + MSM_PIN_FUNCTION(rx_los01), >> + MSM_PIN_FUNCTION(rx_los10), >> + MSM_PIN_FUNCTION(rx_los11), >> + MSM_PIN_FUNCTION(rx_los20), >> + MSM_PIN_FUNCTION(rx_los21), >> + MSM_PIN_FUNCTION(sdc_clk), >> + MSM_PIN_FUNCTION(sdc_cmd), >> + MSM_PIN_FUNCTION(sdc_data), >> + MSM_PIN_FUNCTION(tsens_max), >> +}; >> + >> +static const struct msm_pingroup ipq5210_groups[] = { >> + [0] = PINGROUP(0, sdc_data, qspi_data, pwm, _, _, _, _, _, _), >> + [1] = PINGROUP(1, sdc_data, qspi_data, pwm, _, _, _, _, _, _), >> + [2] = PINGROUP(2, sdc_data, qspi_data, pwm, _, _, _, _, _, _), >> + [3] = PINGROUP(3, sdc_data, qspi_data, pwm, _, _, _, _, _, _), >> + [4] = PINGROUP(4, sdc_cmd, qspi_cs_n, _, _, _, _, _, _, _), >> + [5] = PINGROUP(5, sdc_clk, qspi_clk, _, _, _, _, _, _, _), >> + [6] = PINGROUP(6, qup_se0_l2, led0, pwm, _, cri_trng0, qdss_tracedata_a, _, _, _), >> + [7] = PINGROUP(7, qup_se0_l3, led1, pwm, _, cri_trng1, qdss_tracedata_a, _, _, _), >> + [8] = PINGROUP(8, qup_se0_l0, pwm, audio_pri2, audio_pri2, _, cri_trng2, qdss_tracedata_a, _, _), > How can both function 3 and 4 be "audio_pri2", do you expect the system > integrator to be able to select function 4? Function 3 and 4 are audio_pri_mclk_out and audio_pri_mclk_in respectively and either one of them can be selected based on the codec's mclock requirement. Let me expand the full function to avoid these confusion in the next spin. > >> + [9] = PINGROUP(9, qup_se0_l1, led2, pwm, _, cri_trng3, qdss_tracedata_a, _, _, _), >> + [10] = PINGROUP(10, pon_rx_los, qup_se3_l3, pwm, _, _, qdss_tracedata_a, _, _, _), >> + [11] = PINGROUP(11, pon_active_led, qup_se3_l2, pwm, _, _, qdss_tracedata_a, _, _, _), >> + [12] = PINGROUP(12, pon_tx_dis, qup_se2_l3, pwm, audio_pri0, audio_pri0, _, qrng_rosc0, qdss_tracedata_a, _), >> + [13] = PINGROUP(13, gpn_tx_dis, qup_se2_l2, pwm, audio_pri3, audio_pri3, _, qrng_rosc1, qdss_tracedata_a, _), > Same here. > > Regards, > Bjorn